From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F0B1C34026 for ; Tue, 18 Feb 2020 17:42:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 410A324125 for ; Tue, 18 Feb 2020 17:42:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 410A324125 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1AAC89D30; Tue, 18 Feb 2020 17:42:43 +0000 (UTC) Received: from fireflyinternet.com (unknown [77.68.26.236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 96D2D89D30; Tue, 18 Feb 2020 17:42:42 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from haswell.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 20266933-1500050 for multiple; Tue, 18 Feb 2020 17:42:22 +0000 From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Tue, 18 Feb 2020 17:42:19 +0000 Message-Id: <20200218174219.1301127-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200218122648.1252102-1-chris@chris-wilson.co.uk> References: <20200218122648.1252102-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_schedule: Exercise implicit ordering between engines X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, Sravan Kumar Nedunoori Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Check that reads are serialised after a write, and that a subsequent write is after all reads. Signed-off-by: Chris Wilson Cc: Antonio Argenziano Cc: Sravan Kumar Nedunoori --- tests/i915/gem_exec_schedule.c | 73 ++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c index a20985864..cfd06aa55 100644 --- a/tests/i915/gem_exec_schedule.c +++ b/tests/i915/gem_exec_schedule.c @@ -241,6 +241,61 @@ static void fifo(int fd, unsigned ring) igt_assert_eq_u32(result, 2); } +enum implicit_dir { + READ_WRITE = 0x1, + WRITE_READ = 0x2, +}; + +static void implicit_rw(int i915, unsigned ring, enum implicit_dir dir) +{ + IGT_CORK_FENCE(cork); + unsigned int count; + uint32_t scratch; + uint32_t result; + int fence; + + count = 0; + for_each_physical_engine(other, i915) { + if (eb_ring(other) == ring) + continue; + + count++; + } + igt_require(count); + + scratch = gem_create(i915, 4096); + fence = igt_cork_plug(&cork, i915); + + if (dir & WRITE_READ) + store_dword_fenced(i915, 0, + ring, scratch, 0, -ring, + fence, I915_GEM_DOMAIN_RENDER); + + for_each_physical_engine(other, i915) { + if (eb_ring(other) == ring) + continue; + + store_dword_fenced(i915, 0, + eb_ring(other), scratch, 0, eb_ring(other), + fence, 0); + } + + if (dir & READ_WRITE) + store_dword_fenced(i915, 0, + ring, scratch, 0, ring, + fence, I915_GEM_DOMAIN_RENDER); + + unplug_show_queue(i915, &cork, ring); + close(fence); + + result = __sync_read_u32(i915, scratch, 0); + gem_close(i915, scratch); + + igt_assert_neq_u32(result, -ring); + if (dir & READ_WRITE) + igt_assert_eq_u32(result, ring); +} + static void independent(int fd, unsigned int engine) { IGT_CORK_FENCE(cork); @@ -2042,6 +2097,24 @@ igt_main fifo(fd, eb_ring(e)); } + igt_subtest_f("implicit-read-write-%s", e->name) { + igt_require(gem_ring_has_physical_engine(fd, eb_ring(e))); + igt_require(gem_can_store_dword(fd, eb_ring(e))); + implicit_rw(fd, eb_ring(e), READ_WRITE); + } + + igt_subtest_f("implicit-write-read-%s", e->name) { + igt_require(gem_ring_has_physical_engine(fd, eb_ring(e))); + igt_require(gem_can_store_dword(fd, eb_ring(e))); + implicit_rw(fd, eb_ring(e), WRITE_READ); + } + + igt_subtest_f("implicit-both-%s", e->name) { + igt_require(gem_ring_has_physical_engine(fd, eb_ring(e))); + igt_require(gem_can_store_dword(fd, eb_ring(e))); + implicit_rw(fd, eb_ring(e), READ_WRITE | WRITE_READ); + } + igt_subtest_f("independent-%s", e->name) { igt_require(gem_ring_has_physical_engine(fd, eb_ring(e))); igt_require(gem_can_store_dword(fd, eb_ring(e))); -- 2.25.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Chris Wilson Date: Tue, 18 Feb 2020 17:42:19 +0000 Message-Id: <20200218174219.1301127-1-chris@chris-wilson.co.uk> In-Reply-To: <20200218122648.1252102-1-chris@chris-wilson.co.uk> References: <20200218122648.1252102-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Subject: [igt-dev] [PATCH i-g-t] i915/gem_exec_schedule: Exercise implicit ordering between engines List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: Check that reads are serialised after a write, and that a subsequent write is after all reads. Signed-off-by: Chris Wilson Cc: Antonio Argenziano Cc: Sravan Kumar Nedunoori --- tests/i915/gem_exec_schedule.c | 73 ++++++++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) diff --git a/tests/i915/gem_exec_schedule.c b/tests/i915/gem_exec_schedule.c index a20985864..cfd06aa55 100644 --- a/tests/i915/gem_exec_schedule.c +++ b/tests/i915/gem_exec_schedule.c @@ -241,6 +241,61 @@ static void fifo(int fd, unsigned ring) igt_assert_eq_u32(result, 2); } +enum implicit_dir { + READ_WRITE = 0x1, + WRITE_READ = 0x2, +}; + +static void implicit_rw(int i915, unsigned ring, enum implicit_dir dir) +{ + IGT_CORK_FENCE(cork); + unsigned int count; + uint32_t scratch; + uint32_t result; + int fence; + + count = 0; + for_each_physical_engine(other, i915) { + if (eb_ring(other) == ring) + continue; + + count++; + } + igt_require(count); + + scratch = gem_create(i915, 4096); + fence = igt_cork_plug(&cork, i915); + + if (dir & WRITE_READ) + store_dword_fenced(i915, 0, + ring, scratch, 0, -ring, + fence, I915_GEM_DOMAIN_RENDER); + + for_each_physical_engine(other, i915) { + if (eb_ring(other) == ring) + continue; + + store_dword_fenced(i915, 0, + eb_ring(other), scratch, 0, eb_ring(other), + fence, 0); + } + + if (dir & READ_WRITE) + store_dword_fenced(i915, 0, + ring, scratch, 0, ring, + fence, I915_GEM_DOMAIN_RENDER); + + unplug_show_queue(i915, &cork, ring); + close(fence); + + result = __sync_read_u32(i915, scratch, 0); + gem_close(i915, scratch); + + igt_assert_neq_u32(result, -ring); + if (dir & READ_WRITE) + igt_assert_eq_u32(result, ring); +} + static void independent(int fd, unsigned int engine) { IGT_CORK_FENCE(cork); @@ -2042,6 +2097,24 @@ igt_main fifo(fd, eb_ring(e)); } + igt_subtest_f("implicit-read-write-%s", e->name) { + igt_require(gem_ring_has_physical_engine(fd, eb_ring(e))); + igt_require(gem_can_store_dword(fd, eb_ring(e))); + implicit_rw(fd, eb_ring(e), READ_WRITE); + } + + igt_subtest_f("implicit-write-read-%s", e->name) { + igt_require(gem_ring_has_physical_engine(fd, eb_ring(e))); + igt_require(gem_can_store_dword(fd, eb_ring(e))); + implicit_rw(fd, eb_ring(e), WRITE_READ); + } + + igt_subtest_f("implicit-both-%s", e->name) { + igt_require(gem_ring_has_physical_engine(fd, eb_ring(e))); + igt_require(gem_can_store_dword(fd, eb_ring(e))); + implicit_rw(fd, eb_ring(e), READ_WRITE | WRITE_READ); + } + igt_subtest_f("independent-%s", e->name) { igt_require(gem_ring_has_physical_engine(fd, eb_ring(e))); igt_require(gem_can_store_dword(fd, eb_ring(e))); -- 2.25.0 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev