From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C1AC34047 for ; Wed, 19 Feb 2020 09:11:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F41E24673 for ; Wed, 19 Feb 2020 09:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582103513; bh=QCvgFW+jje9yRaAt1NfJVzEVNG0lPbPPQv2SFoSGdiQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=iFX5p5Sur+ECxH9PO5zgaPPHWG3CW4CMFS21f4AzcvYvVNUps45CUfeONuHzs+/9e gAnFGx5QKHw6Ucz35UIXyFKWJ0TGbO8dXBgTQ0+dhEfNfVQkpU2v72s5rjRYr1SGd3 Jen8jq3q34XG38UB4Avax/OyR9klJuBlcfuDu2d8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbgBSJLv (ORCPT ); Wed, 19 Feb 2020 04:11:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:49488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726260AbgBSJLr (ORCPT ); Wed, 19 Feb 2020 04:11:47 -0500 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5568E2465D; Wed, 19 Feb 2020 09:11:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582103506; bh=QCvgFW+jje9yRaAt1NfJVzEVNG0lPbPPQv2SFoSGdiQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xbeSCwsbekmtynqP4aaaVxyYrIPZSG/r77Cu0pb57sc/W83msL+MuTXIdMD65wILM Lxjn733f1xxww5TnjaWMcn0AhixWbvJAezZ8p9tYu9uMrzKp2xhmJ4HHJblvgEK6d4 9/27hQJWnAZa+NPqoKTsBxaDjfrCu3pgmQk4Uye4= Date: Wed, 19 Feb 2020 17:11:39 +0800 From: Shawn Guo To: Christian Gmeiner Cc: Krzysztof Kozlowski , LKML , Russell King , Olof Johansson , Alexandre Torgue , Arnd Bergmann , Geert Uytterhoeven , Patrice Chotard , Joel Stanley , Tony Lindgren , Lubomir Rintel , Enric Balletbo i Serra , linux-arm-kernel@lists.infradead.org, Sascha Hauer , Fabio Estevam , Philipp Zabel Subject: Re: [PATCH] ARM: multi_v7_defconfig: enable drm imx support Message-ID: <20200219091138.GA12803@dragon> References: <20200124084359.16817-1-christian.gmeiner@gmail.com> <20200217041936.GH5395@dragon> <20200218091409.GA6075@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 19, 2020 at 09:48:23AM +0100, Christian Gmeiner wrote: > Am Di., 18. Feb. 2020 um 10:14 Uhr schrieb Shawn Guo : > > > > On Mon, Feb 17, 2020 at 01:09:32PM +0100, Christian Gmeiner wrote: > > > Am Mo., 17. Feb. 2020 um 05:19 Uhr schrieb Shawn Guo : > > > > > > > > On Mon, Feb 10, 2020 at 02:30:12PM +0100, Christian Gmeiner wrote: > > > > > Am Mo., 10. Feb. 2020 um 11:58 Uhr schrieb Krzysztof Kozlowski > > > > > : > > > > > > > > > > > > On Mon, 10 Feb 2020 at 11:54, Christian Gmeiner > > > > > > wrote: > > > > > > > > > > > > > > Am Fr., 24. Jan. 2020 um 09:44 Uhr schrieb Christian Gmeiner > > > > > > > : > > > > > > > > > > > > > > > > Makes it possible to multi v7 defconfig for stm32 and imx based devices with > > > > > > > > What do you mean by stm32 based devices here? > > > > > > > > > > CONFIG_ARCH_STM32 - I have a STM32MP157C-DK2 in my board farm and > > > would love to use > > > multi_v7 for imx6 and stm32. > > > > The patch is all about enabling drm-imx driver support. The commit log > > gives the impression that drm-imx driver also works on stm32 devices. > > Is that the case? > > > > No - the common thing both share is etnaviv. I did not know that before, and thanks for the information. But looking at the code change, there is nothing about etnaviv driver, and it's all about drm-imx driver. So I'm still questioning why stm32 needs to be mentioned in the commit log at all. > The patch subject "ARM: > multi_v7_defconfig: enable drm imx support" is fine Agreed. It's perfect. > I think but in the commit message I missed the verb so this should be > a better one: > > --->8--- > ARM: multi_v7_defconfig: enable drm imx support > > Makes it possible to use multi v7 defconfig for stm32 and imx based devices with > full drm support. > --->8--- I don't think 'stm32' should be there, as the code change in this commit has nothing to do with stm32, if I understand it correctly. > How shall I proceed to get this change in? I can edit the commit log when applying. But we need to agree on what it should be first. Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4B02C34047 for ; Wed, 19 Feb 2020 09:11:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABDD42465D for ; Wed, 19 Feb 2020 09:11:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KLWZT7vp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="xbeSCwsb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABDD42465D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MvyMSPw3aVgy7nTyVkOmOBXT22GnlCdso+lrG3FBx8Q=; b=KLWZT7vpCJdYiV WSPE3Zho3z7SMeh6CcjV/h/26cq5v0iHaVJ94xaXfZvRC8ICrNDYoHWBUlremL5jjEa//n9ipDiNt bef7P3Fi0okG0EA6XmYT95vitrKAfi26g1MEk1QVybb5NutMbfFlAG5uIIDXZS7ALKWts6U4dgU5W G76oiD57DlajonEkz64Y8jkd4/KqcG0+9l2AP9+BZPi/WyZs4pGyWNj7bWQ4XalPcdASoLZD40uMR nR3D/nmrrnblq/yXqnVCgjFrTbL3xKAiH/UkOdHeTExQyaXEPjcj9MH7iD2vKeWcyypbsayYhze+a FAQMLOzpsUL7VZpe4S+w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4LOY-0005FX-Uy; Wed, 19 Feb 2020 09:11:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4LOV-0005Eu-EL for linux-arm-kernel@lists.infradead.org; Wed, 19 Feb 2020 09:11:48 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5568E2465D; Wed, 19 Feb 2020 09:11:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582103506; bh=QCvgFW+jje9yRaAt1NfJVzEVNG0lPbPPQv2SFoSGdiQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xbeSCwsbekmtynqP4aaaVxyYrIPZSG/r77Cu0pb57sc/W83msL+MuTXIdMD65wILM Lxjn733f1xxww5TnjaWMcn0AhixWbvJAezZ8p9tYu9uMrzKp2xhmJ4HHJblvgEK6d4 9/27hQJWnAZa+NPqoKTsBxaDjfrCu3pgmQk4Uye4= Date: Wed, 19 Feb 2020 17:11:39 +0800 From: Shawn Guo To: Christian Gmeiner Subject: Re: [PATCH] ARM: multi_v7_defconfig: enable drm imx support Message-ID: <20200219091138.GA12803@dragon> References: <20200124084359.16817-1-christian.gmeiner@gmail.com> <20200217041936.GH5395@dragon> <20200218091409.GA6075@dragon> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200219_011147_521502_B282CA37 X-CRM114-Status: GOOD ( 23.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Enric Balletbo i Serra , Alexandre Torgue , Arnd Bergmann , Tony Lindgren , Sascha Hauer , LKML , Krzysztof Kozlowski , Russell King , Lubomir Rintel , Patrice Chotard , Joel Stanley , Philipp Zabel , Olof Johansson , Geert Uytterhoeven , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 19, 2020 at 09:48:23AM +0100, Christian Gmeiner wrote: > Am Di., 18. Feb. 2020 um 10:14 Uhr schrieb Shawn Guo : > > > > On Mon, Feb 17, 2020 at 01:09:32PM +0100, Christian Gmeiner wrote: > > > Am Mo., 17. Feb. 2020 um 05:19 Uhr schrieb Shawn Guo : > > > > > > > > On Mon, Feb 10, 2020 at 02:30:12PM +0100, Christian Gmeiner wrote: > > > > > Am Mo., 10. Feb. 2020 um 11:58 Uhr schrieb Krzysztof Kozlowski > > > > > : > > > > > > > > > > > > On Mon, 10 Feb 2020 at 11:54, Christian Gmeiner > > > > > > wrote: > > > > > > > > > > > > > > Am Fr., 24. Jan. 2020 um 09:44 Uhr schrieb Christian Gmeiner > > > > > > > : > > > > > > > > > > > > > > > > Makes it possible to multi v7 defconfig for stm32 and imx based devices with > > > > > > > > What do you mean by stm32 based devices here? > > > > > > > > > > CONFIG_ARCH_STM32 - I have a STM32MP157C-DK2 in my board farm and > > > would love to use > > > multi_v7 for imx6 and stm32. > > > > The patch is all about enabling drm-imx driver support. The commit log > > gives the impression that drm-imx driver also works on stm32 devices. > > Is that the case? > > > > No - the common thing both share is etnaviv. I did not know that before, and thanks for the information. But looking at the code change, there is nothing about etnaviv driver, and it's all about drm-imx driver. So I'm still questioning why stm32 needs to be mentioned in the commit log at all. > The patch subject "ARM: > multi_v7_defconfig: enable drm imx support" is fine Agreed. It's perfect. > I think but in the commit message I missed the verb so this should be > a better one: > > --->8--- > ARM: multi_v7_defconfig: enable drm imx support > > Makes it possible to use multi v7 defconfig for stm32 and imx based devices with > full drm support. > --->8--- I don't think 'stm32' should be there, as the code change in this commit has nothing to do with stm32, if I understand it correctly. > How shall I proceed to get this change in? I can edit the commit log when applying. But we need to agree on what it should be first. Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel