From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C08CC34050 for ; Wed, 19 Feb 2020 14:17:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D8EE20801 for ; Wed, 19 Feb 2020 14:17:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727809AbgBSORv (ORCPT ); Wed, 19 Feb 2020 09:17:51 -0500 Received: from mx2.suse.de ([195.135.220.15]:35534 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726736AbgBSORv (ORCPT ); Wed, 19 Feb 2020 09:17:51 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0CF03B9E7; Wed, 19 Feb 2020 14:17:47 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 5F881DA70E; Wed, 19 Feb 2020 15:17:30 +0100 (CET) Date: Wed, 19 Feb 2020 15:17:30 +0100 From: David Sterba To: Nikolay Borisov Cc: yu kuai , clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, zhengbin13@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH 2/3] btrfs: remove set but not used variable 'parent' Message-ID: <20200219141730.GX2902@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov , yu kuai , clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, zhengbin13@huawei.com, yi.zhang@huawei.com References: <20200219112203.17075-1-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Feb 19, 2020 at 01:34:53PM +0200, Nikolay Borisov wrote: > > > On 19.02.20 г. 13:22 ч., yu kuai wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > fs/btrfs/tree-log.c: In function ‘walk_down_log_tree’: > > fs/btrfs/tree-log.c:2702:24: warning: variable ‘parent’ > > set but not used [-Wunused-but-set-variable] > > fs/btrfs/tree-log.c: In function ‘walk_up_log_tree’: > > fs/btrfs/tree-log.c:2803:26: warning: variable ‘parent’ > > set but not used [-Wunused-but-set-variable] > > > > They are never used, and so can be removed. > > > > Signed-off-by: yu kuai > > Ah yes, those two are a result of my : > > e084c5ab48f9 ("btrfs: Call btrfs_pin_reserved_extent only during active > transaction") (in misc-next branch) > > David perhaps you can squash the two var removals into the original patch? Yes I'll do that.