From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2 2/2] nvme: expose hostid via sysfs for fabrics controllers
Date: Wed, 19 Feb 2020 16:10:27 +0100 [thread overview]
Message-ID: <20200219151027.GH17748@lst.de> (raw)
In-Reply-To: <20200208011354.20889-2-sagi@grimberg.me>
On Fri, Feb 07, 2020 at 05:13:54PM -0800, Sagi Grimberg wrote:
> @@ -3293,6 +3304,8 @@ static umode_t nvme_dev_attrs_are_visible(struct kobject *kobj,
> return 0;
> if (a == &dev_attr_hostnqn.attr && (!ctrl->opts))
> return 0;
> + if (a == &dev_attr_hostid.attr && (!ctrl->opts))
> + return 0;
No need for the braces either.
Otherwise:
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-02-19 15:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 1:13 [PATCH v2 1/2] nvme: expose hostnqn via sysfs for fabrics controllers Sagi Grimberg
2020-02-08 1:13 ` [PATCH v2 2/2] nvme: expose hostid " Sagi Grimberg
2020-02-09 23:56 ` Chaitanya Kulkarni
2020-02-19 15:10 ` Christoph Hellwig [this message]
2020-02-09 23:55 ` [PATCH v2 1/2] nvme: expose hostnqn " Chaitanya Kulkarni
2020-02-19 15:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219151027.GH17748@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.