From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11B90C34047 for ; Wed, 19 Feb 2020 16:50:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA84224656 for ; Wed, 19 Feb 2020 16:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582131022; bh=kOXZCZKenNSD9wrjdQ1BdQRHvBQn6jUQq/YNOfpaiQI=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:List-ID: From; b=e7un82jNQk/arCJinoHSeHWLBDXQqmduPasLcD06s4zUr13tyXERQVMOVAOR3qwCQ tn/sHCO+0YTCyD1RSqlVlmFWrW2YKjo9X3vbOBY4ZYE6NS6rM9BCGSvA2tF4PFleq6 3onmiHyeeKu4osEfBt1bBW7Z/9RC9KJkK0fypNUI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726767AbgBSQuV (ORCPT ); Wed, 19 Feb 2020 11:50:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:35442 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbgBSQuV (ORCPT ); Wed, 19 Feb 2020 11:50:21 -0500 Received: from paulmck-ThinkPad-P72.home (50-39-105-78.bvtn.or.frontiernet.net [50.39.105.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A3AC720578; Wed, 19 Feb 2020 16:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582131020; bh=kOXZCZKenNSD9wrjdQ1BdQRHvBQn6jUQq/YNOfpaiQI=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=tabKOyUUDIEk+mcMZmV4P2vFUQPjgX8ZHvwTq9MnBMeuUY1U7/xv6u73vcU0T1LEI HzsmSmTpvbEEJ8KFZNgFPHkW9bs7OXAZvdMMs1IGnU2H4LHoHr4/cvalrZh3rnNKTW 2+GB4sMHmoKxV6TKLm/RMbDbeP2Up/AA8ehMCfgU= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 645D335209B0; Wed, 19 Feb 2020 08:50:20 -0800 (PST) Date: Wed, 19 Feb 2020 08:50:20 -0800 From: "Paul E. McKenney" To: Peter Zijlstra Cc: Steven Rostedt , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, joel@joelfernandes.org, gregkh@linuxfoundation.org, gustavo@embeddedor.com, tglx@linutronix.de, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, luto@kernel.org, tony.luck@intel.com, frederic@kernel.org, dan.carpenter@oracle.com, mhiramat@kernel.org, Marco Elver , Mark Rutland Subject: Re: [PATCH v3 16/22] locking/atomics, kcsan: Add KCSAN instrumentation Message-ID: <20200219165020.GF2935@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200219144724.800607165@infradead.org> <20200219150745.299217979@infradead.org> <20200219104626.633f0650@gandalf.local.home> <20200219160318.GG18400@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200219160318.GG18400@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 19, 2020 at 05:03:18PM +0100, Peter Zijlstra wrote: > On Wed, Feb 19, 2020 at 10:46:26AM -0500, Steven Rostedt wrote: > > On Wed, 19 Feb 2020 15:47:40 +0100 > > Peter Zijlstra wrote: > > > > > From: Marco Elver > > > > > > This adds KCSAN instrumentation to atomic-instrumented.h. > > > > > > Signed-off-by: Marco Elver > > > Signed-off-by: Paul E. McKenney > > > [peterz: removed the actual kcsan hooks] > > > Signed-off-by: Peter Zijlstra (Intel) > > > Reviewed-by: Mark Rutland > > > --- > > > include/asm-generic/atomic-instrumented.h | 390 +++++++++++++++--------------- > > > scripts/atomic/gen-atomic-instrumented.sh | 14 - > > > 2 files changed, 212 insertions(+), 192 deletions(-) > > > > > > > > > Does this and the rest of the series depend on the previous patches in > > the series? Or can this be a series on to itself (patches 16-22)? > > It can probably stand on its own, but it very much is related in so far > that it's fallout from staring at all this nonsense. > > Without these the do_int3() can actually have accidental tracing before > reaching it's nmi_enter(). The original is already in -tip, so some merge magic will be required. Thanx, Paul