From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] xfs: fix iclog release error check race with shutdown
Date: Wed, 19 Feb 2020 10:46:25 -0800 [thread overview]
Message-ID: <20200219184625.GB10588@infradead.org> (raw)
In-Reply-To: <20200219030040.GZ10776@dread.disaster.area>
On Wed, Feb 19, 2020 at 02:00:40PM +1100, Dave Chinner wrote:
> > Now the real question, which is a bit out of scope for this patch is
> > why we even have XLOG_STATE_IOERROR?
>
> I _think_ it was originally intended to prevent log shutdown
> recursion when shutdowns trigger log IO errors and try to shut down
> again.
>
> > Wouldn't it make more sense
> > to just user the shutdown flag in the mount structure and avoid the
> > extra state complexity and thus clean up this whole mess?
>
> I'd suggest that XLOG_FORCED_SHUTDOWN() is more appropriate in code
> that has no reason to know anything about the xfs_mount state e.g.
> the code in xlog_state_release_iclog() has a log and iclog context
> and introducing a xfs-mount context to check for shutdown is a
> fairly significant layering violation deep inside the internal log
> implementation...
Yes, XLOG_FORCED_SHUTDOWN makes more sense. I did in fact hack up
a quick patch for that last night, but I'm going to hold it back until
the bug fix is merged.
next prev parent reply other threads:[~2020-02-19 18:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 17:54 [PATCH v2] xfs: fix iclog release error check race with shutdown Brian Foster
2020-02-18 21:00 ` Christoph Hellwig
2020-02-18 21:52 ` Dave Chinner
2020-02-18 22:36 ` Christoph Hellwig
2020-02-19 3:00 ` Dave Chinner
2020-02-19 18:46 ` Christoph Hellwig [this message]
2020-02-19 13:12 ` Brian Foster
2020-02-19 21:51 ` Darrick J. Wong
2020-02-20 12:41 ` Brian Foster
2020-02-20 15:43 ` Christoph Hellwig
2020-02-20 16:02 ` Brian Foster
2020-02-20 3:32 ` Dave Chinner
2020-02-19 21:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219184625.GB10588@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.