[PATCH 0/2] Implement SMU message register protection

From: Matt Coffin <mcoffin13@gmail.com>
To: alexdeucher@gmail.com
Cc: Matt Coffin <mcoffin13@gmail.com>,
	Nirmoy Das <nirmoy.das@amd.com>,
	amd-gfx@lists.freedesktop.org
Subject: [PATCH 0/2] Implement SMU message register protection
Date: Wed, 19 Feb 2020 12:19:39 -0700	[thread overview]
Message-ID: <20200219191941.67724-1-mcoffin13@gmail.com> (raw)
In-Reply-To: <5d301d58-49c7-6c3c-0652-6e051514d1ff@amd.com>

Hey Alex,

I took a crack at the implementation I was talking about here, where we
can protect the read argument register reads as well. I only
transitioned the actual implementation for hardware that I have funds
for/access to, and left an '_unsafe' path for the other implementations
since I cannot test.

What do you think of this implementation?

Matt Coffin (2):
  drm/amdgpu/powerplay: Refactor SMU message handling for safety
  drm/amdgpu/smu: Add message sending lock

 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c    |  47 +++----
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c  |  18 +--
 .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h    |   3 +-
 drivers/gpu/drm/amd/powerplay/inc/smu_v11_0.h |   7 +-
 drivers/gpu/drm/amd/powerplay/inc/smu_v12_0.h |   3 +-
 drivers/gpu/drm/amd/powerplay/navi10_ppt.c    |  76 ++++++-----
 drivers/gpu/drm/amd/powerplay/renoir_ppt.c    |  22 ++--
 drivers/gpu/drm/amd/powerplay/smu_internal.h  |  15 ++-
 drivers/gpu/drm/amd/powerplay/smu_v11_0.c     | 118 +++++++++---------
 drivers/gpu/drm/amd/powerplay/smu_v12_0.c     |  65 ++++++----
 drivers/gpu/drm/amd/powerplay/vega20_ppt.c    |  42 +++----
 11 files changed, 216 insertions(+), 200 deletions(-)

-- 
2.25.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx