From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Cc: guaneryu@gmail.com, fstests@vger.kernel.org
Subject: Re: [PATCH v2 2/2] xfs/044: Remove useless _filter_logprint
Date: Thu, 20 Feb 2020 15:30:30 -0800 [thread overview]
Message-ID: <20200220233030.GH9511@magnolia> (raw)
In-Reply-To: <1582185528-8173-2-git-send-email-xuyang2018.jy@cn.fujitsu.com>
On Thu, Feb 20, 2020 at 03:58:48PM +0800, Yang Xu wrote:
> xfs/044 has customized _filter_logprint function, but it was never
> used. So remove it.
>
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> tests/xfs/044 | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/tests/xfs/044 b/tests/xfs/044
> index 4a476985..0c6a421d 100755
> --- a/tests/xfs/044
> +++ b/tests/xfs/044
> @@ -25,18 +25,6 @@ _supported_os Linux
>
> _require_logdev
>
> -_filter_logprint()
> -{
> - perl -ne '
> - s/data device: ([\w|\/.-]+)/data device: DDEV/;
> - s/log device: ([\w|\/.-]+) daddr: (\d+) length: (\d+)/log device: LDEV daddr: XXX length: XXX/;
> - s/log file: "([\w|\/.-]+)" daddr: (\d+) length: (\d+)/log device: LDEV daddr: XXX length: XXX/;
> - s/uuid: ([abcdef\d-]+)\s+format: (.+)/uuid: UUID format: FORMAT/;
> - s/skipped (\w+) zeroed blocks/skipped XXX zeroed blocks/;
> - print;
> - '
> -}
> -
> _check_mount()
> {
> echo " *** mount (expect success)"
> --
> 2.18.0
>
>
>
next prev parent reply other threads:[~2020-02-20 23:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 7:02 [PATCH] xfs/029: filter out "extended-header: cycle: 1" from output Yang Xu
2020-02-19 0:32 ` Darrick J. Wong
2020-02-19 1:27 ` Yang Xu
2020-02-19 5:07 ` Darrick J. Wong
2020-02-19 9:49 ` Yang Xu
2020-02-19 22:09 ` Darrick J. Wong
2020-02-20 2:11 ` Yang Xu
2020-02-20 7:58 ` [PATCH v2 1/2] " Yang Xu
2020-02-20 7:58 ` [PATCH v2 2/2] xfs/044: Remove useless _filter_logprint Yang Xu
2020-02-20 23:30 ` Darrick J. Wong [this message]
2020-02-20 23:30 ` [PATCH v2 1/2] xfs/029: filter out "extended-header: cycle: 1" from output Darrick J. Wong
2020-02-21 1:45 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220233030.GH9511@magnolia \
--to=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=xuyang2018.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.