From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C6EC35640 for ; Fri, 21 Feb 2020 08:32:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D836620578 for ; Fri, 21 Feb 2020 08:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582273963; bh=nX975cmkEA4sifV9b0KMKOPMIxYt2YzC5TeY+ulhTIM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Z/A7PBjV9432x5y5gGrTt9R5hJr9oC7E51xPDBlVl/W+fMUR7rLiD2CULyYEfo3Mv cXxIk2RoJS+ypiM/Y5ouNoStLfQ1t3VbPyiiv2InVj8Vm85Q+w5yR6Lu4w348Rq0fv 3u3QNd6t8GmCxX0sXYSsvLj1c0rhDhgjc8wANFRc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387653AbgBUIcm (ORCPT ); Fri, 21 Feb 2020 03:32:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:47602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732763AbgBUIL5 (ORCPT ); Fri, 21 Feb 2020 03:11:57 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0E34E20722; Fri, 21 Feb 2020 08:11:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582272717; bh=nX975cmkEA4sifV9b0KMKOPMIxYt2YzC5TeY+ulhTIM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aZbEqOs3NiGdBrYPgQZtqXdjzWiFfwE+WSKcpjLajMj2E+9Xo1RUWzhDbOFyLXO4r ct0ATqZvpkiWXlwxN8PvueXmz10FY98WMrRUBCsVQzEqZx/jM41CAYqj9lqXi62juS Y9MLyXUpClUWvFMRmMo2Px+geE5BTUIEtSO4BtKA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Borkmann , Li RongQing , Sasha Levin Subject: [PATCH 5.4 221/344] bpf: Return -EBADRQC for invalid map type in __bpf_tx_xdp_map Date: Fri, 21 Feb 2020 08:40:20 +0100 Message-Id: <20200221072409.277055765@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072349.335551332@linuxfoundation.org> References: <20200221072349.335551332@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Li RongQing [ Upstream commit 0a29275b6300f39f78a87f2038bbfe5bdbaeca47 ] A negative value should be returned if map->map_type is invalid although that is impossible now, but if we run into such situation in future, then xdpbuff could be leaked. Daniel Borkmann suggested: -EBADRQC should be returned to stay consistent with generic XDP for the tracepoint output and not to be confused with -EOPNOTSUPP from other locations like dev_map_enqueue() when ndo_xdp_xmit is missing and such. Suggested-by: Daniel Borkmann Signed-off-by: Li RongQing Signed-off-by: Daniel Borkmann Link: https://lore.kernel.org/bpf/1578618277-18085-1-git-send-email-lirongqing@baidu.com Signed-off-by: Sasha Levin --- net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/filter.c b/net/core/filter.c index 1a78d64096bbd..d59dbc88fef5d 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -3543,7 +3543,7 @@ static int __bpf_tx_xdp_map(struct net_device *dev_rx, void *fwd, return err; } default: - break; + return -EBADRQC; } return 0; } -- 2.20.1