From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55589C35642 for ; Fri, 21 Feb 2020 08:40:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21C3A2073A for ; Fri, 21 Feb 2020 08:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582274423; bh=tgCT0oEeWzXKOoEEL8Brn5QErQ9nBloG8frtfrpx0Sc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=X6vwU7aXzO4WklmlTrBJ7hAi6wEXOpXCM0VgTjdmlizyjpb9YxQhJAARjbZjfcM3N 08ziaaZc+txJ0QoIuMZsDLi13PPX/KabOlSdoOnRRmzzJxyPrHQJ3wFc/BBmWkK8Wm r+KHHOfQo4+skno997OC00Fapopd24B2OyKWD3vw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730875AbgBUH7N (ORCPT ); Fri, 21 Feb 2020 02:59:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:59186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730557AbgBUH7K (ORCPT ); Fri, 21 Feb 2020 02:59:10 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FA7520578; Fri, 21 Feb 2020 07:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582271949; bh=tgCT0oEeWzXKOoEEL8Brn5QErQ9nBloG8frtfrpx0Sc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZlTZoM3pZ/M3IAsnPs8GwNhkGOHBEppTvQp0pe1umsu8dNSuAdYyMy7VRgDlkvRlM 2iwPxbhw3oGj9I8O+ON0dYF4aw9V7CZAZ9vG9V+1cV1u+P/Jp+U+6lG60K58pLG+nF zJxpAnk2bEVaHWJYn7At+gxTvac1Sv/hLnsPr2jo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Colin Ian King , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.5 322/399] driver core: platform: fix u32 greater or equal to zero comparison Date: Fri, 21 Feb 2020 08:40:47 +0100 Message-Id: <20200221072432.647893902@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072402.315346745@linuxfoundation.org> References: <20200221072402.315346745@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King [ Upstream commit 0707cfa5c3ef58effb143db9db6d6e20503f9dec ] Currently the check that a u32 variable i is >= 0 is always true because the unsigned variable will never be negative, causing the loop to run forever. Fix this by changing the pre-decrement check to a zero check on i followed by a decrement of i. Addresses-Coverity: ("Unsigned compared against 0") Fixes: 39cc539f90d0 ("driver core: platform: Prevent resouce overflow from causing infinite loops") Signed-off-by: Colin Ian King Reviewed-by: Rafael J. Wysocki Link: https://lore.kernel.org/r/20200116175758.88396-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/base/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 864b53b3d5980..7fa654f1288b8 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -571,7 +571,7 @@ int platform_device_add(struct platform_device *pdev) pdev->id = PLATFORM_DEVID_AUTO; } - while (--i >= 0) { + while (i--) { struct resource *r = &pdev->resource[i]; if (r->parent) release_resource(r); -- 2.20.1