From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E17CC11D00 for ; Fri, 21 Feb 2020 00:21:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB1A224654 for ; Fri, 21 Feb 2020 00:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582244471; bh=aFmWnc6nSROALS7C6rt+JEj+3cf4DjrPCVOqPO53blU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=mEFBX6B7PUI66IMtwWqulYEn8YsLgR3p5Pjz9TkO4eb/H+4ci1KZDfZmAEekOeX1R UfXKRmF9SSR9/3Ky8ZBoWWvSgI0Yd9Bm9jjwS4BM+RjusBc7blG9OcS2Mwsh4MAFCc WF3n0tkwanYXYdqD2VGswRQ279zF23vo+ANgp9n4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729504AbgBUAVJ (ORCPT ); Thu, 20 Feb 2020 19:21:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:40994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729392AbgBUAVG (ORCPT ); Thu, 20 Feb 2020 19:21:06 -0500 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C90E2208E4; Fri, 21 Feb 2020 00:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582244465; bh=aFmWnc6nSROALS7C6rt+JEj+3cf4DjrPCVOqPO53blU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=s6L8Trq6c8I5s8U8G/4Uut8ZJLFIcpHjZBs7sSoNWxZBW9PWWn2fgtIVny/jKoXJZ +7WdxB8LKOb6zxUm3aj/mQpg7go7U4GPbY30Yvh28qYYsB+66eN67VTmC2e5LL6zrw YMU/Nl9pDVXpu4SoFBDyZ219ezAFuqnwc8D2EW4E= Date: Fri, 21 Feb 2020 09:21:01 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: Geert Uytterhoeven , Borislav Petkov , LKML , Ingo Molnar , Andrew Morton , Peter Zijlstra Subject: Re: [PATCH v2 6/8] bootconfig: Overwrite value on same key by default Message-Id: <20200221092101.f4a25d56de794db29ed5ed6f@kernel.org> In-Reply-To: <20200220121641.6c0d611a@gandalf.local.home> References: <158220110257.26565.4812934676257459744.stgit@devnote2> <158220116248.26565.12553080867501195108.stgit@devnote2> <20200220121641.6c0d611a@gandalf.local.home> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Feb 2020 12:16:41 -0500 Steven Rostedt wrote: > On Thu, 20 Feb 2020 21:19:22 +0900 > Masami Hiramatsu wrote: > > > Currently, bootconfig does not overwrite existing value > > on same key, but add new value to the tail of an array. > > But this looks a bit confusing because similar syntax > > configuration always overwrite the value by default. > > Should we even allow this case? Or at the very least, some output > should be made that a value is being overwritten. Both are OK, but I like just making it error. At this moment, the bootconfig tool writes user-given bootconfig file to initrd (not reformat it). This means if user ignores the warning from bootconfig tool, they will see same warning on dmesg again. Thank you, > > -- Steve > > > > > > This changes the behavior to overwrite value on same key. > > > > For example, if there are 2 entries > > > > key = value > > ... > > key = value2 > > > > Then, the key is updated as below. > > > > key = value2 > > > > Signed-off-by: Masami Hiramatsu -- Masami Hiramatsu