From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EF8AC3565D for ; Fri, 21 Feb 2020 14:11:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BFB1222C4 for ; Fri, 21 Feb 2020 14:11:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ey+A4+Kw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728687AbgBUOL5 (ORCPT ); Fri, 21 Feb 2020 09:11:57 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:59298 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728544AbgBUOL4 (ORCPT ); Fri, 21 Feb 2020 09:11:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=VwReIK2Wv5hggJYXLfnABzyYc5b93fHIm+IPidvFfvE=; b=ey+A4+KwEhWaKX6mtsdQW5BXL4 hNdq+ZKB3yjAEBqXSH7Bt5lz7QIylVHj4hTly/XsqmzPuhZ6L0v8sAQYRl4x4Q/K5tJaMwY+yxIhd ip6QOHgK7zhFyxqeqNLXRDmsrtE/TpuqbPcpDFytrKf6eH3Zlf6MB4P2Ey/IzcQPoUdrCf7QUASzL sOP27sC2EL6oQZkRdzjcwzwABCzHTWGaZ02+kjwr03Y6mETdfs9RvBp1IrG6XSNYddnrnHtg+6NJo IckqdHONDs8NG8Di9NxZgIXHCI04K+gSa29zkoKS1CvL7mq38SlmuHwgkXWnWS/SAde4PFZAh8uPh 7XBAe+dg==; Received: from [38.126.112.138] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1j5924-0000Gr-NT; Fri, 21 Feb 2020 14:11:56 +0000 From: Christoph Hellwig To: linux-xfs@vger.kernel.org Cc: Allison Collins , Dave Chinner , Chandan Rajendra , "Darrick J . Wong" Subject: [PATCH 08/31] xfs: remove the MAXNAMELEN check from xfs_attr_args_init Date: Fri, 21 Feb 2020 06:11:31 -0800 Message-Id: <20200221141154.476496-9-hch@lst.de> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200221141154.476496-1-hch@lst.de> References: <20200221141154.476496-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org All the callers already check the length when allocating the in-kernel xattrs buffers. Signed-off-by: Christoph Hellwig Reviewed-by: Dave Chinner Reviewed-by: Chandan Rajendra Reviewed-by: Darrick J. Wong --- fs/xfs/libxfs/xfs_attr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c index a968158b9bb1..f887d62e0956 100644 --- a/fs/xfs/libxfs/xfs_attr.c +++ b/fs/xfs/libxfs/xfs_attr.c @@ -72,9 +72,6 @@ xfs_attr_args_init( args->flags = flags; args->name = name; args->namelen = namelen; - if (args->namelen >= MAXNAMELEN) - return -EFAULT; /* match IRIX behaviour */ - args->hashval = xfs_da_hashname(args->name, args->namelen); return 0; } -- 2.24.1