From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 218B5C35646 for ; Fri, 21 Feb 2020 14:15:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9F682073A for ; Fri, 21 Feb 2020 14:15:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="OTVBrsDz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9F682073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AAD296F455; Fri, 21 Feb 2020 14:15:37 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id A44ED6F44F for ; Fri, 21 Feb 2020 14:15:35 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 74537563; Fri, 21 Feb 2020 15:15:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582294533; bh=B78K6BHwVWaxeYVxVCi4GiSEKx7XnitKFq618+Wp7HE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OTVBrsDzorLmzxud8Tu37TWJ96po+W6wFyosDnxOSmH40VFzzO/rwXFmlpffLtz1K zZD+xBi/hamMgWcdbypcSSAqH0dm4O1wCHFNIOYIhFcQyPXLwI0gVxUAy/5JUhlQbj 5DKYjJgbQHUUbrgoEDxUqD0l0thk1Snr1yqBaBGY= Date: Fri, 21 Feb 2020 16:15:13 +0200 From: Laurent Pinchart To: Daniel Vetter Subject: Re: [PATCH v6 02/51] drm/connector: Add helper to get a connector type name Message-ID: <20200221141513.GE4955@pendragon.ideasonboard.com> References: <20200216210308.17312-1-laurent.pinchart@ideasonboard.com> <20200216210308.17312-3-laurent.pinchart@ideasonboard.com> <20200217094303.GJ2363188@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200217094303.GJ2363188@phenom.ffwll.local> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Sam Ravnborg , Sebastian Reichel , dri-devel@lists.freedesktop.org, Boris Brezillon Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Daniel, On Mon, Feb 17, 2020 at 10:43:03AM +0100, Daniel Vetter wrote: > On Sun, Feb 16, 2020 at 11:02:19PM +0200, Laurent Pinchart wrote: > > drm_connector.c contains a map of connector types (DRM_MODE_CONNECTOR_*) > > to name strings, but doesn't expose it. This leads to drivers having to > > store a similar map. > > Maybe also a todo if there's many of these? I had a quick look, and this is actually mostly need for a patch further in this series :-) I don't think there's a need for a todo item. > > Add a new drm_get_connector_type_name() helper function that return a > > name string for a connector type. > > > > Signed-off-by: Laurent Pinchart > > Reviewed-by: Boris Brezillon > > Reviewed-by: Sam Ravnborg > > --- > > drivers/gpu/drm/drm_connector.c | 15 +++++++++++++++ > > include/drm/drm_connector.h | 1 + > > 2 files changed, 16 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c > > index f632ca05960e..644f0ad10671 100644 > > --- a/drivers/gpu/drm/drm_connector.c > > +++ b/drivers/gpu/drm/drm_connector.c > > @@ -111,6 +111,21 @@ void drm_connector_ida_destroy(void) > > ida_destroy(&drm_connector_enum_list[i].ida); > > } > > > > +/** > > + * drm_get_connector_type_name - return a string for connector type > > + * @type: The connector type (DRM_MODE_CONNECTOR_*) > > + * > > + * Returns: the name of the connector type, or NULL if the type is not valid. > > + */ > > +const char *drm_get_connector_type_name(unsigned int type) > > +{ > > + if (type < ARRAY_SIZE(drm_connector_enum_list)) > > + return drm_connector_enum_list[type].name; > > + > > + return NULL; > > +} > > +EXPORT_SYMBOL(drm_get_connector_type_name); > > + > > /** > > * drm_connector_get_cmdline_mode - reads the user's cmdline mode > > * @connector: connector to quwery > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > > index b3815371c271..c3bd5262db9c 100644 > > --- a/include/drm/drm_connector.h > > +++ b/include/drm/drm_connector.h > > @@ -1518,6 +1518,7 @@ drm_connector_is_unregistered(struct drm_connector *connector) > > DRM_CONNECTOR_UNREGISTERED; > > } > > > > +const char *drm_get_connector_type_name(unsigned int connector_type); > > const char *drm_get_connector_status_name(enum drm_connector_status status); > > const char *drm_get_subpixel_order_name(enum subpixel_order order); > > const char *drm_get_dpms_name(int val); -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel