From: Will Deacon <will@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
akpm@linux-foundation.org,
"K . Prasad" <prasad@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Frederic Weisbecker <frederic@kernel.org>,
Quentin Perret <qperret@google.com>,
Alexei Starovoitov <ast@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH 2/3] samples/hw_breakpoint: Drop use of kallsyms_lookup_name()
Date: Fri, 21 Feb 2020 14:20:35 +0000 [thread overview]
Message-ID: <20200221142035.GA17979@willie-the-truck> (raw)
In-Reply-To: <20200221141354.GC6968@lst.de>
On Fri, Feb 21, 2020 at 03:13:54PM +0100, Christoph Hellwig wrote:
> On Fri, Feb 21, 2020 at 11:44:03AM +0000, Will Deacon wrote:
> > -static char ksym_name[KSYM_NAME_LEN] = "pid_max";
> > +static char ksym_name[KSYM_NAME_LEN] = "jiffies";
>
> Is jiffies actually an exported symbol on all configfs? I thought
> there was some weird aliasing going on with jiffies64.
There is some weird aliasing with jiffies_64, but kernel/time/jiffies.c
has an unconditional:
EXPORT_SYMBOL(jiffies);
so I think we're ok.
> Except for the symbol choice this looks fine, though:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Brill, cheers.
Will
next prev parent reply other threads:[~2020-02-21 14:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 11:44 [PATCH 0/3] Unexport kallsyms_lookup_name() and kallsyms_on_each_symbol() Will Deacon
2020-02-21 11:44 ` [PATCH 1/3] samples/hw_breakpoint: Drop HW_BREAKPOINT_R when reporting writes Will Deacon
2020-02-21 14:12 ` Christoph Hellwig
2020-02-21 11:44 ` [PATCH 2/3] samples/hw_breakpoint: Drop use of kallsyms_lookup_name() Will Deacon
2020-02-21 14:13 ` Christoph Hellwig
2020-02-21 14:20 ` Will Deacon [this message]
2020-02-21 11:44 ` [PATCH 3/3] kallsyms: Unexport kallsyms_lookup_name() and kallsyms_on_each_symbol() Will Deacon
2020-02-21 11:53 ` Greg Kroah-Hartman
2020-02-21 14:14 ` Christoph Hellwig
2020-02-21 15:11 ` Alexei Starovoitov
2020-02-21 14:27 ` [PATCH 0/3] " Masami Hiramatsu
2020-02-21 14:48 ` Will Deacon
2020-02-21 23:44 ` Masami Hiramatsu
2020-02-21 15:41 ` David Laight
2020-02-21 16:25 ` Quentin Perret
2020-02-25 10:05 ` Miroslav Benes
2020-02-25 12:11 ` Petr Mladek
2020-02-25 15:00 ` Joe Lawrence
2020-02-25 18:01 ` Miroslav Benes
2020-02-26 14:16 ` Joe Lawrence
2020-03-02 19:28 ` Mathieu Desnoyers
2020-03-02 19:36 ` Greg Kroah-Hartman
2020-03-02 19:39 ` Greg Kroah-Hartman
2020-03-02 20:17 ` Mathieu Desnoyers
2020-03-03 6:57 ` Greg Kroah-Hartman
2020-03-03 16:58 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221142035.GA17979@willie-the-truck \
--to=will@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=frederic@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=qperret@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.