All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
	mingo@redhat.com, alexander.shishkin@linux.intel.com,
	Linux-kernel@vger.kernel.org, ak@linux.intel.com,
	kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2 2/2] perf annotate: Support interactive annotation of code without symbols
Date: Fri, 21 Feb 2020 15:45:31 +0100	[thread overview]
Message-ID: <20200221144531.GA657629@krava> (raw)
In-Reply-To: <20200221024608.1847-3-yao.jin@linux.intel.com>

On Fri, Feb 21, 2020 at 10:46:08AM +0800, Jin Yao wrote:

SNIP

> 
> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> ---
>  tools/perf/ui/browsers/hists.c | 51 +++++++++++++++++++++++++++++-----
>  tools/perf/util/annotate.h     |  2 ++
>  2 files changed, 46 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index f36dee499320..5144528b2931 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -2465,13 +2465,47 @@ do_annotate(struct hist_browser *browser, struct popup_action *act)
>  	return 0;
>  }
>  
> +static struct symbol *new_annotate_sym(u64 addr, struct map *map,
> +				       struct annotation_options *opts)
> +{
> +	struct symbol *sym;
> +	struct annotated_source *src;
> +	char name[64];
> +
> +	snprintf(name, sizeof(name), "%-#.*lx", BITS_PER_LONG / 4, addr);
> +
> +	sym = symbol__new(addr,
> +			  opts->annotate_dummy_len ?
> +			  opts->annotate_dummy_len : ANNOTATION_DUMMY_LEN,

I can't see annotate_dummy_len being set anywhere..

jirka


  reply	other threads:[~2020-02-21 14:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-21  2:46 [PATCH v2 0/2] perf report: Support annotation of code without symbols Jin Yao
2020-02-21  2:46 ` [PATCH v2 1/2] perf util: Print al_addr when symbol is not found Jin Yao
2020-02-21  2:46 ` [PATCH v2 2/2] perf annotate: Support interactive annotation of code without symbols Jin Yao
2020-02-21 14:45   ` Jiri Olsa [this message]
2020-02-21 23:37     ` Jin, Yao
2020-02-23 19:50       ` Jiri Olsa
2020-02-24  0:28         ` Jin, Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200221144531.GA657629@krava \
    --to=jolsa@redhat.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=yao.jin@intel.com \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.