From: Al Viro <viro@zeniv.linux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [RFC] regset ->get() API
Date: Sat, 22 Feb 2020 00:41:57 +0000 [thread overview]
Message-ID: <20200222004157.GX23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200221.112244.1426580944977593272.davem@davemloft.net>
On Fri, Feb 21, 2020 at 11:22:44AM -0800, David Miller wrote:
> From: Al Viro <viro@zeniv.linux.org.uk>
> Date: Fri, 21 Feb 2020 18:59:03 +0000
>
> > Again, a couple of copy_regset_to_user(), but there's an additional
> > twist - GETREGSET of 32bit task on sparc64 will use access_process_vm()
> > when trying to fetch L0..L7/I0..I7 of other task, using copy_from_user()
> > only when the target is equal to current. For sparc32 this is not
> > true - it's always copy_from_user() there, so the values it reports
> > for those registers have nothing to do with the target process. That
> > part smells like a bug; by the time GETREGSET had been introduced
> > sparc32 was not getting much attention, GETREGS worked just fine
> > (not reporting L*/I* anyway) and for coredump it was accessing the
> > caller's memory. Not sure if anyone cares at that point...
>
> That's definitely a bug and sparc64 is doing it correctly.
OK... What does the comment in
case PTRACE_GETREGS64:
ret = copy_regset_to_user(child, view, REGSET_GENERAL,
1 * sizeof(u64),
15 * sizeof(u64),
&pregs->u_regs[0]);
if (!ret) {
/* XXX doesn't handle 'y' register correctly XXX */
ret = copy_regset_to_user(child, view, REGSET_GENERAL,
32 * sizeof(u64),
4 * sizeof(u64),
&pregs->tstate);
}
break;
refer to? The fact that you end up with 0 in pregs->y and Y in pregs->magic?
In that case it's probably too late to do anything about that...
Or is that something different?
next prev parent reply other threads:[~2020-02-22 0:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 18:33 [RFC] regset ->get() API Al Viro
2020-02-19 20:01 ` Linus Torvalds
2020-02-20 22:47 ` Al Viro
2020-02-20 22:56 ` Linus Torvalds
2020-02-20 23:29 ` Al Viro
2020-02-20 23:31 ` Linus Torvalds
2020-02-21 3:30 ` Al Viro
2020-02-21 18:59 ` Al Viro
2020-02-21 19:22 ` David Miller
2020-02-22 0:41 ` Al Viro [this message]
2020-04-13 4:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200222004157.GX23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.