From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE1BAC35641 for ; Sat, 22 Feb 2020 01:19:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B1642071E for ; Sat, 22 Feb 2020 01:19:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727287AbgBVBTs (ORCPT ); Fri, 21 Feb 2020 20:19:48 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:52070 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726852AbgBVBTs (ORCPT ); Fri, 21 Feb 2020 20:19:48 -0500 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1j5JS2-0002aA-9T; Sat, 22 Feb 2020 12:19:27 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Sat, 22 Feb 2020 12:19:26 +1100 Date: Sat, 22 Feb 2020 12:19:26 +1100 From: Herbert Xu To: Tianjia Zhang Cc: davem@davemloft.net, ebiggers@kernel.org, pvanleeuwen@rambus.com, zohar@linux.ibm.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: sm3 - export crypto_sm3_final function Message-ID: <20200222011926.GA18695@gondor.apana.org.au> References: <20200216090233.109416-1-tianjia.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200216090233.109416-1-tianjia.zhang@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Feb 16, 2020 at 05:02:33PM +0800, Tianjia Zhang wrote: > Both crypto_sm3_update and crypto_sm3_finup have been > exported, exporting crypto_sm3_final, to avoid having to > use crypto_sm3_finup(desc, NULL, 0, dgst) to calculate > the hash in some cases. > > Signed-off-by: Tianjia Zhang > --- > crypto/sm3_generic.c | 7 ++++--- > include/crypto/sm3.h | 2 ++ > 2 files changed, 6 insertions(+), 3 deletions(-) Please add this into the series that actually uses the function. It makes no sense on its own. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt