From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0FDFC35671 for ; Sat, 22 Feb 2020 05:21:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99E4B2071E for ; Sat, 22 Feb 2020 05:21:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UvDsFxmX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725976AbgBVFVc (ORCPT ); Sat, 22 Feb 2020 00:21:32 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:53673 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726596AbgBVFVc (ORCPT ); Sat, 22 Feb 2020 00:21:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582348891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2LypZWR3wo1C+DQ15GIrtwcRbipyTjTpddzxoXyYlwg=; b=UvDsFxmX/Ie7tFKrpPlFk99qRbUk7q7GzwZc0vKmLhrEu/k4/80zroXa7BiStQcO37V5k5 CSGqhyJSBhohUS+M0s/33Zmnfo+1Hn7RNaD++ATmCXkOH9UZ+desnq+DXFlFNj1pQ45Z1N ykdNVkJQzozUXKldJ7xSXpk+VB8n8Ek= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-NwztNkubMvmgWrolAX3oGQ-1; Sat, 22 Feb 2020 00:21:29 -0500 X-MC-Unique: NwztNkubMvmgWrolAX3oGQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CC8BD100550E; Sat, 22 Feb 2020 05:21:27 +0000 (UTC) Received: from localhost (dhcp-12-102.nay.redhat.com [10.66.12.102]) by smtp.corp.redhat.com (Postfix) with ESMTP id 40DFB5D9CD; Sat, 22 Feb 2020 05:21:26 +0000 (UTC) Date: Sat, 22 Feb 2020 13:31:53 +0800 From: Zorro Lang To: Jeff Moyer Cc: fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH V2 3/3] xfs/300: modify test to work on any fs block size Message-ID: <20200222053152.GM14282@dhcp-12-102.nay.redhat.com> Mail-Followup-To: Jeff Moyer , fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org References: <20200220200632.14075-1-jmoyer@redhat.com> <20200220200632.14075-4-jmoyer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200220200632.14075-4-jmoyer@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Thu, Feb 20, 2020 at 03:06:32PM -0500, Jeff Moyer wrote: > The test currently assumes a file system block size of 4k. It will > work just fine on any user-specified block size, though. > > Signed-off-by: Jeff Moyer > --- > tests/xfs/300 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/xfs/300 b/tests/xfs/300 > index 28608b81..4f1c927a 100755 > --- a/tests/xfs/300 > +++ b/tests/xfs/300 > @@ -50,8 +50,9 @@ $XFS_IO_PROG -f -c "pwrite -S 0x63 0 4096" $SCRATCH_MNT/attrvals >> $seqres.full > cat $SCRATCH_MNT/attrvals | attr -s name $SCRATCH_MNT/$seq.test >> $seqres.full 2>&1 > > # Fragment the file by writing backwards > +bs=$(_get_file_block_size $SCRATCH_MNT) > for I in `seq 6 -1 0`; do > - dd if=/dev/zero of=$SCRATCH_MNT/$seq.test seek=$I bs=4k \ > + dd if=/dev/zero of=$SCRATCH_MNT/$seq.test seek=$I bs=${bs} \ Although the original case won't fail on 64k test. But this change makes more sense. Thanks, Zorro > oflag=direct count=1 conv=notrunc >> $seqres.full 2>&1 > done > > -- > 2.19.1 >