From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B3A1C35672 for ; Sat, 22 Feb 2020 16:47:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01153206EF for ; Sat, 22 Feb 2020 16:47:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="oC+1V8NG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726817AbgBVQrA (ORCPT ); Sat, 22 Feb 2020 11:47:00 -0500 Received: from mail.andi.de1.cc ([85.214.55.253]:52428 "EHLO mail.andi.de1.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbgBVQrA (ORCPT ); Sat, 22 Feb 2020 11:47:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hRPFx+PZRKzFa546U2qlzpkcDSCf1FnKKySJh6PyUnk=; b=oC+1V8NGKKnq7OtxR/z/2+PlL osEQgR5r2xXL+cgeZLa/H+O9n5VzM6dFMo/Svr3XEQG+6JGrzTl7Wf4jQAtSeLDWhFANu5yCnUawY fumyiXfOa4IN56RipwHlDQckMhRJKg4Q/cBn8o9uLoXW//NQycb0Zp31azMifaIEY8DLg=; Received: from p5dc58966.dip0.t-ipconnect.de ([93.197.137.102] helo=eeepc) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1j5XvF-0004EA-Um; Sat, 22 Feb 2020 17:46:34 +0100 Received: from localhost ([127.0.0.1]) by localhost with esmtp (Exim 4.92) (envelope-from ) id 1j5XvF-0002YK-B5; Sat, 22 Feb 2020 17:46:33 +0100 Date: Sat, 22 Feb 2020 17:46:08 +0100 From: Andreas Kemnade To: "H. Nikolaus Schaller" Cc: PrasannaKumar Muralidharan , Paul Cercueil , Mathieu Malaterre , Srinivas Kandagatla , Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Jonathan Cameron , Krzysztof Kozlowski , Kees Cook , Andi Kleen , Geert Uytterhoeven , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Subject: Re: [PATCH v5 2/6] Bindings: nvmem: add bindings for JZ4780 efuse Message-ID: <20200222174408.10588e32@kemnade.info> In-Reply-To: References: <51642368a064073ab99bb3110863b5fadc382f82.1582367141.git.hns@goldelico.com> <20200222165738.61cde2a0@kemnade.info> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/TgvauzzV4EyUJ_hH4abMMTu"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/TgvauzzV4EyUJ_hH4abMMTu Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sat, 22 Feb 2020 17:34:06 +0100 "H. Nikolaus Schaller" wrote: > > Am 22.02.2020 um 16:57 schrieb Andreas Kemnade : > >=20 > > On Sat, 22 Feb 2020 11:25:37 +0100 > > "H. Nikolaus Schaller" wrote: > > =20 > >> From: PrasannaKumar Muralidharan > >>=20 > >> This patch brings support for the JZ4780 efuse. Currently it only expo= ses > >> a read only access to the entire 8K bits efuse memory. > >>=20 > >> Tested-by: Mathieu Malaterre > >> Signed-off-by: PrasannaKumar Muralidharan > >> Signed-off-by: Mathieu Malaterre > >> Signed-off-by: H. Nikolaus Schaller > >> [converted to yaml] > >> Signed-off-by: Andreas Kemnade > >> --- > >> .../bindings/nvmem/ingenic,jz4780-efuse.yaml | 50 +++++++++++++++++++ > >> 1 file changed, 50 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/nvmem/ingenic,jz4= 780-efuse.yaml > >>=20 > >> diff --git a/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-ef= use.yaml b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml > >> new file mode 100644 > >> index 000000000000..09a8ef937750 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml > >> @@ -0,0 +1,50 @@ > >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/nvmem/ingenic,jz4780-efuse.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Ingenic JZ EFUSE driver bindings > >> + > >> +maintainers: > >> + - PrasannaKumar Muralidharan > >> + > >> +allOf: > >> + - $ref: "nvmem.yaml#" > >> + > >> +properties: > >> + compatible: > >> + enum: > >> + - ingenic,jz4780-efuse > >> + > >> + reg: > >> + maxItems: 1 > >> + > >> + clocks: > >> + # Handle for the ahb for the efuse. > >> + maxItems: 1 > >> + > >> + clock-names: > >> + items: > >> + - const: ahb2 =20 > > as Rob said: probably not needed, since it is a single > > clock, and the driver uses devm_clk_get(dev, NULL), so it should be pre= pared > > for that without any extra work. =20 >=20 > The question is if a specific driver implementation should determine > what the DT requires or the other way round. I don't know... >=20 > I did interpret Rob's comment differently: there was >=20 > > - "clock-names" Must be "bus_clk" =20 >=20 > and he did say:=20 >=20 > 'clk' is redundant. How about 'ahb'? >=20 > So I thought he refers to the _clk suffix? >=20 and he said to my first try: --- > + clock-names: > + items: > + - const: bus_clk =20 My prior comment still applies. Also, for a single clock, you don't really need a name. --- Regards, Andreas --Sig_/TgvauzzV4EyUJ_hH4abMMTu Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEPIWxmAFyOaBcwCpFl4jFM1s/ye8FAl5RWtAACgkQl4jFM1s/ ye9VGhAAjRo5srdoJRml/7fEUEz7mS3nNuWp3JYCd8woqNanA6WUNL+vOHuys9d3 ZOrX4MQ83qwlD+clQIvrN7qNNeXtZr6btgH+JynIWOePOlKtWK/crwh+UkANROyM jHxOIqJiIJ33EOVDTXP9+FIm4W48m/sGQQxvq1jjJ8ASw7gvZ/M3MDeMQJPZuhvn PAjIV9Lqs4X0TSZTvTQ+ThYXFllCyxwKojcyODrJAWKx9VMqCc9fz2SYMgYSrAwX 2Sdv7aU5h1eD/1KUhchDRsAsIgzNjmalPkhL+SXj2flmaLSYKXIUQgpWwiKn4i96 oLSh+vsQcrhMvN/L+F+iqSTVdDcAkxhfOB4jb1ReGbYasyJwNm/8ROiXMS5+zv/x dBWeGRR4DS+A6Z3ccPxJNdug1TtBQNJHvhal/TePTtxBuG0IL4Sq7SY5BPnjQi7w JoYxL3xuGZ2ee7Qb1U+gvWqgL38lB0kumxSnDneHBZT9dqOvcsD5OhgRfVAScGvM tWpwsXhuGq3tLr0/GCCj8Fik5WGMoambyt/rRFF7IKaOLraiJlqAdGEg5tiY8R8p wWuwF2YW29NX4sziZsVVTSnf5Y51HDn20/IVAHFU8fpZPjnFn30lyydddhKAeIzf jBy+63J7qYP0+Vqk/8w5g3SVnqiZXc+ZB+rpdA3lPKsBe/XRKO0= =7A1/ -----END PGP SIGNATURE----- --Sig_/TgvauzzV4EyUJ_hH4abMMTu--