All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] docs/manual: clarify the <PKG>_PATCH_DEPENDENCIES guarantee
@ 2020-02-21  5:34 Baruch Siach
  2020-02-23  8:32 ` Yann E. MORIN
  2020-03-14 14:41 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2020-02-21  5:34 UTC (permalink / raw)
  To: buildroot

Unlike <PKG>_DEPENDENCIES, <PKG>_PATCH_DEPENDENCIES only guarantees
extract and patch of listed dependencies, not build. Make this subtlety
more explicit in the documentation.

Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 docs/manual/adding-packages-generic.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt
index 59cdb7ffd72d..82d97854dde4 100644
--- a/docs/manual/adding-packages-generic.txt
+++ b/docs/manual/adding-packages-generic.txt
@@ -374,9 +374,9 @@ not and can not work as people would expect it should:
 * +LIBFOO_PATCH_DEPENDENCIES+ lists the dependencies (in terms of
   package name) that are required for the current package to be
   patched. These dependencies are guaranteed to be extracted and
-  patched before the current package is patched. In a similar way,
-  +HOST_LIBFOO_PATCH_DEPENDENCIES+ lists the dependencies for the
-  current host package.
+  patched (but not necessarily be built) before the current package
+  is patched. In a similar way, +HOST_LIBFOO_PATCH_DEPENDENCIES+ lists
+  the dependencies for the current host package.
   This is seldom used; usually, +LIBFOO_DEPENDENCIES+ is what you
   really want to use.
 
-- 
2.25.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] docs/manual: clarify the <PKG>_PATCH_DEPENDENCIES guarantee
  2020-02-21  5:34 [Buildroot] [PATCH] docs/manual: clarify the <PKG>_PATCH_DEPENDENCIES guarantee Baruch Siach
@ 2020-02-23  8:32 ` Yann E. MORIN
  2020-03-14 14:41 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2020-02-23  8:32 UTC (permalink / raw)
  To: buildroot

Baruch, All,

On 2020-02-21 07:34 +0200, Baruch Siach spake thusly:
> Unlike <PKG>_DEPENDENCIES, <PKG>_PATCH_DEPENDENCIES only guarantees
> extract and patch of listed dependencies, not build. Make this subtlety
> more explicit in the documentation.
> 
> Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  docs/manual/adding-packages-generic.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt
> index 59cdb7ffd72d..82d97854dde4 100644
> --- a/docs/manual/adding-packages-generic.txt
> +++ b/docs/manual/adding-packages-generic.txt
> @@ -374,9 +374,9 @@ not and can not work as people would expect it should:
>  * +LIBFOO_PATCH_DEPENDENCIES+ lists the dependencies (in terms of
>    package name) that are required for the current package to be
>    patched. These dependencies are guaranteed to be extracted and
> -  patched before the current package is patched. In a similar way,
> -  +HOST_LIBFOO_PATCH_DEPENDENCIES+ lists the dependencies for the
> -  current host package.
> +  patched (but not necessarily be built) before the current package

Here I dropped the 'be' in front of 'built'.

Applied to master, thanks! :-)

Regards,
Yann E. MORIN.

> +  is patched. In a similar way, +HOST_LIBFOO_PATCH_DEPENDENCIES+ lists
> +  the dependencies for the current host package.
>    This is seldom used; usually, +LIBFOO_DEPENDENCIES+ is what you
>    really want to use.
>  
> -- 
> 2.25.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] docs/manual: clarify the <PKG>_PATCH_DEPENDENCIES guarantee
  2020-02-21  5:34 [Buildroot] [PATCH] docs/manual: clarify the <PKG>_PATCH_DEPENDENCIES guarantee Baruch Siach
  2020-02-23  8:32 ` Yann E. MORIN
@ 2020-03-14 14:41 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2020-03-14 14:41 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Unlike <PKG>_DEPENDENCIES, <PKG>_PATCH_DEPENDENCIES only guarantees
 > extract and patch of listed dependencies, not build. Make this subtlety
 > more explicit in the documentation.

 > Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
 > Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Committed to 2019.02.x and 2019.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-14 14:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21  5:34 [Buildroot] [PATCH] docs/manual: clarify the <PKG>_PATCH_DEPENDENCIES guarantee Baruch Siach
2020-02-23  8:32 ` Yann E. MORIN
2020-03-14 14:41 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.