All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/30] Lock warning cleanup
       [not found] <0/30>
@ 2020-02-14 20:47 ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 01/30] x86/apic/vector: Add missing annotation to lock_vector_lock(void) Jules Irenge
                     ` (29 more replies)
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
  1 sibling, 30 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel; +Cc: boqun.feng, Jules Irenge

This patch series adds missing annotations to various functions  that register warnings of context imbalance when built with Sparse tool. The adds fix the warnings and give better insight or directive on what the function are actually doing. 

Jules Irenge (30):
  x86/apic/vector: Add missing annotation to lock_vector_lock(void)
  x86/apic/vector: Add missing annotation to lock_vector_lock(void)
  mm/memcontrol: Add missing annotation for unlock_page_lru()
  mm/memcontrol: Add missing annotation for lock_page_lru()
  mm/compaction: Add missing annotation for compact_lock_irqsave
  mm/hugetlb: Add missing annotation for gather_surplus_pages()
  mm/mempolicy: Add missing annotation for queue_pages_pmd()
  mm/slub: Add missing annotation for get_map()
  mm/slub: Add missing annotation for put_map()
  mm/zsmalloc: Add missing annotation for migrate_read_lock()
  mm/zsmalloc: Add missing annotation for migrate_read_unlock()
  mm/zsmalloc: Add missing annotation for pin_tag()
  mm/zsmalloc: Add missing annotation for unpin_tag()
  x86/xen: Add missing annotation for xen_pte_lock()
  x86/xen: Add missing annotation for xen_pte_unlock()
  drm/vkms: Add missing annotation for vkms_crtc_atomic_begin()
  drm/vkms: Add missing annotation for vkms_crtc_atomic_flush()
  driver core: Add missing annotation for device_links_write_lock()
  driver core: Add missing annotation for device_links_read_lock()
  pcnet32: Add missing annotation for pcnet32_suspend()
  sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf()
  xhci: Add missing annotation for xhci_set_port_power()
  xhci: Add missing annotation for xhci_enter_test_mode
  tipc: Add missing annotation for tipc_node_read_lock()
  tipc: Add missing annotation for tipc_node_read_unlock()
  tipc: Add missing annotation for tipc_node_write_lock()
  tipc: Add missing annotation for tipc_node_write_unlock_fast()
  tipc: Add missing annotation for tipc_node_write_unlock()
  net: Add missing annotation for netlink_walk_start()
  net: Add missing annotation for netlink_walk_stop()

 arch/x86/kernel/apic/vector.c      | 4 ++--
 arch/x86/xen/mmu_pv.c              | 3 ++-
 drivers/base/core.c                | 4 ++--
 drivers/gpu/drm/vkms/vkms_crtc.c   | 2 ++
 drivers/net/ethernet/amd/pcnet32.c | 2 +-
 drivers/net/ethernet/sfc/ef10.c    | 1 +
 drivers/usb/host/xhci-hub.c        | 2 ++
 mm/compaction.c                    | 1 +
 mm/hugetlb.c                       | 1 +
 mm/memcontrol.c                    | 2 ++
 mm/mempolicy.c                     | 1 +
 mm/slub.c                          | 3 ++-
 mm/zsmalloc.c                      | 8 ++++----
 net/netlink/af_netlink.c           | 4 ++--
 net/tipc/node.c                    | 9 +++++----
 15 files changed, 30 insertions(+), 17 deletions(-)

-- 
2.24.1


^ permalink raw reply	[flat|nested] 125+ messages in thread

* [PATCH 01/30] x86/apic/vector: Add missing annotation to lock_vector_lock(void)
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 02/30] " Jules Irenge
                     ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H. Peter Anvin,
	maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
	Neil Horman, Allison Randal, Kate Stewart

Sparse reports a warning at lock_vector_lock(void)

warning: context imbalance in lock_vector_lock() - wrong count at exit

The root cause is the missing annotation at lock_vector_lock(void)
Add the missing  __acquires(&vector_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 arch/x86/kernel/apic/vector.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
index 2c5676b0a6e7..d7556939c6cf 100644
--- a/arch/x86/kernel/apic/vector.c
+++ b/arch/x86/kernel/apic/vector.c
@@ -47,7 +47,7 @@ static struct irq_matrix *vector_matrix;
 static DEFINE_PER_CPU(struct hlist_head, cleanup_list);
 #endif
 
-void lock_vector_lock(void)
+void lock_vector_lock(void) __acquires(&vector_lock)
 {
 	/* Used to the online set of cpus does not change
 	 * during assign_irq_vector.
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 02/30] x86/apic/vector: Add missing annotation to lock_vector_lock(void)
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
  2020-02-14 20:47   ` [PATCH 01/30] x86/apic/vector: Add missing annotation to lock_vector_lock(void) Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47     ` Jules Irenge
                     ` (27 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H. Peter Anvin,
	maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
	Enrico Weigelt, Allison Randal, Greg Kroah-Hartman, Neil Horman

Sparse reports a warning at unlock_vector_lock()

warning: context imbalance in unlock_vector_lock() - unexpected unlock

The root cause is the missing annotation at unlock_vector_lock()
Add the missing  __releases(&vector_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 arch/x86/kernel/apic/vector.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
index d7556939c6cf..8ee7848a355b 100644
--- a/arch/x86/kernel/apic/vector.c
+++ b/arch/x86/kernel/apic/vector.c
@@ -55,7 +55,7 @@ void lock_vector_lock(void) __acquires(&vector_lock)
 	raw_spin_lock(&vector_lock);
 }
 
-void unlock_vector_lock(void)
+void unlock_vector_lock(void) __releases(&vector_lock)
 {
 	raw_spin_unlock(&vector_lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 03/30] mm/memcontrol: Add missing annotation for unlock_page_lru()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
@ 2020-02-14 20:47     ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 02/30] " Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Johannes Weiner, Michal Hocko,
	Vladimir Davydov, Andrew Morton,
	open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG),
	open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)

Sparse reports warning at unlock_page_lry()

warning: context imbalance in unlock_page_lru() - unexpected unlock

The root cause is the missing annotation at unlock_page_lru()
Add the missing __releases(&pgdat->lru_lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/memcontrol.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 6f6dc8712e39..22ddd557a69b 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2587,6 +2587,7 @@ static void lock_page_lru(struct page *page, int *isolated)
 }
 
 static void unlock_page_lru(struct page *page, int isolated)
+	__releases(&pgdat->lru_lock)
 {
 	pg_data_t *pgdat = page_pgdat(page);
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 03/30] mm/memcontrol: Add missing annotation for unlock_page_lru()
@ 2020-02-14 20:47     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Johannes Weiner, Michal Hocko,
	Vladimir Davydov, Andrew Morton,
	open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER MEMCG,
	open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER MEMCG

Sparse reports warning at unlock_page_lry()

warning: context imbalance in unlock_page_lru() - unexpected unlock

The root cause is the missing annotation at unlock_page_lru()
Add the missing __releases(&pgdat->lru_lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/memcontrol.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 6f6dc8712e39..22ddd557a69b 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2587,6 +2587,7 @@ static void lock_page_lru(struct page *page, int *isolated)
 }
 
 static void unlock_page_lru(struct page *page, int isolated)
+	__releases(&pgdat->lru_lock)
 {
 	pg_data_t *pgdat = page_pgdat(page);
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 04/30] mm/memcontrol: Add missing annotation for lock_page_lru()
@ 2020-02-14 20:47     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Johannes Weiner, Michal Hocko,
	Vladimir Davydov, Andrew Morton,
	open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG),
	open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)

Sparse reports warning at lock_page_lry()

warning: context imbalance in lock_page_lru() - wrong count at exit

The root cause is the missing annotation at lock_page_lru()
Add the missing __acquires(&pgdat->lru_lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/memcontrol.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 22ddd557a69b..67dc9f1af0bf 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2571,6 +2571,7 @@ static void cancel_charge(struct mem_cgroup *memcg, unsigned int nr_pages)
 }
 
 static void lock_page_lru(struct page *page, int *isolated)
+	__acquires(&pgdat->lru_lock)
 {
 	pg_data_t *pgdat = page_pgdat(page);
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 04/30] mm/memcontrol: Add missing annotation for lock_page_lru()
@ 2020-02-14 20:47     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
  Cc: boqun.feng-Re5JQEeQqe8AvxtiuMwx3w, Jules Irenge, Johannes Weiner,
	Michal Hocko, Vladimir Davydov, Andrew Morton,
	open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER MEMCG,
	open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER MEMCG

Sparse reports warning at lock_page_lry()

warning: context imbalance in lock_page_lru() - wrong count at exit

The root cause is the missing annotation at lock_page_lru()
Add the missing __acquires(&pgdat->lru_lock)

Signed-off-by: Jules Irenge <jbi.octave-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 mm/memcontrol.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 22ddd557a69b..67dc9f1af0bf 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -2571,6 +2571,7 @@ static void cancel_charge(struct mem_cgroup *memcg, unsigned int nr_pages)
 }
 
 static void lock_page_lru(struct page *page, int *isolated)
+	__acquires(&pgdat->lru_lock)
 {
 	pg_data_t *pgdat = page_pgdat(page);
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 05/30] mm/compaction: Add missing annotation for compact_lock_irqsave
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (3 preceding siblings ...)
  2020-02-14 20:47     ` Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 06/30] mm/hugetlb: Add missing annotation for gather_surplus_pages() Jules Irenge
                     ` (24 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Andrew Morton, open list:MEMORY MANAGEMENT

Sparse reports a warning at compact_lock_irqsave()

warning: context imbalance in compact_lock_irqsave() - wrong count at exit

The root cause is the missing annotation at compact_lock_irqsave()
Add the missing __acquires(lock) annotation.

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/compaction.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/compaction.c b/mm/compaction.c
index 672d3c78c6ab..81190fe22200 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -481,6 +481,7 @@ static bool test_and_set_skip(struct compact_control *cc, struct page *page,
  */
 static bool compact_lock_irqsave(spinlock_t *lock, unsigned long *flags,
 						struct compact_control *cc)
+	__acquires(lock)
 {
 	/* Track if the lock is contended in async mode */
 	if (cc->mode == MIGRATE_ASYNC && !cc->contended) {
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 06/30] mm/hugetlb: Add missing annotation for gather_surplus_pages()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (4 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 05/30] mm/compaction: Add missing annotation for compact_lock_irqsave Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 23:40     ` Mike Kravetz
  2020-02-14 20:47   ` [PATCH 07/30] mm/mempolicy: Add missing annotation for queue_pages_pmd() Jules Irenge
                     ` (23 subsequent siblings)
  29 siblings, 1 reply; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Mike Kravetz, Andrew Morton,
	open list:HUGETLB FILESYSTEM

Sparse reports a warning at gather_surplus_pages()

warning: context imbalance in hugetlb_cow() - unexpected unlock

The root cause is the missing annotation at gather_surplus_pages()
Add the missing __must_hold(&hugetlb_lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/hugetlb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index dd8737a94bec..ff7dda27b33f 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1695,6 +1695,7 @@ struct page *alloc_huge_page_vma(struct hstate *h, struct vm_area_struct *vma,
  * of size 'delta'.
  */
 static int gather_surplus_pages(struct hstate *h, int delta)
+	__must_hold(&hugetlb_lock)
 {
 	struct list_head surplus_list;
 	struct page *page, *tmp;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 07/30] mm/mempolicy: Add missing annotation for queue_pages_pmd()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (5 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 06/30] mm/hugetlb: Add missing annotation for gather_surplus_pages() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 08/30] mm/slub: Add missing annotation for get_map() Jules Irenge
                     ` (22 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Andrew Morton, open list:MEMORY MANAGEMENT

Sparse reports a warning at queue_pages_pmd()

context imbalance in queue_pages_pmd() - unexpected unlock

The root cause is the missing annotation at queue_pages_pmd()
Add the missing __releases(ptl)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/mempolicy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 977c641f78cf..bb0755228150 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -442,6 +442,7 @@ static inline bool queue_pages_required(struct page *page,
  */
 static int queue_pages_pmd(pmd_t *pmd, spinlock_t *ptl, unsigned long addr,
 				unsigned long end, struct mm_walk *walk)
+	__releases(ptl)
 {
 	int ret = 0;
 	struct page *page;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 08/30] mm/slub: Add missing annotation for get_map()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (6 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 07/30] mm/mempolicy: Add missing annotation for queue_pages_pmd() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 09/30] mm/slub: Add missing annotation for put_map() Jules Irenge
                     ` (21 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Christoph Lameter, Pekka Enberg,
	David Rientjes, Joonsoo Kim, Andrew Morton,
	open list:SLAB ALLOCATOR

Sparse reports a warning at get_map()()

 warning: context imbalance in get_map() - wrong count at exit

The root cause is the missing annotation at get_map()
Add the missing __acquires(&object_map_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/slub.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/slub.c b/mm/slub.c
index 17dc00e33115..3c6d348afcf9 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -449,6 +449,7 @@ static DEFINE_SPINLOCK(object_map_lock);
  * not vanish from under us.
  */
 static unsigned long *get_map(struct kmem_cache *s, struct page *page)
+	__acquires(&object_map_lock)
 {
 	void *p;
 	void *addr = page_address(page);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 09/30] mm/slub: Add missing annotation for put_map()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (7 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 08/30] mm/slub: Add missing annotation for get_map() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock() Jules Irenge
                     ` (20 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Christoph Lameter, Pekka Enberg,
	David Rientjes, Joonsoo Kim, Andrew Morton,
	open list:SLAB ALLOCATOR

Sparse reports a warning at put_map()()

 warning: context imbalance in put_map() - unexpected unlock

The root cause is the missing annotation at put_map()
Add the missing __releases(&object_map_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/slub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slub.c b/mm/slub.c
index 3c6d348afcf9..c273d0f32b8f 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -466,7 +466,7 @@ static unsigned long *get_map(struct kmem_cache *s, struct page *page)
 	return object_map;
 }
 
-static void put_map(unsigned long *map)
+static void put_map(unsigned long *map) __releases(&object_map_lock)
 {
 	VM_BUG_ON(map != object_map);
 	lockdep_assert_held(&object_map_lock);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (8 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 09/30] mm/slub: Add missing annotation for put_map() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-27 21:52       ` Minchan Kim
  2020-02-27 21:52       ` Minchan Kim
  2020-02-14 20:47   ` [PATCH 11/30] mm/zsmalloc: Add missing annotation for migrate_read_unlock() Jules Irenge
                     ` (19 subsequent siblings)
  29 siblings, 2 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Minchan Kim, Nitin Gupta,
	Sergey Senozhatsky, Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

Sparse reports a warning at migrate_read_lock()()

 warning: context imbalance in migrate_read_lock() - wrong count at exit

The root cause is the missing annotation at migrate_read_lock()
Add the missing __acquires(&zspage->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 22d17ecfe7df..da70817b4ed8 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1833,7 +1833,7 @@ static void migrate_lock_init(struct zspage *zspage)
 	rwlock_init(&zspage->lock);
 }
 
-static void migrate_read_lock(struct zspage *zspage)
+static void migrate_read_lock(struct zspage *zspage) __acquires(&zspage->lock)
 {
 	read_lock(&zspage->lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 11/30] mm/zsmalloc: Add missing annotation for migrate_read_unlock()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (9 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-27 21:54       ` Minchan Kim
  2020-02-14 20:47   ` [PATCH 12/30] mm/zsmalloc: Add missing annotation for pin_tag() Jules Irenge
                     ` (18 subsequent siblings)
  29 siblings, 1 reply; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Minchan Kim, Nitin Gupta,
	Sergey Senozhatsky, Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

Sparse reports a warning at migrate_read_unlock()()

 warning: context imbalance in migrate_read_unlock() - unexpected unlock

The root cause is the missing annotation at migrate_read_unlock()
Add the missing __releases(&zspage->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index da70817b4ed8..2eab424c8c67 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1838,7 +1838,7 @@ static void migrate_read_lock(struct zspage *zspage) __acquires(&zspage->lock)
 	read_lock(&zspage->lock);
 }
 
-static void migrate_read_unlock(struct zspage *zspage)
+static void migrate_read_unlock(struct zspage *zspage) __releases(&zspage->lock)
 {
 	read_unlock(&zspage->lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 12/30] mm/zsmalloc: Add missing annotation for pin_tag()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (10 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 11/30] mm/zsmalloc: Add missing annotation for migrate_read_unlock() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-27 21:53       ` Minchan Kim
  2020-02-14 20:47   ` [PATCH 13/30] mm/zsmalloc: Add missing annotation for unpin_tag() Jules Irenge
                     ` (17 subsequent siblings)
  29 siblings, 1 reply; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Minchan Kim, Nitin Gupta,
	Sergey Senozhatsky, Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

Sparse reports a warning at pin_tag()()

warning: context imbalance in pin_tag() - wrong count at exit

The root cause is the missing annotation at pin_tag()
Add the missing __acquires(bitlock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 2eab424c8c67..7bac76ae11b3 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -891,7 +891,7 @@ static inline int trypin_tag(unsigned long handle)
 	return bit_spin_trylock(HANDLE_PIN_BIT, (unsigned long *)handle);
 }
 
-static void pin_tag(unsigned long handle)
+static void pin_tag(unsigned long handle) __acquires(bitlock)
 {
 	bit_spin_lock(HANDLE_PIN_BIT, (unsigned long *)handle);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 13/30] mm/zsmalloc: Add missing annotation for unpin_tag()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (11 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 12/30] mm/zsmalloc: Add missing annotation for pin_tag() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-27 21:53       ` Minchan Kim
  2020-02-14 20:47     ` [Xen-devel] " Jules Irenge
                     ` (16 subsequent siblings)
  29 siblings, 1 reply; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Minchan Kim, Nitin Gupta,
	Sergey Senozhatsky, Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

Sparse reports a warning at unpin_tag()()

warning: context imbalance in unpin_tag() - unexpected unlock

The root cause is the missing annotation at unpin_tag()
Add the missing __releases(bitlock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 7bac76ae11b3..2aa2d524a343 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -896,7 +896,7 @@ static void pin_tag(unsigned long handle) __acquires(bitlock)
 	bit_spin_lock(HANDLE_PIN_BIT, (unsigned long *)handle);
 }
 
-static void unpin_tag(unsigned long handle)
+static void unpin_tag(unsigned long handle) __releases(bitlock)
 {
 	bit_spin_unlock(HANDLE_PIN_BIT, (unsigned long *)handle);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 14/30] x86/xen: Add missing annotation for xen_pte_lock()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
@ 2020-02-14 20:47     ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 02/30] " Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Boris Ostrovsky, Juergen Gross,
	Stefano Stabellini, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H. Peter Anvin,
	maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
	moderated list:XEN HYPERVISOR INTERFACE

Sparse reports warning at xen_pte_lock()

warning: context imbalance in xen_pte_lock() - wrong count at exit

The root cause is the missing annotation at xen_pte_lock()
Add the missing __acquires(ptl) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 arch/x86/xen/mmu_pv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
index bbba8b17829a..352f0c80cfcf 100644
--- a/arch/x86/xen/mmu_pv.c
+++ b/arch/x86/xen/mmu_pv.c
@@ -695,6 +695,7 @@ static int xen_pgd_walk(struct mm_struct *mm,
 /* If we're using split pte locks, then take the page's lock and
    return a pointer to it.  Otherwise return NULL. */
 static spinlock_t *xen_pte_lock(struct page *page, struct mm_struct *mm)
+	__acquires(ptl)
 {
 	spinlock_t *ptl = NULL;
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [Xen-devel] [PATCH 14/30] x86/xen: Add missing annotation for xen_pte_lock()
@ 2020-02-14 20:47     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: Juergen Gross, Jules Irenge, Stefano Stabellini, boqun.feng,
	maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT, Ingo Molnar,
	Borislav Petkov, H. Peter Anvin,
	moderated list:XEN HYPERVISOR INTERFACE, Boris Ostrovsky,
	Thomas Gleixner

Sparse reports warning at xen_pte_lock()

warning: context imbalance in xen_pte_lock() - wrong count at exit

The root cause is the missing annotation at xen_pte_lock()
Add the missing __acquires(ptl) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 arch/x86/xen/mmu_pv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
index bbba8b17829a..352f0c80cfcf 100644
--- a/arch/x86/xen/mmu_pv.c
+++ b/arch/x86/xen/mmu_pv.c
@@ -695,6 +695,7 @@ static int xen_pgd_walk(struct mm_struct *mm,
 /* If we're using split pte locks, then take the page's lock and
    return a pointer to it.  Otherwise return NULL. */
 static spinlock_t *xen_pte_lock(struct page *page, struct mm_struct *mm)
+	__acquires(ptl)
 {
 	spinlock_t *ptl = NULL;
 
-- 
2.24.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 15/30] x86/xen: Add missing annotation for xen_pte_unlock()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
@ 2020-02-14 20:47     ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 02/30] " Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Boris Ostrovsky, Juergen Gross,
	Stefano Stabellini, Thomas Gleixner, Ingo Molnar,
	Borislav Petkov, H. Peter Anvin,
	maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),
	moderated list:XEN HYPERVISOR INTERFACE

Sparse reports warning at xen_pte_unlock()

warning: context imbalance in xen_pte_unlock() - unexpected unlock

The root cause is the missing annotation at xen_pte_unlock()
Add the missing __releases(ptl) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 arch/x86/xen/mmu_pv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
index 352f0c80cfcf..777008f8c668 100644
--- a/arch/x86/xen/mmu_pv.c
+++ b/arch/x86/xen/mmu_pv.c
@@ -707,7 +707,7 @@ static spinlock_t *xen_pte_lock(struct page *page, struct mm_struct *mm)
 	return ptl;
 }
 
-static void xen_pte_unlock(void *v)
+static void xen_pte_unlock(void *v) __releases(ptl)
 {
 	spinlock_t *ptl = v;
 	spin_unlock(ptl);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [Xen-devel] [PATCH 15/30] x86/xen: Add missing annotation for xen_pte_unlock()
@ 2020-02-14 20:47     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: Juergen Gross, Jules Irenge, Stefano Stabellini, boqun.feng,
	maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT, Ingo Molnar,
	Borislav Petkov, H. Peter Anvin,
	moderated list:XEN HYPERVISOR INTERFACE, Boris Ostrovsky,
	Thomas Gleixner

Sparse reports warning at xen_pte_unlock()

warning: context imbalance in xen_pte_unlock() - unexpected unlock

The root cause is the missing annotation at xen_pte_unlock()
Add the missing __releases(ptl) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 arch/x86/xen/mmu_pv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
index 352f0c80cfcf..777008f8c668 100644
--- a/arch/x86/xen/mmu_pv.c
+++ b/arch/x86/xen/mmu_pv.c
@@ -707,7 +707,7 @@ static spinlock_t *xen_pte_lock(struct page *page, struct mm_struct *mm)
 	return ptl;
 }
 
-static void xen_pte_unlock(void *v)
+static void xen_pte_unlock(void *v) __releases(ptl)
 {
 	spinlock_t *ptl = v;
 	spin_unlock(ptl);
-- 
2.24.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 16/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_begin()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
@ 2020-02-14 20:47     ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 02/30] " Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Rodrigo Siqueira, Haneen Mohammed,
	Daniel Vetter, David Airlie,
	open list:DRM DRIVER FOR VIRTUAL KERNEL MODESETTING (VKMS)

Sparse reports a warning at vkms_crtc_atomic_begin()

warning: context imbalance in vkms_crtc_atomic_begin()
	 - wrong count at exit

The root cause is the missing annotation at vkms_crtc_atomic_begin()
Add the missing __acquires(&vkms_output->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/gpu/drm/vkms/vkms_crtc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
index 74f703b8d22a..7513be6444ae 100644
--- a/drivers/gpu/drm/vkms/vkms_crtc.c
+++ b/drivers/gpu/drm/vkms/vkms_crtc.c
@@ -219,6 +219,7 @@ static void vkms_crtc_atomic_disable(struct drm_crtc *crtc,
 
 static void vkms_crtc_atomic_begin(struct drm_crtc *crtc,
 				   struct drm_crtc_state *old_crtc_state)
+	__acquires(&vkms_output->lock)
 {
 	struct vkms_output *vkms_output = drm_crtc_to_vkms_output(crtc);
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 16/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_begin()
@ 2020-02-14 20:47     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: Haneen Mohammed, Jules Irenge, Rodrigo Siqueira, David Airlie,
	boqun.feng,
	open list:DRM DRIVER FOR VIRTUAL KERNEL MODESETTING VKMS

Sparse reports a warning at vkms_crtc_atomic_begin()

warning: context imbalance in vkms_crtc_atomic_begin()
	 - wrong count at exit

The root cause is the missing annotation at vkms_crtc_atomic_begin()
Add the missing __acquires(&vkms_output->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/gpu/drm/vkms/vkms_crtc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
index 74f703b8d22a..7513be6444ae 100644
--- a/drivers/gpu/drm/vkms/vkms_crtc.c
+++ b/drivers/gpu/drm/vkms/vkms_crtc.c
@@ -219,6 +219,7 @@ static void vkms_crtc_atomic_disable(struct drm_crtc *crtc,
 
 static void vkms_crtc_atomic_begin(struct drm_crtc *crtc,
 				   struct drm_crtc_state *old_crtc_state)
+	__acquires(&vkms_output->lock)
 {
 	struct vkms_output *vkms_output = drm_crtc_to_vkms_output(crtc);
 
-- 
2.24.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 17/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_flush()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
@ 2020-02-14 20:47     ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 02/30] " Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Rodrigo Siqueira, Haneen Mohammed,
	Daniel Vetter, David Airlie,
	open list:DRM DRIVER FOR VIRTUAL KERNEL MODESETTING (VKMS)

Sparse reports a warning at vkms_crtc_atomic_flush()

warning: context imbalance in vkms_crtc_atomic_flush()
	 - unexpected unlock

The root cause is the missing annotation at vkms_crtc_atomic_flush()
Add the missing __releases(&vkms_output->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/gpu/drm/vkms/vkms_crtc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
index 7513be6444ae..bc0ac2641220 100644
--- a/drivers/gpu/drm/vkms/vkms_crtc.c
+++ b/drivers/gpu/drm/vkms/vkms_crtc.c
@@ -231,6 +231,7 @@ static void vkms_crtc_atomic_begin(struct drm_crtc *crtc,
 
 static void vkms_crtc_atomic_flush(struct drm_crtc *crtc,
 				   struct drm_crtc_state *old_crtc_state)
+	__releases(&vkms_output->lock)
 {
 	struct vkms_output *vkms_output = drm_crtc_to_vkms_output(crtc);
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 17/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_flush()
@ 2020-02-14 20:47     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: Haneen Mohammed, Jules Irenge, Rodrigo Siqueira, David Airlie,
	boqun.feng,
	open list:DRM DRIVER FOR VIRTUAL KERNEL MODESETTING VKMS

Sparse reports a warning at vkms_crtc_atomic_flush()

warning: context imbalance in vkms_crtc_atomic_flush()
	 - unexpected unlock

The root cause is the missing annotation at vkms_crtc_atomic_flush()
Add the missing __releases(&vkms_output->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/gpu/drm/vkms/vkms_crtc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
index 7513be6444ae..bc0ac2641220 100644
--- a/drivers/gpu/drm/vkms/vkms_crtc.c
+++ b/drivers/gpu/drm/vkms/vkms_crtc.c
@@ -231,6 +231,7 @@ static void vkms_crtc_atomic_begin(struct drm_crtc *crtc,
 
 static void vkms_crtc_atomic_flush(struct drm_crtc *crtc,
 				   struct drm_crtc_state *old_crtc_state)
+	__releases(&vkms_output->lock)
 {
 	struct vkms_output *vkms_output = drm_crtc_to_vkms_output(crtc);
 
-- 
2.24.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 18/30] driver core: Add missing annotation for device_links_write_lock()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (16 preceding siblings ...)
  2020-02-14 20:47     ` Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 19/30] driver core: Add missing annotation for device_links_read_lock() Jules Irenge
                     ` (11 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Greg Kroah-Hartman, Rafael J. Wysocki

Sparse reports a warning at device_links_write_lock()

warning: context imbalance in evice_links_write_lock()
	 - wrong count at exit

The root cause is the missing annotation at device_links_write_lock()
Add the missing __acquires(&device_links_srcu) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/base/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 42a672456432..fc7f1b8746da 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -64,7 +64,7 @@ static inline void device_links_write_unlock(void)
 	mutex_unlock(&device_links_lock);
 }
 
-int device_links_read_lock(void)
+int device_links_read_lock(void) __acquires(&device_links_srcu)
 {
 	return srcu_read_lock(&device_links_srcu);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 19/30] driver core: Add missing annotation for device_links_read_lock()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (17 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 18/30] driver core: Add missing annotation for device_links_write_lock() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 20/30] pcnet32: Add missing annotation for pcnet32_suspend() Jules Irenge
                     ` (10 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Greg Kroah-Hartman, Rafael J. Wysocki

Sparse reports a warning at device_links_read_unlock()

warning:  warning: context imbalance in device_links_read_unlock()
	 - unexpected unlock

The root cause is the missing annotation at device_links_read_unlock()
Add the missing __releases(&device_links_srcu) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/base/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index fc7f1b8746da..3a7e72840740 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -69,7 +69,7 @@ int device_links_read_lock(void) __acquires(&device_links_srcu)
 	return srcu_read_lock(&device_links_srcu);
 }
 
-void device_links_read_unlock(int idx)
+void device_links_read_unlock(int idx) __releases(&device_links_srcu)
 {
 	srcu_read_unlock(&device_links_srcu, idx);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 20/30] pcnet32: Add missing annotation for pcnet32_suspend()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (18 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 19/30] driver core: Add missing annotation for device_links_read_lock() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() Jules Irenge
                     ` (9 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Don Fry, David S. Miller,
	open list:PCNET32 NETWORK DRIVER

Sparse reports a warning at pcnet32_suspend()

warning: context imbalance in pcnet32_suspend() - unexpected unlock

The root cause is the missing annotation at pcnet32_suspend()
Add the missing __must_hold(&lp->lock) annotattion

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/net/ethernet/amd/pcnet32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c
index dc7d88227e76..ac6c19441932 100644
--- a/drivers/net/ethernet/amd/pcnet32.c
+++ b/drivers/net/ethernet/amd/pcnet32.c
@@ -684,7 +684,7 @@ static void pcnet32_poll_controller(struct net_device *dev)
  * lp->lock must be held.
  */
 static int pcnet32_suspend(struct net_device *dev, unsigned long *flags,
-			   int can_sleep)
+			   int can_sleep) __must_hold(&lp->lock)
 {
 	int csr5;
 	struct pcnet32_private *lp = netdev_priv(dev);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (19 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 20/30] pcnet32: Add missing annotation for pcnet32_suspend() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-17 18:00     ` Martin Habets
  2020-02-14 20:47   ` [PATCH 22/30] xhci: Add missing annotation for xhci_set_port_power() Jules Irenge
                     ` (8 subsequent siblings)
  29 siblings, 1 reply; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Solarflare linux maintainers,
	Edward Cree, Martin Habets, David S. Miller,
	open list:SFC NETWORK DRIVER

Sparse reports a warning at  efx_ef10_try_update_nic_stats_vf()

warning: context imbalance in  efx_ef10_try_update_nic_stats_vf()
	 - unexpected unlock

The root cause is the missing annotation at
efx_ef10_try_update_nic_stats_vf()
Add the missing __must_hold(&efx->stats_lock) annotattion

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/net/ethernet/sfc/ef10.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
index 52113b7529d6..b1102c7e814d 100644
--- a/drivers/net/ethernet/sfc/ef10.c
+++ b/drivers/net/ethernet/sfc/ef10.c
@@ -1820,6 +1820,7 @@ static size_t efx_ef10_update_stats_pf(struct efx_nic *efx, u64 *full_stats,
 }
 
 static int efx_ef10_try_update_nic_stats_vf(struct efx_nic *efx)
+	__must_hold(&efx->stats_lock)
 {
 	MCDI_DECLARE_BUF(inbuf, MC_CMD_MAC_STATS_IN_LEN);
 	struct efx_ef10_nic_data *nic_data = efx->nic_data;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 22/30] xhci: Add missing annotation for xhci_set_port_power()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (20 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 23/30] xhci: Add missing annotation for xhci_enter_test_mode Jules Irenge
                     ` (7 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Mathias Nyman, Greg Kroah-Hartman,
	open list:USB XHCI DRIVER

Sparse reports a warning at xhci_set_port_power()

warning: context imbalance in xhci_set_port_power - unexpected unlock

The root cause is the missing annotation at xhci_set_port_power()
Add the missing __must_hold(&xhci->lock) annotattion

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/usb/host/xhci-hub.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index 7a3a29e5e9d2..57e3f2c5475a 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers/usb/host/xhci-hub.c
@@ -558,6 +558,7 @@ struct xhci_hub *xhci_get_rhub(struct usb_hcd *hcd)
  */
 static void xhci_set_port_power(struct xhci_hcd *xhci, struct usb_hcd *hcd,
 				u16 index, bool on, unsigned long *flags)
+	__must_hold(&xhci->lock)
 {
 	struct xhci_hub *rhub;
 	struct xhci_port *port;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 23/30] xhci: Add missing annotation for xhci_enter_test_mode
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (21 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 22/30] xhci: Add missing annotation for xhci_set_port_power() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 24/30] tipc: Add missing annotation for tipc_node_read_lock() Jules Irenge
                     ` (6 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Mathias Nyman, Greg Kroah-Hartman,
	open list:USB XHCI DRIVER

Sparse reports a warning at xhci_enter_test_mode()

warning: context imbalance in  xhci_enter_test_mode - unexpected unlock

The root cause is the missing annotation at xhci_enter_test_mode()
Add the missing __must_hold(&xhci->lock) annotattion

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/usb/host/xhci-hub.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index 57e3f2c5475a..38839308557e 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers/usb/host/xhci-hub.c
@@ -609,6 +609,7 @@ static void xhci_port_set_test_mode(struct xhci_hcd *xhci,
 
 static int xhci_enter_test_mode(struct xhci_hcd *xhci,
 				u16 test_mode, u16 wIndex, unsigned long *flags)
+	__must_hold(&xhci->lock)
 {
 	int i, retval;
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 24/30] tipc: Add missing annotation for tipc_node_read_lock()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (22 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 23/30] xhci: Add missing annotation for xhci_enter_test_mode Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 25/30] tipc: Add missing annotation for tipc_node_read_unlock() Jules Irenge
                     ` (5 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Jon Maloy, Ying Xue, David S. Miller,
	Jakub Kicinski, open list:TIPC NETWORK LAYER,
	open list:TIPC NETWORK LAYER

Sparse reports a warning at tipc_node_read_lock()

warning: context imbalance in  tipc_node_read_lock - wrong count at exit

The root cause is the missing annotation at tipc_node_read_lock()
Add the missing __acquires(&n->lock) annotattion

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/tipc/node.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/node.c b/net/tipc/node.c
index 99b28b69fc17..4e267ed94a2a 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -351,7 +351,7 @@ static struct tipc_node *tipc_node_find_by_id(struct net *net, u8 *id)
 	return found ? n : NULL;
 }
 
-static void tipc_node_read_lock(struct tipc_node *n)
+static void tipc_node_read_lock(struct tipc_node *n) __acquires(&n->lock)
 {
 	read_lock_bh(&n->lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 25/30] tipc: Add missing annotation for tipc_node_read_unlock()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (23 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 24/30] tipc: Add missing annotation for tipc_node_read_lock() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 26/30] tipc: Add missing annotation for tipc_node_write_lock() Jules Irenge
                     ` (4 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Jon Maloy, Ying Xue, David S. Miller,
	Jakub Kicinski, open list:TIPC NETWORK LAYER,
	open list:TIPC NETWORK LAYER

Sparse reports a warning at tipc_node_read_unlock()

warning: context imbalance in  tipc_node_read_unlock - unexpected unlock

The root cause is the missing annotation at tipc_node_read_unlock()
Add the missing __releases(&n->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/tipc/node.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/node.c b/net/tipc/node.c
index 4e267ed94a2a..eafa38896e3a 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -356,7 +356,7 @@ static void tipc_node_read_lock(struct tipc_node *n) __acquires(&n->lock)
 	read_lock_bh(&n->lock);
 }
 
-static void tipc_node_read_unlock(struct tipc_node *n)
+static void tipc_node_read_unlock(struct tipc_node *n) __releases(&n->lock)
 {
 	read_unlock_bh(&n->lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 26/30] tipc: Add missing annotation for tipc_node_write_lock()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (24 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 25/30] tipc: Add missing annotation for tipc_node_read_unlock() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 27/30] tipc: Add missing annotation for tipc_node_write_unlock_fast() Jules Irenge
                     ` (3 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Jon Maloy, Ying Xue, David S. Miller,
	Jakub Kicinski, open list:TIPC NETWORK LAYER,
	open list:TIPC NETWORK LAYER

Sparse reports a warning at tipc_node_write_lock()

warning: context imbalance in  tipc_node_write_lock - wrong count at exit

The root cause is the missing annotation at tipc_node_write_lock()
Add the missing __acquires(&n->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/tipc/node.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/node.c b/net/tipc/node.c
index eafa38896e3a..d8401789fa23 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -361,7 +361,7 @@ static void tipc_node_read_unlock(struct tipc_node *n) __releases(&n->lock)
 	read_unlock_bh(&n->lock);
 }
 
-static void tipc_node_write_lock(struct tipc_node *n)
+static void tipc_node_write_lock(struct tipc_node *n) __acquires(&n->lock)
 {
 	write_lock_bh(&n->lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 27/30] tipc: Add missing annotation for tipc_node_write_unlock_fast()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (25 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 26/30] tipc: Add missing annotation for tipc_node_write_lock() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock() Jules Irenge
                     ` (2 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Jon Maloy, Ying Xue, David S. Miller,
	Jakub Kicinski, open list:TIPC NETWORK LAYER,
	open list:TIPC NETWORK LAYER

Sparse reports a warning at tipc_node_write_unlock_fast()

warning: context imbalance in tipc_node_write_unlock_fast
	 - unexpected unlock

The root cause is the missing annotation at tipc_node_write_unlock_fast()
Add the missing __releases(&n->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/tipc/node.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/tipc/node.c b/net/tipc/node.c
index d8401789fa23..cc656b2205db 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -367,6 +367,7 @@ static void tipc_node_write_lock(struct tipc_node *n) __acquires(&n->lock)
 }
 
 static void tipc_node_write_unlock_fast(struct tipc_node *n)
+	__releases(&n->lock)
 {
 	write_unlock_bh(&n->lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (26 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 27/30] tipc: Add missing annotation for tipc_node_write_unlock_fast() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 29/30] net: Add missing annotation for netlink_walk_start() Jules Irenge
  2020-02-14 20:47   ` [PATCH 30/30] net: Add missing annotation for netlink_walk_stop() Jules Irenge
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, Jon Maloy, Ying Xue, David S. Miller,
	Jakub Kicinski, open list:TIPC NETWORK LAYER,
	open list:TIPC NETWORK LAYER

Sparse reports a warning at tipc_node_write_unlock()

warning: context imbalance in tipc_node_write_unlock
	 - unexpected unlock

The root cause is the missing annotation at tipc_node_write_unlock()
Add the missing __releases(&n->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/tipc/node.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/node.c b/net/tipc/node.c
index cc656b2205db..c3b810427d24 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -372,7 +372,7 @@ static void tipc_node_write_unlock_fast(struct tipc_node *n)
 	write_unlock_bh(&n->lock);
 }
 
-static void tipc_node_write_unlock(struct tipc_node *n)
+static void tipc_node_write_unlock(struct tipc_node *n) __releases(&n->lock)
 {
 	struct net *net = n->net;
 	u32 addr = 0;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 29/30] net: Add missing annotation for netlink_walk_start()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (27 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  2020-02-14 20:47   ` [PATCH 30/30] net: Add missing annotation for netlink_walk_stop() Jules Irenge
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, David S. Miller, Jakub Kicinski,
	Patrick Talbert, Herbert Xu, Greg Kroah-Hartman, Taehee Yoo,
	Tetsuo Handa, Li RongQing, Thomas Gleixner,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at netlink_walk_start()

warning: context imbalance in netlink_walk_start()
	 - wrong count at exit

The root cause is the missing annotation at netlink_walk_start()
A close look at rhashtable_walk_start_check()
shows that an __acquires(RCU) is needed here.

Add the missing __acquires(RCU) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netlink/af_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 4e31721e7293..a3fddc845538 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2539,7 +2539,7 @@ struct nl_seq_iter {
 	int link;
 };
 
-static void netlink_walk_start(struct nl_seq_iter *iter)
+static void netlink_walk_start(struct nl_seq_iter *iter) __acquires(RCU)
 {
 	rhashtable_walk_enter(&nl_table[iter->link].hash, &iter->hti);
 	rhashtable_walk_start(&iter->hti);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 30/30] net: Add missing annotation for netlink_walk_stop()
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
                     ` (28 preceding siblings ...)
  2020-02-14 20:47   ` [PATCH 29/30] net: Add missing annotation for netlink_walk_start() Jules Irenge
@ 2020-02-14 20:47   ` Jules Irenge
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-14 20:47 UTC (permalink / raw)
  To: linux-kernel
  Cc: boqun.feng, Jules Irenge, David S. Miller, Jakub Kicinski,
	Taehee Yoo, Johannes Berg, Tetsuo Handa, Thomas Gleixner,
	Patrick Talbert, Herbert Xu, Li RongQing,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at netlink_walk_stop()

warning: context imbalance in netlink_walk_stop()
	 - unexpected unlock

The root cause is the missing annotation at netlink_walk_stop()
A close look at rhashtable_walk_stop()
shows that an __releases(RCU) is needed here
Add the missing __releases(RCU) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netlink/af_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index a3fddc845538..7a287dc73f63 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -2545,7 +2545,7 @@ static void netlink_walk_start(struct nl_seq_iter *iter) __acquires(RCU)
 	rhashtable_walk_start(&iter->hti);
 }
 
-static void netlink_walk_stop(struct nl_seq_iter *iter)
+static void netlink_walk_stop(struct nl_seq_iter *iter) __releases(RCU)
 {
 	rhashtable_walk_stop(&iter->hti);
 	rhashtable_walk_exit(&iter->hti);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* Re: [Xen-devel] [PATCH 14/30] x86/xen: Add missing annotation for xen_pte_lock()
  2020-02-14 20:47     ` [Xen-devel] " Jules Irenge
@ 2020-02-14 22:40       ` Boris Ostrovsky
  -1 siblings, 0 replies; 125+ messages in thread
From: Boris Ostrovsky @ 2020-02-14 22:40 UTC (permalink / raw)
  To: Jules Irenge, linux-kernel
  Cc: Juergen Gross, Stefano Stabellini, boqun.feng,
	maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT, Ingo Molnar,
	Borislav Petkov, H. Peter Anvin,
	moderated list:XEN HYPERVISOR INTERFACE, Thomas Gleixner



On 2/14/20 3:47 PM, Jules Irenge wrote:
> Sparse reports warning at xen_pte_lock()
>
> warning: context imbalance in xen_pte_lock() - wrong count at exit
>
> The root cause is the missing annotation at xen_pte_lock()
> Add the missing __acquires(ptl) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

although I'd prefer this and the next patch to be merged into a single one.



^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [Xen-devel] [PATCH 14/30] x86/xen: Add missing annotation for xen_pte_lock()
@ 2020-02-14 22:40       ` Boris Ostrovsky
  0 siblings, 0 replies; 125+ messages in thread
From: Boris Ostrovsky @ 2020-02-14 22:40 UTC (permalink / raw)
  To: Jules Irenge, linux-kernel
  Cc: Juergen Gross, Stefano Stabellini, boqun.feng,
	maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT, Ingo Molnar,
	Borislav Petkov, H. Peter Anvin,
	moderated list:XEN HYPERVISOR INTERFACE, Thomas Gleixner



On 2/14/20 3:47 PM, Jules Irenge wrote:
> Sparse reports warning at xen_pte_lock()
>
> warning: context imbalance in xen_pte_lock() - wrong count at exit
>
> The root cause is the missing annotation at xen_pte_lock()
> Add the missing __acquires(ptl) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

although I'd prefer this and the next patch to be merged into a single one.



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 06/30] mm/hugetlb: Add missing annotation for gather_surplus_pages()
  2020-02-14 20:47   ` [PATCH 06/30] mm/hugetlb: Add missing annotation for gather_surplus_pages() Jules Irenge
@ 2020-02-14 23:40     ` Mike Kravetz
  0 siblings, 0 replies; 125+ messages in thread
From: Mike Kravetz @ 2020-02-14 23:40 UTC (permalink / raw)
  To: Jules Irenge, linux-kernel; +Cc: boqun.feng, Andrew Morton, HUGETLB FILESYSTEM

On 2/14/20 12:47 PM, Jules Irenge wrote:
> Sparse reports a warning at gather_surplus_pages()
> 
> warning: context imbalance in hugetlb_cow() - unexpected unlock
> 
> The root cause is the missing annotation at gather_surplus_pages()
> Add the missing __must_hold(&hugetlb_lock)
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [Xen-devel] [PATCH 14/30] x86/xen: Add missing annotation for xen_pte_lock()
  2020-02-14 22:40       ` Boris Ostrovsky
@ 2020-02-15 21:13         ` Jules Irenge
  -1 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-15 21:13 UTC (permalink / raw)
  To: Boris Ostrovsky
  Cc: Jules Irenge, linux-kernel, Juergen Gross, Stefano Stabellini,
	boqun.feng, maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT,
	Ingo Molnar, Borislav Petkov, H. Peter Anvin,
	moderated list:XEN HYPERVISOR INTERFACE, Thomas Gleixner

Thanks for the feedback. I will send the merged version then if it s fine 
with you.
Regards,
Jules

On Fri, 14 Feb 2020, Boris Ostrovsky wrote:

> 
> 
> On 2/14/20 3:47 PM, Jules Irenge wrote:
> > Sparse reports warning at xen_pte_lock()
> >
> > warning: context imbalance in xen_pte_lock() - wrong count at exit
> >
> > The root cause is the missing annotation at xen_pte_lock()
> > Add the missing __acquires(ptl) annotation
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> 
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> 
> although I'd prefer this and the next patch to be merged into a single one.
> 
> 
> 

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [Xen-devel] [PATCH 14/30] x86/xen: Add missing annotation for xen_pte_lock()
@ 2020-02-15 21:13         ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-15 21:13 UTC (permalink / raw)
  To: Boris Ostrovsky
  Cc: Juergen Gross, Jules Irenge, Stefano Stabellini, boqun.feng,
	maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT, linux-kernel,
	Ingo Molnar, Borislav Petkov, H. Peter Anvin,
	moderated list:XEN HYPERVISOR INTERFACE, Thomas Gleixner

Thanks for the feedback. I will send the merged version then if it s fine 
with you.
Regards,
Jules

On Fri, 14 Feb 2020, Boris Ostrovsky wrote:

> 
> 
> On 2/14/20 3:47 PM, Jules Irenge wrote:
> > Sparse reports warning at xen_pte_lock()
> >
> > warning: context imbalance in xen_pte_lock() - wrong count at exit
> >
> > The root cause is the missing annotation at xen_pte_lock()
> > Add the missing __acquires(ptl) annotation
> >
> > Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> 
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> 
> although I'd prefer this and the next patch to be merged into a single one.
> 
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf()
  2020-02-14 20:47   ` [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() Jules Irenge
@ 2020-02-17 18:00     ` Martin Habets
  0 siblings, 0 replies; 125+ messages in thread
From: Martin Habets @ 2020-02-17 18:00 UTC (permalink / raw)
  To: Jules Irenge, linux-kernel
  Cc: boqun.feng, Solarflare linux maintainers, Edward Cree,
	David S. Miller, open list:SFC NETWORK DRIVER

On 14/02/2020 20:47, Jules Irenge wrote:
> Sparse reports a warning at  efx_ef10_try_update_nic_stats_vf()
> 
> warning: context imbalance in  efx_ef10_try_update_nic_stats_vf()
> 	 - unexpected unlock
> 
> The root cause is the missing annotation at
> efx_ef10_try_update_nic_stats_vf()
> Add the missing __must_hold(&efx->stats_lock) annotattion
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Thanks

Acked-by: Martin Habets <mhabets@solarflare.com>

> ---
>  drivers/net/ethernet/sfc/ef10.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
> index 52113b7529d6..b1102c7e814d 100644
> --- a/drivers/net/ethernet/sfc/ef10.c
> +++ b/drivers/net/ethernet/sfc/ef10.c
> @@ -1820,6 +1820,7 @@ static size_t efx_ef10_update_stats_pf(struct efx_nic *efx, u64 *full_stats,
>  }
>  
>  static int efx_ef10_try_update_nic_stats_vf(struct efx_nic *efx)
> +	__must_hold(&efx->stats_lock)
>  {
>  	MCDI_DECLARE_BUF(inbuf, MC_CMD_MAC_STATS_IN_LEN);
>  	struct efx_ef10_nic_data *nic_data = efx->nic_data;
> 

^ permalink raw reply	[flat|nested] 125+ messages in thread

* [PATCH 00/30] Lock warning cleanups
       [not found] <0/30>
  2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
@ 2020-02-23 23:16 ` Jules Irenge
  2020-02-23 23:16   ` [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() Jules Irenge
                     ` (29 more replies)
  1 sibling, 30 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng; +Cc: jbi.octave, linux-kernel

This patch series adds missing annotations to various functions,
that register warnings of context imbalance when built with Sparse tool.
The adds fix the warnings, improve on readability odf the code
and give better insight or directive on what the functions are actually doing.

Jules Irenge (30):
  btrfs: Add missing annotation for release_extent_buffer()
  dax: Add missing annotations ofr dax_read_lock() and dax_read_unlock()
  xfs: Add missing annotation to xfs_ail_check()
  sctp: Add missing annotation for sctp_err_finish()
  sctp: Add missing annotation for sctp_transport_walk_start()
  sctp: Add missing annotation for sctp_transport_walk_stop()
  net: Add missing annotation for llc_seq_start()
  netrom: Add missing annotation for nr_info_start()
  netrom: Add missing annotation for nr_info_stop()
  net: netrom: Add missing annotation for nr_node_start()
  net: netrom: Add missing annotation for nr_node_stop()
  net: netrom: Add missing annotation for nr_neigh_start()
  net: netrom: Add missing annotation for nr_neigh_stop()
  dccp: Add missing annotation for dccp_child_process()
  af_unix: Add missing annotation for unix_wait_for_peer()
  proc: Add missing annotation for close_pdeo()
  mm/zsmalloc: Add missing annotation for zs_map_object()
  mm/zsmalloc: Add missing annotation for zs_unmap_object()
  mm/zsmalloc: Add missing annotation for migrate_write_lock()
  mm/zsmalloc: Add missing annotation for migrate_write_unlock()
  scsi: csiostor: Add missing annotation for csio_scsi_cleanup_io_q()
  ACPI: OSL: Add missing annotation for acpi_os_acquire_lock()
  ACPI: OSL: Add missing annotation for acpi_os_release_lock()
  dmaengine: mic_x100_dma: Add missing annotation for
    mic_dma_tx_submit_unlock()
  zram: Add missing annotatin for zram_slot_lock()
  zram: Add missing annotatin for zram_slot_unlock()
  habanalabs: Add missing annotation for goya_hw_queues_lock()
  habanalabs: Add missing annotation for goya_hw_queues_unlock()
  sgi-xp: Add missing annotation for xpc_disconnect_channel()
  sgi-xp: Add missing annotation for ocfs2_inode_cache_lock() and
    ocfs2_inode_cache_unlock()

 drivers/acpi/osl.c                  | 2 ++
 drivers/block/zram/zram_drv.c       | 2 ++
 drivers/dax/super.c                 | 4 ++--
 drivers/dma/mic_x100_dma.c          | 1 +
 drivers/misc/habanalabs/goya/goya.c | 2 ++
 drivers/misc/sgi-xp/xpc_channel.c   | 1 +
 drivers/scsi/csiostor/csio_scsi.c   | 1 +
 fs/btrfs/extent_io.c                | 1 +
 fs/ocfs2/inode.c                    | 2 ++
 fs/proc/inode.c                     | 1 +
 fs/xfs/xfs_trans_ail.c              | 1 +
 mm/zsmalloc.c                       | 4 ++++
 net/dccp/minisocks.c                | 1 +
 net/llc/llc_proc.c                  | 2 +-
 net/netrom/af_netrom.c              | 2 ++
 net/netrom/nr_route.c               | 4 ++++
 net/sctp/input.c                    | 1 +
 net/sctp/socket.c                   | 4 ++--
 net/unix/af_unix.c                  | 1 +
 19 files changed, 32 insertions(+), 5 deletions(-)

-- 
2.24.1


^ permalink raw reply	[flat|nested] 125+ messages in thread

* [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
@ 2020-02-23 23:16   ` Jules Irenge
  2020-02-23 23:27     ` Nikolay Borisov
  2020-02-24 15:19     ` David Sterba
  2020-02-23 23:16     ` Jules Irenge
                     ` (28 subsequent siblings)
  29 siblings, 2 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Chris Mason, Josef Bacik, David Sterba,
	open list:BTRFS FILE SYSTEM

Sparse reports a warning at release_extent_buffer()
warning: context imbalance in release_extent_buffer() - unexpected unlock

The root cause is the missing annotation at release_extent_buffer()
Add the missing __releases(&eb->refs_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 fs/btrfs/extent_io.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index c0f202741e09..8b6d6893e7a7 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -5230,6 +5230,7 @@ static inline void btrfs_release_extent_buffer_rcu(struct rcu_head *head)
 }
 
 static int release_extent_buffer(struct extent_buffer *eb)
+	__releases(&eb->refs_lock)
 {
 	lockdep_assert_held(&eb->refs_lock);
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 02/30] dax: Add missing annotations ofr dax_read_lock() and dax_read_unlock()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
@ 2020-02-23 23:16     ` Jules Irenge
  2020-02-23 23:16     ` Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng; +Cc: jbi.octave, linux-kernel, open list:DEVICE DIRECT ACCESS DAX

Sparse reports warning at dax_read_lock() and at dax_read_unlock()

warning: context imbalance in dax_read_lock() - wrong count at exit
 warning: context imbalance in dax_read_unlock() - unexpected unlock

The root cause is the mnissing annotations at dax_read_lock()
	and dax_read_unlock()

Add the missing __acquires(&dax_srcu) notations to dax_read_lock()
Add the missing __releases(&dax_srcu) annotation to dax_read_unlock()

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/dax/super.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dax/super.c b/drivers/dax/super.c
index 26a654dbc69a..f872a2fb98d4 100644
--- a/drivers/dax/super.c
+++ b/drivers/dax/super.c
@@ -28,13 +28,13 @@ static struct super_block *dax_superblock __read_mostly;
 static struct hlist_head dax_host_list[DAX_HASH_SIZE];
 static DEFINE_SPINLOCK(dax_host_lock);
 
-int dax_read_lock(void)
+int dax_read_lock(void) __acquires(&dax_srcu)
 {
 	return srcu_read_lock(&dax_srcu);
 }
 EXPORT_SYMBOL_GPL(dax_read_lock);
 
-void dax_read_unlock(int id)
+void dax_read_unlock(int id) __releases(&dax_srcu)
 {
 	srcu_read_unlock(&dax_srcu, id);
 }
-- 
2.24.1
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 02/30] dax: Add missing annotations ofr dax_read_lock() and dax_read_unlock()
@ 2020-02-23 23:16     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Dan Williams, Vishal Verma, Dave Jiang,
	open list:DEVICE DIRECT ACCESS (DAX)

Sparse reports warning at dax_read_lock() and at dax_read_unlock()

warning: context imbalance in dax_read_lock() - wrong count at exit
 warning: context imbalance in dax_read_unlock() - unexpected unlock

The root cause is the mnissing annotations at dax_read_lock()
	and dax_read_unlock()

Add the missing __acquires(&dax_srcu) notations to dax_read_lock()
Add the missing __releases(&dax_srcu) annotation to dax_read_unlock()

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/dax/super.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dax/super.c b/drivers/dax/super.c
index 26a654dbc69a..f872a2fb98d4 100644
--- a/drivers/dax/super.c
+++ b/drivers/dax/super.c
@@ -28,13 +28,13 @@ static struct super_block *dax_superblock __read_mostly;
 static struct hlist_head dax_host_list[DAX_HASH_SIZE];
 static DEFINE_SPINLOCK(dax_host_lock);
 
-int dax_read_lock(void)
+int dax_read_lock(void) __acquires(&dax_srcu)
 {
 	return srcu_read_lock(&dax_srcu);
 }
 EXPORT_SYMBOL_GPL(dax_read_lock);
 
-void dax_read_unlock(int id)
+void dax_read_unlock(int id) __releases(&dax_srcu)
 {
 	srcu_read_unlock(&dax_srcu, id);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 03/30] xfs: Add missing annotation to xfs_ail_check()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
  2020-02-23 23:16   ` [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() Jules Irenge
  2020-02-23 23:16     ` Jules Irenge
@ 2020-02-23 23:16   ` Jules Irenge
  2020-02-25 15:44     ` Darrick J. Wong
  2020-02-23 23:16     ` Jules Irenge
                     ` (26 subsequent siblings)
  29 siblings, 1 reply; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Darrick J. Wong, supporter:XFS FILESYSTEM

Sparse reports a warning at xfs_ail_check()

warning: context imbalance in xfs_ail_check() - unexpected unlock

The root cause is the missing annotation at xfs_ail_check()

Add the missing __must_hold(&ailp->ail_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 fs/xfs/xfs_trans_ail.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
index 00cc5b8734be..58d4ef1b4c05 100644
--- a/fs/xfs/xfs_trans_ail.c
+++ b/fs/xfs/xfs_trans_ail.c
@@ -32,6 +32,7 @@ STATIC void
 xfs_ail_check(
 	struct xfs_ail		*ailp,
 	struct xfs_log_item	*lip)
+	__must_hold(&ailp->ail_lock)
 {
 	struct xfs_log_item	*prev_lip;
 	struct xfs_log_item	*next_lip;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
@ 2020-02-23 23:16     ` Jules Irenge
  2020-02-23 23:16     ` Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Vlad Yasevich, Neil Horman,
	Marcelo Ricardo Leitner, David S. Miller, Jakub Kicinski,
	open list:SCTP PROTOCOL, open list:NETWORKING [GENERAL]

Sparse reports a warning at sctp_err_finish()
warning: context imbalance in sctp_err_finish() - unexpected unlock

The root cause is a missing annotation at sctp_err_finish()
Add the missing  __releases(&((__sk)->sk_lock.slock)) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/sctp/input.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sctp/input.c b/net/sctp/input.c
index efaaefc3bb1c..55d4fc6f371d 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -548,6 +548,7 @@ struct sock *sctp_err_lookup(struct net *net, int family, struct sk_buff *skb,
 
 /* Common cleanup code for icmp/icmpv6 error handler. */
 void sctp_err_finish(struct sock *sk, struct sctp_transport *t)
+	__releases(&((__sk)->sk_lock.slock))
 {
 	bh_unlock_sock(sk);
 	sctp_transport_put(t);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish()
@ 2020-02-23 23:16     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Vlad Yasevich, Neil Horman,
	Marcelo Ricardo Leitner, David S. Miller, Jakub Kicinski,
	open list:SCTP PROTOCOL, open list:NETWORKING [GENERAL]

Sparse reports a warning at sctp_err_finish()
warning: context imbalance in sctp_err_finish() - unexpected unlock

The root cause is a missing annotation at sctp_err_finish()
Add the missing  __releases(&((__sk)->sk_lock.slock)) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/sctp/input.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sctp/input.c b/net/sctp/input.c
index efaaefc3bb1c..55d4fc6f371d 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -548,6 +548,7 @@ struct sock *sctp_err_lookup(struct net *net, int family, struct sk_buff *skb,
 
 /* Common cleanup code for icmp/icmpv6 error handler. */
 void sctp_err_finish(struct sock *sk, struct sctp_transport *t)
+	__releases(&((__sk)->sk_lock.slock))
 {
 	bh_unlock_sock(sk);
 	sctp_transport_put(t);
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
@ 2020-02-23 23:16     ` Jules Irenge
  2020-02-23 23:16     ` Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Vlad Yasevich, Neil Horman,
	Marcelo Ricardo Leitner, David S. Miller, Jakub Kicinski,
	open list:SCTP PROTOCOL, open list:NETWORKING [GENERAL]

Sparse reports a warning at sctp_transport_walk_start()

warning: context imbalance in sctp_transport_walk_start
	- wrong count at exit

The root cause is the missing annotation at sctp_transport_walk_start()
Add the missing __acquires(RCU) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/sctp/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 1b56fc440606..05be67bb0474 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -5333,7 +5333,7 @@ int sctp_get_sctp_info(struct sock *sk, struct sctp_association *asoc,
 EXPORT_SYMBOL_GPL(sctp_get_sctp_info);
 
 /* use callback to avoid exporting the core structure */
-void sctp_transport_walk_start(struct rhashtable_iter *iter)
+void sctp_transport_walk_start(struct rhashtable_iter *iter) __acquires(RCU)
 {
 	rhltable_walk_enter(&sctp_transport_hashtable, iter);
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start()
@ 2020-02-23 23:16     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Vlad Yasevich, Neil Horman,
	Marcelo Ricardo Leitner, David S. Miller, Jakub Kicinski,
	open list:SCTP PROTOCOL, open list:NETWORKING [GENERAL]

Sparse reports a warning at sctp_transport_walk_start()

warning: context imbalance in sctp_transport_walk_start
	- wrong count at exit

The root cause is the missing annotation at sctp_transport_walk_start()
Add the missing __acquires(RCU) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/sctp/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 1b56fc440606..05be67bb0474 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -5333,7 +5333,7 @@ int sctp_get_sctp_info(struct sock *sk, struct sctp_association *asoc,
 EXPORT_SYMBOL_GPL(sctp_get_sctp_info);
 
 /* use callback to avoid exporting the core structure */
-void sctp_transport_walk_start(struct rhashtable_iter *iter)
+void sctp_transport_walk_start(struct rhashtable_iter *iter) __acquires(RCU)
 {
 	rhltable_walk_enter(&sctp_transport_hashtable, iter);
 
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
@ 2020-02-23 23:16     ` Jules Irenge
  2020-02-23 23:16     ` Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Vlad Yasevich, Neil Horman,
	Marcelo Ricardo Leitner, David S. Miller, Jakub Kicinski,
	open list:SCTP PROTOCOL, open list:NETWORKING [GENERAL]

Sparse reports a warning at sctp_transport_walk_stop()

warning: context imbalance in sctp_transport_walk_stop
	- wrong count at exit

The root cause is the missing annotation at sctp_transport_walk_stop()
Add the missing __releases(RCU) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/sctp/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 05be67bb0474..fed26a1e9518 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -5340,7 +5340,7 @@ void sctp_transport_walk_start(struct rhashtable_iter *iter) __acquires(RCU)
 	rhashtable_walk_start(iter);
 }
 
-void sctp_transport_walk_stop(struct rhashtable_iter *iter)
+void sctp_transport_walk_stop(struct rhashtable_iter *iter) __releases(RCU)
 {
 	rhashtable_walk_stop(iter);
 	rhashtable_walk_exit(iter);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop()
@ 2020-02-23 23:16     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Vlad Yasevich, Neil Horman,
	Marcelo Ricardo Leitner, David S. Miller, Jakub Kicinski,
	open list:SCTP PROTOCOL, open list:NETWORKING [GENERAL]

Sparse reports a warning at sctp_transport_walk_stop()

warning: context imbalance in sctp_transport_walk_stop
	- wrong count at exit

The root cause is the missing annotation at sctp_transport_walk_stop()
Add the missing __releases(RCU) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/sctp/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index 05be67bb0474..fed26a1e9518 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -5340,7 +5340,7 @@ void sctp_transport_walk_start(struct rhashtable_iter *iter) __acquires(RCU)
 	rhashtable_walk_start(iter);
 }
 
-void sctp_transport_walk_stop(struct rhashtable_iter *iter)
+void sctp_transport_walk_stop(struct rhashtable_iter *iter) __releases(RCU)
 {
 	rhashtable_walk_stop(iter);
 	rhashtable_walk_exit(iter);
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 07/30] net: Add missing annotation for llc_seq_start()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (5 preceding siblings ...)
  2020-02-23 23:16     ` Jules Irenge
@ 2020-02-23 23:16   ` Jules Irenge
  2020-02-24 21:28     ` David Miller
  2020-02-23 23:16     ` Jules Irenge
                     ` (22 subsequent siblings)
  29 siblings, 1 reply; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, David S. Miller, Jakub Kicinski,
	open list:LLC (802.2)

Sparse reports a warning at llc_seq_start()

warning: context imbalance in llc_seq_start() - wrong count at exit
The root cause is the msiing annotation at llc_seq_start()

Add the missing __acquires(RCU) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/llc/llc_proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/llc/llc_proc.c b/net/llc/llc_proc.c
index f3a36c16a5e7..a4eccb98220a 100644
--- a/net/llc/llc_proc.c
+++ b/net/llc/llc_proc.c
@@ -56,7 +56,7 @@ static struct sock *llc_get_sk_idx(loff_t pos)
 	return sk;
 }
 
-static void *llc_seq_start(struct seq_file *seq, loff_t *pos)
+static void *llc_seq_start(struct seq_file *seq, loff_t *pos) __acquires(RCU)
 {
 	loff_t l = *pos;
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 08/30] netrom: Add missing annotation for nr_info_start()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
@ 2020-02-23 23:16     ` Jules Irenge
  2020-02-23 23:16     ` Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller,
	Jakub Kicinski, open list:NETROM NETWORK LAYER,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at nr_info_start()
warning: context imbalance in nr_info_start() - wrong count at exit
The root cause is the missing annotation at nr_info_start()
Add the missing __acquires(&nr_list_lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netrom/af_netrom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c
index 58d5373c513c..8be06e61ff03 100644
--- a/net/netrom/af_netrom.c
+++ b/net/netrom/af_netrom.c
@@ -1230,6 +1230,7 @@ static int nr_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
 #ifdef CONFIG_PROC_FS
 
 static void *nr_info_start(struct seq_file *seq, loff_t *pos)
+	__acquires(&nr_list_lock)
 {
 	spin_lock_bh(&nr_list_lock);
 	return seq_hlist_start_head(&nr_list, *pos);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 08/30] netrom: Add missing annotation for nr_info_start()
@ 2020-02-23 23:16     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller,
	Jakub Kicinski, open list:NETROM NETWORK LAYER,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at nr_info_start()
warning: context imbalance in nr_info_start() - wrong count at exit
The root cause is the missing annotation at nr_info_start()
Add the missing __acquires(&nr_list_lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netrom/af_netrom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c
index 58d5373c513c..8be06e61ff03 100644
--- a/net/netrom/af_netrom.c
+++ b/net/netrom/af_netrom.c
@@ -1230,6 +1230,7 @@ static int nr_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
 #ifdef CONFIG_PROC_FS
 
 static void *nr_info_start(struct seq_file *seq, loff_t *pos)
+	__acquires(&nr_list_lock)
 {
 	spin_lock_bh(&nr_list_lock);
 	return seq_hlist_start_head(&nr_list, *pos);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 09/30] netrom: Add missing annotation for nr_info_stop()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
@ 2020-02-23 23:16     ` Jules Irenge
  2020-02-23 23:16     ` Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller,
	Jakub Kicinski, open list:NETROM NETWORK LAYER,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at nr_info_stop()
warning: context imbalance in nr_info_stop() - unexpected unlock
The root cause is the missing annotation at nr_info_stop()
Add the missing __releases(&nr_list_lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netrom/af_netrom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c
index 8be06e61ff03..7b1a74f74aad 100644
--- a/net/netrom/af_netrom.c
+++ b/net/netrom/af_netrom.c
@@ -1242,6 +1242,7 @@ static void *nr_info_next(struct seq_file *seq, void *v, loff_t *pos)
 }
 
 static void nr_info_stop(struct seq_file *seq, void *v)
+	__releases(&nr_list_lock)
 {
 	spin_unlock_bh(&nr_list_lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 09/30] netrom: Add missing annotation for nr_info_stop()
@ 2020-02-23 23:16     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller,
	Jakub Kicinski, open list:NETROM NETWORK LAYER,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at nr_info_stop()
warning: context imbalance in nr_info_stop() - unexpected unlock
The root cause is the missing annotation at nr_info_stop()
Add the missing __releases(&nr_list_lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netrom/af_netrom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c
index 8be06e61ff03..7b1a74f74aad 100644
--- a/net/netrom/af_netrom.c
+++ b/net/netrom/af_netrom.c
@@ -1242,6 +1242,7 @@ static void *nr_info_next(struct seq_file *seq, void *v, loff_t *pos)
 }
 
 static void nr_info_stop(struct seq_file *seq, void *v)
+	__releases(&nr_list_lock)
 {
 	spin_unlock_bh(&nr_list_lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
@ 2020-02-23 23:16     ` Jules Irenge
  2020-02-23 23:16     ` Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller,
	Jakub Kicinski, open list:NETROM NETWORK LAYER,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at nr_node_start()
warning: context imbalance in nr_node_start() - wrong count at exit
The root cause is the missing annotation at nr_node_start()
Add the missing __acquires(&nr_node_list_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netrom/nr_route.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index d41335bad1f8..fe278fc24153 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -838,6 +838,7 @@ int nr_route_frame(struct sk_buff *skb, ax25_cb *ax25)
 #ifdef CONFIG_PROC_FS
 
 static void *nr_node_start(struct seq_file *seq, loff_t *pos)
+	__acquires(&nr_node_list_lock)
 {
 	spin_lock_bh(&nr_node_list_lock);
 	return seq_hlist_start_head(&nr_node_list, *pos);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start()
@ 2020-02-23 23:16     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller,
	Jakub Kicinski, open list:NETROM NETWORK LAYER,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at nr_node_start()
warning: context imbalance in nr_node_start() - wrong count at exit
The root cause is the missing annotation at nr_node_start()
Add the missing __acquires(&nr_node_list_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netrom/nr_route.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index d41335bad1f8..fe278fc24153 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -838,6 +838,7 @@ int nr_route_frame(struct sk_buff *skb, ax25_cb *ax25)
 #ifdef CONFIG_PROC_FS
 
 static void *nr_node_start(struct seq_file *seq, loff_t *pos)
+	__acquires(&nr_node_list_lock)
 {
 	spin_lock_bh(&nr_node_list_lock);
 	return seq_hlist_start_head(&nr_node_list, *pos);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
@ 2020-02-23 23:16     ` Jules Irenge
  2020-02-23 23:16     ` Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller,
	Jakub Kicinski, open list:NETROM NETWORK LAYER,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at nr_node_stop()
warning: context imbalance in nr_node_stop() - wrong count at exit
The root cause is the missing annotation at nr_node_stop()
Add the missing __releases(&nr_node_list_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netrom/nr_route.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index fe278fc24153..637a743c060d 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -850,6 +850,7 @@ static void *nr_node_next(struct seq_file *seq, void *v, loff_t *pos)
 }
 
 static void nr_node_stop(struct seq_file *seq, void *v)
+	__releases(&nr_node_list_lock)
 {
 	spin_unlock_bh(&nr_node_list_lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop()
@ 2020-02-23 23:16     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller,
	Jakub Kicinski, open list:NETROM NETWORK LAYER,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at nr_node_stop()
warning: context imbalance in nr_node_stop() - wrong count at exit
The root cause is the missing annotation at nr_node_stop()
Add the missing __releases(&nr_node_list_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netrom/nr_route.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index fe278fc24153..637a743c060d 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -850,6 +850,7 @@ static void *nr_node_next(struct seq_file *seq, void *v, loff_t *pos)
 }
 
 static void nr_node_stop(struct seq_file *seq, void *v)
+	__releases(&nr_node_list_lock)
 {
 	spin_unlock_bh(&nr_node_list_lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
@ 2020-02-23 23:16     ` Jules Irenge
  2020-02-23 23:16     ` Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller,
	Jakub Kicinski, open list:NETROM NETWORK LAYER,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at nr_neigh_start()
warning: context imbalance in nr_neigh_start() - wrong count at exit
The root cause is the missing annotation at nr_neigh_start()
Add the missing __acquires(&nr_neigh_list_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netrom/nr_route.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index 637a743c060d..33e7b91fc805 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -895,6 +895,7 @@ const struct seq_operations nr_node_seqops = {
 };
 
 static void *nr_neigh_start(struct seq_file *seq, loff_t *pos)
+	__acquires(&nr_neigh_list_lock)
 {
 	spin_lock_bh(&nr_neigh_list_lock);
 	return seq_hlist_start_head(&nr_neigh_list, *pos);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start()
@ 2020-02-23 23:16     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller,
	Jakub Kicinski, open list:NETROM NETWORK LAYER,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at nr_neigh_start()
warning: context imbalance in nr_neigh_start() - wrong count at exit
The root cause is the missing annotation at nr_neigh_start()
Add the missing __acquires(&nr_neigh_list_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netrom/nr_route.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index 637a743c060d..33e7b91fc805 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -895,6 +895,7 @@ const struct seq_operations nr_node_seqops = {
 };
 
 static void *nr_neigh_start(struct seq_file *seq, loff_t *pos)
+	__acquires(&nr_neigh_list_lock)
 {
 	spin_lock_bh(&nr_neigh_list_lock);
 	return seq_hlist_start_head(&nr_neigh_list, *pos);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
@ 2020-02-23 23:16     ` Jules Irenge
  2020-02-23 23:16     ` Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller,
	Jakub Kicinski, open list:NETROM NETWORK LAYER,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at nr_neigh_stop()
warning: context imbalance in nr_neigh_stop() - unexpected unlock
The root cause is the missing annotation at nr_neigh_stop()
Add the missing __releases(&nr_neigh_list_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netrom/nr_route.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index 33e7b91fc805..79f12d8c7b86 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -907,6 +907,7 @@ static void *nr_neigh_next(struct seq_file *seq, void *v, loff_t *pos)
 }
 
 static void nr_neigh_stop(struct seq_file *seq, void *v)
+	__releases(&nr_neigh_list_lock)
 {
 	spin_unlock_bh(&nr_neigh_list_lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop()
@ 2020-02-23 23:16     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Ralf Baechle, David S. Miller,
	Jakub Kicinski, open list:NETROM NETWORK LAYER,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at nr_neigh_stop()
warning: context imbalance in nr_neigh_stop() - unexpected unlock
The root cause is the missing annotation at nr_neigh_stop()
Add the missing __releases(&nr_neigh_list_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/netrom/nr_route.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/netrom/nr_route.c b/net/netrom/nr_route.c
index 33e7b91fc805..79f12d8c7b86 100644
--- a/net/netrom/nr_route.c
+++ b/net/netrom/nr_route.c
@@ -907,6 +907,7 @@ static void *nr_neigh_next(struct seq_file *seq, void *v, loff_t *pos)
 }
 
 static void nr_neigh_stop(struct seq_file *seq, void *v)
+	__releases(&nr_neigh_list_lock)
 {
 	spin_unlock_bh(&nr_neigh_list_lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 14/30] dccp: Add missing annotation for dccp_child_process()
@ 2020-02-23 23:16     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Gerrit Renker, David S. Miller,
	Jakub Kicinski, open list:DCCP PROTOCOL,
	open list:NETWORKING [GENERAL]

Sparse reports a warning at dccp_child_process()
warning: context imbalance in dccp_child_process() - unexpected unlock
The root cause is the missing annotation at dccp_child_process()
Add the missing __releases(child) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/dccp/minisocks.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/dccp/minisocks.c b/net/dccp/minisocks.c
index 25187528c308..c5c74a34d139 100644
--- a/net/dccp/minisocks.c
+++ b/net/dccp/minisocks.c
@@ -216,6 +216,7 @@ EXPORT_SYMBOL_GPL(dccp_check_req);
  */
 int dccp_child_process(struct sock *parent, struct sock *child,
 		       struct sk_buff *skb)
+	__releases(child)
 {
 	int ret = 0;
 	const int state = child->sk_state;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 14/30] dccp: Add missing annotation for dccp_child_process()
@ 2020-02-23 23:16     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: dccp

Sparse reports a warning at dccp_child_process()
warning: context imbalance in dccp_child_process() - unexpected unlock
The root cause is the missing annotation at dccp_child_process()
Add the missing __releases(child) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/dccp/minisocks.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/dccp/minisocks.c b/net/dccp/minisocks.c
index 25187528c308..c5c74a34d139 100644
--- a/net/dccp/minisocks.c
+++ b/net/dccp/minisocks.c
@@ -216,6 +216,7 @@ EXPORT_SYMBOL_GPL(dccp_check_req);
  */
 int dccp_child_process(struct sock *parent, struct sock *child,
 		       struct sk_buff *skb)
+	__releases(child)
 {
 	int ret = 0;
 	const int state = child->sk_state;
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (13 preceding siblings ...)
  2020-02-23 23:16     ` Jules Irenge
@ 2020-02-23 23:16   ` Jules Irenge
  2020-02-24 21:29     ` David Miller
  2020-02-23 23:16   ` [PATCH 16/30] proc: Add missing annotation for close_pdeo() Jules Irenge
                     ` (14 subsequent siblings)
  29 siblings, 1 reply; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, David S. Miller, Jakub Kicinski,
	Allison Randal, Steffen Klassert, Jens Axboe, Hannes Reinecke,
	Kirill Tkhai, Eric Dumazet, Thomas Gleixner, Pankaj Bharadiya,
	Arnd Bergmann, Qian Cai, open list:NETWORKING [GENERAL]

Sparse reports a warning unix_wait_for_peer()

warning: context imbalance in unix_wait_for_peer() - unexpected unlock

The root cause is the missing annotation at unix_wait_for_peer()
Add the missing annotation __releases(&unix_sk(other)->lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 net/unix/af_unix.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 62c12cb5763e..cbd7dc01e147 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -1207,6 +1207,7 @@ static int unix_dgram_connect(struct socket *sock, struct sockaddr *addr,
 }
 
 static long unix_wait_for_peer(struct sock *other, long timeo)
+	__releases(&unix_sk(other)->lock)
 {
 	struct unix_sock *u = unix_sk(other);
 	int sched;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 16/30] proc: Add missing annotation for close_pdeo()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (14 preceding siblings ...)
  2020-02-23 23:16   ` [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() Jules Irenge
@ 2020-02-23 23:16   ` Jules Irenge
  2020-02-23 23:16   ` [PATCH 17/30] mm/zsmalloc: Add missing annotation for zs_map_object() Jules Irenge
                     ` (13 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Alexey Dobriyan, Al Viro,
	Andrew Morton, David Howells, open list:PROC FILESYSTEM

Sparse reports a warning at close_pdeo()
warning: context imbalance in close_pdeo() - unexpected unlock
The root cause is the missing annotation at close_pdeo()
Add the missing __releases(&pde->pde_unload_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 fs/proc/inode.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/proc/inode.c b/fs/proc/inode.c
index 6da18316d209..1f33cb7a6c47 100644
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -139,6 +139,7 @@ static void unuse_pde(struct proc_dir_entry *pde)
 
 /* pde is locked on entry, unlocked on exit */
 static void close_pdeo(struct proc_dir_entry *pde, struct pde_opener *pdeo)
+	__releases(&pde->pde_unload_lock)
 {
 	/*
 	 * close() (proc_reg_release()) can't delete an entry and proceed:
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 17/30] mm/zsmalloc: Add missing annotation for zs_map_object()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (15 preceding siblings ...)
  2020-02-23 23:16   ` [PATCH 16/30] proc: Add missing annotation for close_pdeo() Jules Irenge
@ 2020-02-23 23:16   ` Jules Irenge
  2020-02-23 23:16   ` [PATCH 18/30] mm/zsmalloc: Add missing annotation for zs_unmap_object() Jules Irenge
                     ` (12 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Minchan Kim, Nitin Gupta,
	Sergey Senozhatsky, Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

Sparse reports a warning at zs_map_object()
context imbalance in zs_map_object() - wrong count at exit
The root cause is the missing annotation at zs_map_object()
Add the missing __acquires(zspage)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/zsmalloc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 2aa2d524a343..9d3f9b3d22aa 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1290,6 +1290,7 @@ EXPORT_SYMBOL_GPL(zs_get_total_pages);
  */
 void *zs_map_object(struct zs_pool *pool, unsigned long handle,
 			enum zs_mapmode mm)
+	__acquires(zspage)
 {
 	struct zspage *zspage;
 	struct page *page;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 18/30] mm/zsmalloc: Add missing annotation for zs_unmap_object()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (16 preceding siblings ...)
  2020-02-23 23:16   ` [PATCH 17/30] mm/zsmalloc: Add missing annotation for zs_map_object() Jules Irenge
@ 2020-02-23 23:16   ` Jules Irenge
  2020-02-23 23:17   ` [PATCH 19/30] mm/zsmalloc: Add missing annotation for migrate_write_lock() Jules Irenge
                     ` (11 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:16 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Minchan Kim, Nitin Gupta,
	Sergey Senozhatsky, Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

Sparse reports a warning at zs_unmap_object()
context imbalance in zs_unmap_object() - unexpected unlock
The root cause is the missing annotation at zs_unmap_object()
Add the missing __releases(zspage)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/zsmalloc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 9d3f9b3d22aa..10a96651cb97 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1349,6 +1349,7 @@ void *zs_map_object(struct zs_pool *pool, unsigned long handle,
 EXPORT_SYMBOL_GPL(zs_map_object);
 
 void zs_unmap_object(struct zs_pool *pool, unsigned long handle)
+	__releases(zspage)
 {
 	struct zspage *zspage;
 	struct page *page;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 19/30] mm/zsmalloc: Add missing annotation for migrate_write_lock()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (17 preceding siblings ...)
  2020-02-23 23:16   ` [PATCH 18/30] mm/zsmalloc: Add missing annotation for zs_unmap_object() Jules Irenge
@ 2020-02-23 23:17   ` Jules Irenge
  2020-02-23 23:17   ` [PATCH 20/30] mm/zsmalloc: Add missing annotation for migrate_write_unlock() Jules Irenge
                     ` (10 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Minchan Kim, Nitin Gupta,
	Sergey Senozhatsky, Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

Sparse reports a warning at migrate_write_lock()
warning: context imbalance in migrate_write_lock() - wrong count at exit
The root cause is the missing annotation at migrate_write_lock()
Add the missing __acquires(&zspage->lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/zsmalloc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 10a96651cb97..7ec69a1140cf 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1846,6 +1846,7 @@ static void migrate_read_unlock(struct zspage *zspage) __releases(&zspage->lock)
 }
 
 static void migrate_write_lock(struct zspage *zspage)
+	__acquires(&zspage->lock)
 {
 	write_lock(&zspage->lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 20/30] mm/zsmalloc: Add missing annotation for migrate_write_unlock()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (18 preceding siblings ...)
  2020-02-23 23:17   ` [PATCH 19/30] mm/zsmalloc: Add missing annotation for migrate_write_lock() Jules Irenge
@ 2020-02-23 23:17   ` Jules Irenge
  2020-02-23 23:17   ` [PATCH 21/30] scsi: csiostor: Add missing annotation for csio_scsi_cleanup_io_q() Jules Irenge
                     ` (9 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Minchan Kim, Nitin Gupta,
	Sergey Senozhatsky, Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

Sparse reports a warning at migrate_write_unlock()
warning: context imbalance in migrate_write_unlock() - unexpected unlock
The root cause is the missing annotation at migrate_write_unlock()
Add the missing __releases(&zspage->lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 mm/zsmalloc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 7ec69a1140cf..cb5541d06823 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -1852,6 +1852,7 @@ static void migrate_write_lock(struct zspage *zspage)
 }
 
 static void migrate_write_unlock(struct zspage *zspage)
+	__releases(&zspage->lock)
 {
 	write_unlock(&zspage->lock);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 21/30] scsi: csiostor: Add missing annotation for csio_scsi_cleanup_io_q()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (19 preceding siblings ...)
  2020-02-23 23:17   ` [PATCH 20/30] mm/zsmalloc: Add missing annotation for migrate_write_unlock() Jules Irenge
@ 2020-02-23 23:17   ` Jules Irenge
  2020-02-23 23:17   ` [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock() Jules Irenge
                     ` (8 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, James E.J. Bottomley,
	Martin K. Petersen, Nathan Chancellor, Varun Prakash,
	Hannes Reinecke, open list:SCSI SUBSYSTEM

Sparse reports a warning at csio_scsi_cleanup_io_q()

warning: context imbalance in csio_scsi_cleanup_io_q() - unexpected unlock

The root cause is the missing annotation at csio_scsi_cleanup_io_q()
Add the missing __must_hold(&hw->lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/scsi/csiostor/csio_scsi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c
index 00cf33573136..77cba766ae52 100644
--- a/drivers/scsi/csiostor/csio_scsi.c
+++ b/drivers/scsi/csiostor/csio_scsi.c
@@ -1157,6 +1157,7 @@ csio_scsi_cmpl_handler(struct csio_hw *hw, void *wr, uint32_t len,
  */
 void
 csio_scsi_cleanup_io_q(struct csio_scsim *scm, struct list_head *q)
+	__must_hold(&hw->lock)
 {
 	struct csio_hw *hw = scm->hw;
 	struct csio_ioreq *ioreq;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (20 preceding siblings ...)
  2020-02-23 23:17   ` [PATCH 21/30] scsi: csiostor: Add missing annotation for csio_scsi_cleanup_io_q() Jules Irenge
@ 2020-02-23 23:17   ` Jules Irenge
  2020-03-04 11:00     ` Rafael J. Wysocki
  2020-02-23 23:17   ` [PATCH 23/30] ACPI: OSL: Add missing annotation for acpi_os_release_lock() Jules Irenge
                     ` (7 subsequent siblings)
  29 siblings, 1 reply; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Rafael J. Wysocki, Len Brown, open list:ACPI

Sparse reports a warning at acpi_os_acquire_lock()

warning: context imbalance in acpi_os_acquire_lock() - unexpected unlock

The root cause is the missing annotation at acpi_os_acquire_lock()
Add the missing annotation __acquires(lockp)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/acpi/osl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 41168c027a5a..7094abc5ffc6 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1598,6 +1598,7 @@ void acpi_os_delete_lock(acpi_spinlock handle)
  */
 
 acpi_cpu_flags acpi_os_acquire_lock(acpi_spinlock lockp)
+	__acquires(lockp)
 {
 	acpi_cpu_flags flags;
 	spin_lock_irqsave(lockp, flags);
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 23/30] ACPI: OSL: Add missing annotation for acpi_os_release_lock()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (21 preceding siblings ...)
  2020-02-23 23:17   ` [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock() Jules Irenge
@ 2020-02-23 23:17   ` Jules Irenge
  2020-02-23 23:17   ` [PATCH 24/30] dmaengine: mic_x100_dma: Add missing annotation for mic_dma_tx_submit_unlock() Jules Irenge
                     ` (6 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Rafael J. Wysocki, Len Brown, open list:ACPI

Sparse reports a warning at acpi_os_release_lock()

warning: context imbalance in acpi_os_release_lock() - unexpected unlock

The root cause is the missing annotation at acpi_os_release_lock()
Add the missing annotation __releases(lockp)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/acpi/osl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 7094abc5ffc6..762c5d50b8fe 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1610,6 +1610,7 @@ acpi_cpu_flags acpi_os_acquire_lock(acpi_spinlock lockp)
  */
 
 void acpi_os_release_lock(acpi_spinlock lockp, acpi_cpu_flags flags)
+	__releases(lockp)
 {
 	spin_unlock_irqrestore(lockp, flags);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 24/30] dmaengine: mic_x100_dma: Add missing annotation for mic_dma_tx_submit_unlock()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (22 preceding siblings ...)
  2020-02-23 23:17   ` [PATCH 23/30] ACPI: OSL: Add missing annotation for acpi_os_release_lock() Jules Irenge
@ 2020-02-23 23:17   ` Jules Irenge
  2020-02-23 23:17   ` [PATCH 25/30] zram: Add missing annotatin for zram_slot_lock() Jules Irenge
                     ` (5 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Sudeep Dutt, Ashutosh Dixit,
	Vinod Koul, Dan Williams,
	open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM

Sparse reports a warning dma_cookie_t mic_dma_tx_submit_unlock()

warning: context imbalance in  mic_dma_tx_submit_unlock()
	- unexpected unlock

The root cause is the missing annotation at  mic_dma_tx_submit_unlock()
Add the missing annotation __releases(&mic_ch->prep_lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/dma/mic_x100_dma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c
index fea8608a7810..d15c41151d09 100644
--- a/drivers/dma/mic_x100_dma.c
+++ b/drivers/dma/mic_x100_dma.c
@@ -236,6 +236,7 @@ static inline void mic_dma_update_pending(struct mic_dma_chan *ch)
 }
 
 static dma_cookie_t mic_dma_tx_submit_unlock(struct dma_async_tx_descriptor *tx)
+	__releases(&mic_ch->prep_lock)
 {
 	struct mic_dma_chan *mic_ch = to_mic_dma_chan(tx->chan);
 	dma_cookie_t cookie;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 25/30] zram: Add missing annotatin for zram_slot_lock()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (23 preceding siblings ...)
  2020-02-23 23:17   ` [PATCH 24/30] dmaengine: mic_x100_dma: Add missing annotation for mic_dma_tx_submit_unlock() Jules Irenge
@ 2020-02-23 23:17   ` Jules Irenge
  2020-02-23 23:17   ` [PATCH 26/30] zram: Add missing annotatin for zram_slot_unlock() Jules Irenge
                     ` (4 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Minchan Kim, Nitin Gupta,
	Sergey Senozhatsky, Jens Axboe, open list:BLOCK LAYER

Sparse reports a warning at zram_slot_lock()
warning: context imbalance in zram_slot_lock() - wrong count at exit
The root cause is the missing annotation at zram_slot_lock()
Add the missing  __acquires(ZRAM_LOCK) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/block/zram/zram_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 1bdb5793842b..1462b1bfec11 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -62,6 +62,7 @@ static int zram_slot_trylock(struct zram *zram, u32 index)
 }
 
 static void zram_slot_lock(struct zram *zram, u32 index)
+	__acquires(ZRAM_LOCK)
 {
 	bit_spin_lock(ZRAM_LOCK, &zram->table[index].flags);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 26/30] zram: Add missing annotatin for zram_slot_unlock()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (24 preceding siblings ...)
  2020-02-23 23:17   ` [PATCH 25/30] zram: Add missing annotatin for zram_slot_lock() Jules Irenge
@ 2020-02-23 23:17   ` Jules Irenge
  2020-02-23 23:17   ` [PATCH 27/30] habanalabs: Add missing annotation for goya_hw_queues_lock() Jules Irenge
                     ` (3 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Minchan Kim, Nitin Gupta,
	Sergey Senozhatsky, Jens Axboe, open list:BLOCK LAYER

Sparse reports a warning at zram_slot_unlock()
warning: context imbalance in zram_slot_unlock() - unexpected unlock
The root cause is the missing annotation at zram_slot_unlock()
Add the missing  __releases(ZRAM_LOCK) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/block/zram/zram_drv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 1462b1bfec11..a38725452966 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -68,6 +68,7 @@ static void zram_slot_lock(struct zram *zram, u32 index)
 }
 
 static void zram_slot_unlock(struct zram *zram, u32 index)
+	__releases(ZRAM_LOCK)
 {
 	bit_spin_unlock(ZRAM_LOCK, &zram->table[index].flags);
 }
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 27/30] habanalabs: Add missing annotation for goya_hw_queues_lock()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (25 preceding siblings ...)
  2020-02-23 23:17   ` [PATCH 26/30] zram: Add missing annotatin for zram_slot_unlock() Jules Irenge
@ 2020-02-23 23:17   ` Jules Irenge
  2020-02-25 11:55     ` Oded Gabbay
  2020-02-23 23:17   ` [PATCH 28/30] habanalabs: Add missing annotation for goya_hw_queues_unlock() Jules Irenge
                     ` (2 subsequent siblings)
  29 siblings, 1 reply; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Oded Gabbay, Arnd Bergmann,
	Greg Kroah-Hartman, Tomer Tayar, Omer Shpigelman, Dalit Ben Zoor

Sparse reports a warning at goya_hw_queues_lock()
warning: context imbalance in goya_hw_queues_lock() - wrong count at exit
The root cause is a missing annotation at goya_hw_queues_lock()
Add the missing __acquires(&goya->hw_queues_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/misc/habanalabs/goya/goya.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
index 7344e8a222ae..8ca7ee57cbc1 100644
--- a/drivers/misc/habanalabs/goya/goya.c
+++ b/drivers/misc/habanalabs/goya/goya.c
@@ -5073,6 +5073,7 @@ static bool goya_is_device_idle(struct hl_device *hdev, u32 *mask,
 }
 
 static void goya_hw_queues_lock(struct hl_device *hdev)
+	__acquires(&goya->hw_queues_lock)
 {
 	struct goya_device *goya = hdev->asic_specific;
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 28/30] habanalabs: Add missing annotation for goya_hw_queues_unlock()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (26 preceding siblings ...)
  2020-02-23 23:17   ` [PATCH 27/30] habanalabs: Add missing annotation for goya_hw_queues_lock() Jules Irenge
@ 2020-02-23 23:17   ` Jules Irenge
  2020-02-25 11:56     ` Oded Gabbay
  2020-02-23 23:17   ` [PATCH 29/30] sgi-xp: Add missing annotation for xpc_disconnect_channel() Jules Irenge
  2020-02-23 23:17     ` [Ocfs2-devel] " Jules Irenge
  29 siblings, 1 reply; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Oded Gabbay, Arnd Bergmann,
	Greg Kroah-Hartman, Tomer Tayar, Omer Shpigelman, Dalit Ben Zoor

Sparse reports a warning at goya_hw_queues_unlock()
warning: context imbalance in goya_hw_queues_unlock() - unexpected unlock
The root cause is a missing annotation at goya_hw_queues_unlock()
Add the missing __releases(&goya->hw_queues_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/misc/habanalabs/goya/goya.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
index 8ca7ee57cbc1..6138b461d0f8 100644
--- a/drivers/misc/habanalabs/goya/goya.c
+++ b/drivers/misc/habanalabs/goya/goya.c
@@ -5081,6 +5081,7 @@ static void goya_hw_queues_lock(struct hl_device *hdev)
 }
 
 static void goya_hw_queues_unlock(struct hl_device *hdev)
+	__releases(&goya->hw_queues_lock)
 {
 	struct goya_device *goya = hdev->asic_specific;
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 29/30] sgi-xp: Add missing annotation for xpc_disconnect_channel()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
                     ` (27 preceding siblings ...)
  2020-02-23 23:17   ` [PATCH 28/30] habanalabs: Add missing annotation for goya_hw_queues_unlock() Jules Irenge
@ 2020-02-23 23:17   ` Jules Irenge
  2020-02-28 19:22     ` Robin Holt
  2020-02-23 23:17     ` [Ocfs2-devel] " Jules Irenge
  29 siblings, 1 reply; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Cliff Whickman, Robin Holt,
	Arnd Bergmann, Greg Kroah-Hartman

Sparse reports a warning at xpc_disconnect_channel()
warning: context imbalance in xpc_disconnect_channel() - unexpected unlock
The root cause is a missing annotation at xpc_disconnect_channel()
Add the missing __must_hold(&ch->lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/misc/sgi-xp/xpc_channel.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/sgi-xp/xpc_channel.c b/drivers/misc/sgi-xp/xpc_channel.c
index 8e6607fc8a67..a1e92488e9bc 100644
--- a/drivers/misc/sgi-xp/xpc_channel.c
+++ b/drivers/misc/sgi-xp/xpc_channel.c
@@ -752,6 +752,7 @@ xpc_initiate_disconnect(int ch_number)
 void
 xpc_disconnect_channel(const int line, struct xpc_channel *ch,
 		       enum xp_retval reason, unsigned long *irq_flags)
+	__must_hold(&ch->lock)
 {
 	u32 channel_was_connected = (ch->flags & XPC_C_CONNECTED);
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [PATCH 30/30] sgi-xp: Add missing annotation for ocfs2_inode_cache_lock() and ocfs2_inode_cache_unlock()
  2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
@ 2020-02-23 23:17     ` Jules Irenge
  2020-02-23 23:16     ` Jules Irenge
                       ` (28 subsequent siblings)
  29 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Mark Fasheh, Joel Becker, Joseph Qi,
	moderated list:ORACLE CLUSTER FILESYSTEM 2 (OCFS2)

Sparse reports a warning at ocfs2_inode_cache_lock()
and ocfs2_inode_cache_unlock()
warning: context imbalance in ocfs2_inode_cache_lock()
	- wrong count at exit

warning: context imbalance in ocfs2_inode_cache_unlock()
	- unexpected unlock
The root cause is a missing annotation at ocfs2_inode_cache_lock()
and at ocfs2_inode_cache_unlock()

Add the missing __acquires(&oi->ip_lock) annotation
Add the missing __releases(&oi->ip_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 fs/ocfs2/inode.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 7c9dfd50c1c1..0b87e0a63ab9 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -1623,6 +1623,7 @@ static struct super_block *ocfs2_inode_cache_get_super(struct ocfs2_caching_info
 }
 
 static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci)
+	__acquires(&oi->ip_lock)
 {
 	struct ocfs2_inode_info *oi = cache_info_to_inode(ci);
 
@@ -1630,6 +1631,7 @@ static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci)
 }
 
 static void ocfs2_inode_cache_unlock(struct ocfs2_caching_info *ci)
+	__releases(&oi->ip_lock)
 {
 	struct ocfs2_inode_info *oi = cache_info_to_inode(ci);
 
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 125+ messages in thread

* [Ocfs2-devel] [PATCH 30/30] sgi-xp: Add missing annotation for ocfs2_inode_cache_lock() and ocfs2_inode_cache_unlock()
@ 2020-02-23 23:17     ` Jules Irenge
  0 siblings, 0 replies; 125+ messages in thread
From: Jules Irenge @ 2020-02-23 23:17 UTC (permalink / raw)
  To: boqun.feng
  Cc: jbi.octave, linux-kernel, Mark Fasheh, Joel Becker, Joseph Qi,
	moderated list:ORACLE CLUSTER FILESYSTEM 2 OCFS2

Sparse reports a warning at ocfs2_inode_cache_lock()
and ocfs2_inode_cache_unlock()
warning: context imbalance in ocfs2_inode_cache_lock()
	- wrong count at exit

warning: context imbalance in ocfs2_inode_cache_unlock()
	- unexpected unlock
The root cause is a missing annotation at ocfs2_inode_cache_lock()
and at ocfs2_inode_cache_unlock()

Add the missing __acquires(&oi->ip_lock) annotation
Add the missing __releases(&oi->ip_lock) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 fs/ocfs2/inode.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
index 7c9dfd50c1c1..0b87e0a63ab9 100644
--- a/fs/ocfs2/inode.c
+++ b/fs/ocfs2/inode.c
@@ -1623,6 +1623,7 @@ static struct super_block *ocfs2_inode_cache_get_super(struct ocfs2_caching_info
 }
 
 static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci)
+	__acquires(&oi->ip_lock)
 {
 	struct ocfs2_inode_info *oi = cache_info_to_inode(ci);
 
@@ -1630,6 +1631,7 @@ static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci)
 }
 
 static void ocfs2_inode_cache_unlock(struct ocfs2_caching_info *ci)
+	__releases(&oi->ip_lock)
 {
 	struct ocfs2_inode_info *oi = cache_info_to_inode(ci);
 
-- 
2.24.1

^ permalink raw reply related	[flat|nested] 125+ messages in thread

* Re: [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer()
  2020-02-23 23:16   ` [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() Jules Irenge
@ 2020-02-23 23:27     ` Nikolay Borisov
  2020-02-24 15:19     ` David Sterba
  1 sibling, 0 replies; 125+ messages in thread
From: Nikolay Borisov @ 2020-02-23 23:27 UTC (permalink / raw)
  To: Jules Irenge, boqun.feng
  Cc: linux-kernel, Chris Mason, Josef Bacik, David Sterba,
	open list:BTRFS FILE SYSTEM



On 24.02.20 г. 1:16 ч., Jules Irenge wrote:
> Sparse reports a warning at release_extent_buffer()
> warning: context imbalance in release_extent_buffer() - unexpected unlock
> 
> The root cause is the missing annotation at release_extent_buffer()
> Add the missing __releases(&eb->refs_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

 Reviewed-by: Nikolay Borisov <nborisov@suse.com>

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 02/30] dax: Add missing annotations ofr dax_read_lock() and dax_read_unlock()
  2020-02-23 23:16     ` Jules Irenge
@ 2020-02-24  1:23       ` Yi Zhang
  -1 siblings, 0 replies; 125+ messages in thread
From: Yi Zhang @ 2020-02-24  1:23 UTC (permalink / raw)
  To: Jules Irenge, boqun.feng; +Cc: linux-kernel, open list:DEVICE DIRECT ACCESS DAX



On 2/24/20 7:16 AM, Jules Irenge wrote:
> Sparse reports warning at dax_read_lock() and at dax_read_unlock()
>
> warning: context imbalance in dax_read_lock() - wrong count at exit
>   warning: context imbalance in dax_read_unlock() - unexpected unlock
>
> The root cause is the mnissing annotations at dax_read_lock()
> 	and dax_read_unlock()
s/mnissing/missing
> Add the missing __acquires(&dax_srcu) notations to dax_read_lock()
> Add the missing __releases(&dax_srcu) annotation to dax_read_unlock()
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>   drivers/dax/super.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dax/super.c b/drivers/dax/super.c
> index 26a654dbc69a..f872a2fb98d4 100644
> --- a/drivers/dax/super.c
> +++ b/drivers/dax/super.c
> @@ -28,13 +28,13 @@ static struct super_block *dax_superblock __read_mostly;
>   static struct hlist_head dax_host_list[DAX_HASH_SIZE];
>   static DEFINE_SPINLOCK(dax_host_lock);
>   
> -int dax_read_lock(void)
> +int dax_read_lock(void) __acquires(&dax_srcu)
>   {
>   	return srcu_read_lock(&dax_srcu);
>   }
>   EXPORT_SYMBOL_GPL(dax_read_lock);
>   
> -void dax_read_unlock(int id)
> +void dax_read_unlock(int id) __releases(&dax_srcu)
>   {
>   	srcu_read_unlock(&dax_srcu, id);
>   }
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 02/30] dax: Add missing annotations ofr dax_read_lock() and dax_read_unlock()
@ 2020-02-24  1:23       ` Yi Zhang
  0 siblings, 0 replies; 125+ messages in thread
From: Yi Zhang @ 2020-02-24  1:23 UTC (permalink / raw)
  To: Jules Irenge, boqun.feng; +Cc: linux-kernel, open list:DEVICE DIRECT ACCESS DAX



On 2/24/20 7:16 AM, Jules Irenge wrote:
> Sparse reports warning at dax_read_lock() and at dax_read_unlock()
>
> warning: context imbalance in dax_read_lock() - wrong count at exit
>   warning: context imbalance in dax_read_unlock() - unexpected unlock
>
> The root cause is the mnissing annotations at dax_read_lock()
> 	and dax_read_unlock()
s/mnissing/missing
> Add the missing __acquires(&dax_srcu) notations to dax_read_lock()
> Add the missing __releases(&dax_srcu) annotation to dax_read_unlock()
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>   drivers/dax/super.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dax/super.c b/drivers/dax/super.c
> index 26a654dbc69a..f872a2fb98d4 100644
> --- a/drivers/dax/super.c
> +++ b/drivers/dax/super.c
> @@ -28,13 +28,13 @@ static struct super_block *dax_superblock __read_mostly;
>   static struct hlist_head dax_host_list[DAX_HASH_SIZE];
>   static DEFINE_SPINLOCK(dax_host_lock);
>   
> -int dax_read_lock(void)
> +int dax_read_lock(void) __acquires(&dax_srcu)
>   {
>   	return srcu_read_lock(&dax_srcu);
>   }
>   EXPORT_SYMBOL_GPL(dax_read_lock);
>   
> -void dax_read_unlock(int id)
> +void dax_read_unlock(int id) __releases(&dax_srcu)
>   {
>   	srcu_read_unlock(&dax_srcu, id);
>   }


^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 30/30] sgi-xp: Add missing annotation for ocfs2_inode_cache_lock() and ocfs2_inode_cache_unlock()
  2020-02-23 23:17     ` [Ocfs2-devel] " Jules Irenge
@ 2020-02-24  1:52       ` Joseph Qi
  -1 siblings, 0 replies; 125+ messages in thread
From: Joseph Qi @ 2020-02-24  1:52 UTC (permalink / raw)
  To: Jules Irenge, boqun.feng
  Cc: linux-kernel, Mark Fasheh, Joel Becker,
	moderated list:ORACLE CLUSTER FILESYSTEM 2 (OCFS2),
	Andrew Morton



On 2020/2/24 07:17, Jules Irenge wrote:
> Sparse reports a warning at ocfs2_inode_cache_lock()
> and ocfs2_inode_cache_unlock()
> warning: context imbalance in ocfs2_inode_cache_lock()
> 	- wrong count at exit
> 
> warning: context imbalance in ocfs2_inode_cache_unlock()
> 	- unexpected unlock
> The root cause is a missing annotation at ocfs2_inode_cache_lock()
> and at ocfs2_inode_cache_unlock()
> 
> Add the missing __acquires(&oi->ip_lock) annotation
> Add the missing __releases(&oi->ip_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Looks good.
BTW, there are another co_cache_[lock|unlock] implementations also
miss the annotations:
ocfs2_refcount_cache_lock
ocfs2_refcount_cache_unlock
So could we add the missing annotations as well?

Thanks,
Joseph

> ---
>  fs/ocfs2/inode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
> index 7c9dfd50c1c1..0b87e0a63ab9 100644
> --- a/fs/ocfs2/inode.c
> +++ b/fs/ocfs2/inode.c
> @@ -1623,6 +1623,7 @@ static struct super_block *ocfs2_inode_cache_get_super(struct ocfs2_caching_info
>  }
>  
>  static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci)
> +	__acquires(&oi->ip_lock)
>  {
>  	struct ocfs2_inode_info *oi = cache_info_to_inode(ci);
>  
> @@ -1630,6 +1631,7 @@ static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci)
>  }
>  
>  static void ocfs2_inode_cache_unlock(struct ocfs2_caching_info *ci)
> +	__releases(&oi->ip_lock)
>  {
>  	struct ocfs2_inode_info *oi = cache_info_to_inode(ci);
>  
> 

^ permalink raw reply	[flat|nested] 125+ messages in thread

* [Ocfs2-devel] [PATCH 30/30] sgi-xp: Add missing annotation for ocfs2_inode_cache_lock() and ocfs2_inode_cache_unlock()
@ 2020-02-24  1:52       ` Joseph Qi
  0 siblings, 0 replies; 125+ messages in thread
From: Joseph Qi @ 2020-02-24  1:52 UTC (permalink / raw)
  To: Jules Irenge, boqun.feng
  Cc: linux-kernel, Mark Fasheh, Joel Becker,
	moderated list:ORACLE CLUSTER FILESYSTEM 2 (OCFS2),
	Andrew Morton



On 2020/2/24 07:17, Jules Irenge wrote:
> Sparse reports a warning at ocfs2_inode_cache_lock()
> and ocfs2_inode_cache_unlock()
> warning: context imbalance in ocfs2_inode_cache_lock()
> 	- wrong count at exit
> 
> warning: context imbalance in ocfs2_inode_cache_unlock()
> 	- unexpected unlock
> The root cause is a missing annotation at ocfs2_inode_cache_lock()
> and at ocfs2_inode_cache_unlock()
> 
> Add the missing __acquires(&oi->ip_lock) annotation
> Add the missing __releases(&oi->ip_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Looks good.
BTW, there are another co_cache_[lock|unlock] implementations also
miss the annotations:
ocfs2_refcount_cache_lock
ocfs2_refcount_cache_unlock
So could we add the missing annotations as well?

Thanks,
Joseph

> ---
>  fs/ocfs2/inode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
> index 7c9dfd50c1c1..0b87e0a63ab9 100644
> --- a/fs/ocfs2/inode.c
> +++ b/fs/ocfs2/inode.c
> @@ -1623,6 +1623,7 @@ static struct super_block *ocfs2_inode_cache_get_super(struct ocfs2_caching_info
>  }
>  
>  static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci)
> +	__acquires(&oi->ip_lock)
>  {
>  	struct ocfs2_inode_info *oi = cache_info_to_inode(ci);
>  
> @@ -1630,6 +1631,7 @@ static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci)
>  }
>  
>  static void ocfs2_inode_cache_unlock(struct ocfs2_caching_info *ci)
> +	__releases(&oi->ip_lock)
>  {
>  	struct ocfs2_inode_info *oi = cache_info_to_inode(ci);
>  
> 

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer()
  2020-02-23 23:16   ` [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() Jules Irenge
  2020-02-23 23:27     ` Nikolay Borisov
@ 2020-02-24 15:19     ` David Sterba
  1 sibling, 0 replies; 125+ messages in thread
From: David Sterba @ 2020-02-24 15:19 UTC (permalink / raw)
  To: Jules Irenge
  Cc: boqun.feng, linux-kernel, Chris Mason, Josef Bacik, David Sterba,
	open list:BTRFS FILE SYSTEM

On Sun, Feb 23, 2020 at 11:16:42PM +0000, Jules Irenge wrote:
> Sparse reports a warning at release_extent_buffer()
> warning: context imbalance in release_extent_buffer() - unexpected unlock
> 
> The root cause is the missing annotation at release_extent_buffer()
> Add the missing __releases(&eb->refs_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Added to misc-next, thanks.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish()
  2020-02-23 23:16     ` Jules Irenge
@ 2020-02-24 21:28       ` David Miller
  -1 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:28 UTC (permalink / raw)
  To: jbi.octave
  Cc: boqun.feng, linux-kernel, vyasevich, nhorman, marcelo.leitner,
	kuba, linux-sctp, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:45 +0000

> Sparse reports a warning at sctp_err_finish()
> warning: context imbalance in sctp_err_finish() - unexpected unlock
> 
> The root cause is a missing annotation at sctp_err_finish()
> Add the missing  __releases(&((__sk)->sk_lock.slock)) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish()
@ 2020-02-24 21:28       ` David Miller
  0 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:28 UTC (permalink / raw)
  To: jbi.octave
  Cc: boqun.feng, linux-kernel, vyasevich, nhorman, marcelo.leitner,
	kuba, linux-sctp, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:45 +0000

> Sparse reports a warning at sctp_err_finish()
> warning: context imbalance in sctp_err_finish() - unexpected unlock
> 
> The root cause is a missing annotation at sctp_err_finish()
> Add the missing  __releases(&((__sk)->sk_lock.slock)) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start()
  2020-02-23 23:16     ` Jules Irenge
@ 2020-02-24 21:28       ` David Miller
  -1 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:28 UTC (permalink / raw)
  To: jbi.octave
  Cc: boqun.feng, linux-kernel, vyasevich, nhorman, marcelo.leitner,
	kuba, linux-sctp, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:46 +0000

> Sparse reports a warning at sctp_transport_walk_start()
> 
> warning: context imbalance in sctp_transport_walk_start
> 	- wrong count at exit
> 
> The root cause is the missing annotation at sctp_transport_walk_start()
> Add the missing __acquires(RCU) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start()
@ 2020-02-24 21:28       ` David Miller
  0 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:28 UTC (permalink / raw)
  To: jbi.octave
  Cc: boqun.feng, linux-kernel, vyasevich, nhorman, marcelo.leitner,
	kuba, linux-sctp, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:46 +0000

> Sparse reports a warning at sctp_transport_walk_start()
> 
> warning: context imbalance in sctp_transport_walk_start
> 	- wrong count at exit
> 
> The root cause is the missing annotation at sctp_transport_walk_start()
> Add the missing __acquires(RCU) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop()
  2020-02-23 23:16     ` Jules Irenge
@ 2020-02-24 21:28       ` David Miller
  -1 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:28 UTC (permalink / raw)
  To: jbi.octave
  Cc: boqun.feng, linux-kernel, vyasevich, nhorman, marcelo.leitner,
	kuba, linux-sctp, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:47 +0000

> Sparse reports a warning at sctp_transport_walk_stop()
> 
> warning: context imbalance in sctp_transport_walk_stop
> 	- wrong count at exit
> 
> The root cause is the missing annotation at sctp_transport_walk_stop()
> Add the missing __releases(RCU) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop()
@ 2020-02-24 21:28       ` David Miller
  0 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:28 UTC (permalink / raw)
  To: jbi.octave
  Cc: boqun.feng, linux-kernel, vyasevich, nhorman, marcelo.leitner,
	kuba, linux-sctp, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:47 +0000

> Sparse reports a warning at sctp_transport_walk_stop()
> 
> warning: context imbalance in sctp_transport_walk_stop
> 	- wrong count at exit
> 
> The root cause is the missing annotation at sctp_transport_walk_stop()
> Add the missing __releases(RCU) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 07/30] net: Add missing annotation for llc_seq_start()
  2020-02-23 23:16   ` [PATCH 07/30] net: Add missing annotation for llc_seq_start() Jules Irenge
@ 2020-02-24 21:28     ` David Miller
  0 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:28 UTC (permalink / raw)
  To: jbi.octave; +Cc: boqun.feng, linux-kernel, kuba, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:48 +0000

> Sparse reports a warning at llc_seq_start()
> 
> warning: context imbalance in llc_seq_start() - wrong count at exit
> The root cause is the msiing annotation at llc_seq_start()
> 
> Add the missing __acquires(RCU) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 08/30] netrom: Add missing annotation for nr_info_start()
  2020-02-23 23:16     ` Jules Irenge
  (?)
@ 2020-02-24 21:29     ` David Miller
  -1 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw)
  To: jbi.octave; +Cc: boqun.feng, linux-kernel, ralf, kuba, linux-hams, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:49 +0000

> Sparse reports a warning at nr_info_start()
> warning: context imbalance in nr_info_start() - wrong count at exit
> The root cause is the missing annotation at nr_info_start()
> Add the missing __acquires(&nr_list_lock)
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 09/30] netrom: Add missing annotation for nr_info_stop()
  2020-02-23 23:16     ` Jules Irenge
  (?)
@ 2020-02-24 21:29     ` David Miller
  -1 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw)
  To: jbi.octave; +Cc: boqun.feng, linux-kernel, ralf, kuba, linux-hams, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:50 +0000

> Sparse reports a warning at nr_info_stop()
> warning: context imbalance in nr_info_stop() - unexpected unlock
> The root cause is the missing annotation at nr_info_stop()
> Add the missing __releases(&nr_list_lock)
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start()
  2020-02-23 23:16     ` Jules Irenge
  (?)
@ 2020-02-24 21:29     ` David Miller
  -1 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw)
  To: jbi.octave; +Cc: boqun.feng, linux-kernel, ralf, kuba, linux-hams, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:51 +0000

> Sparse reports a warning at nr_node_start()
> warning: context imbalance in nr_node_start() - wrong count at exit
> The root cause is the missing annotation at nr_node_start()
> Add the missing __acquires(&nr_node_list_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop()
  2020-02-23 23:16     ` Jules Irenge
  (?)
@ 2020-02-24 21:29     ` David Miller
  -1 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw)
  To: jbi.octave; +Cc: boqun.feng, linux-kernel, ralf, kuba, linux-hams, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:52 +0000

> Sparse reports a warning at nr_node_stop()
> warning: context imbalance in nr_node_stop() - wrong count at exit
> The root cause is the missing annotation at nr_node_stop()
> Add the missing __releases(&nr_node_list_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start()
  2020-02-23 23:16     ` Jules Irenge
  (?)
@ 2020-02-24 21:29     ` David Miller
  -1 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw)
  To: jbi.octave; +Cc: boqun.feng, linux-kernel, ralf, kuba, linux-hams, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:53 +0000

> Sparse reports a warning at nr_neigh_start()
> warning: context imbalance in nr_neigh_start() - wrong count at exit
> The root cause is the missing annotation at nr_neigh_start()
> Add the missing __acquires(&nr_neigh_list_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop()
  2020-02-23 23:16     ` Jules Irenge
  (?)
@ 2020-02-24 21:29     ` David Miller
  -1 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw)
  To: jbi.octave; +Cc: boqun.feng, linux-kernel, ralf, kuba, linux-hams, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:54 +0000

> Sparse reports a warning at nr_neigh_stop()
> warning: context imbalance in nr_neigh_stop() - unexpected unlock
> The root cause is the missing annotation at nr_neigh_stop()
> Add the missing __releases(&nr_neigh_list_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 14/30] dccp: Add missing annotation for dccp_child_process()
  2020-02-23 23:16     ` Jules Irenge
@ 2020-02-24 21:29       ` David Miller
  -1 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw)
  To: jbi.octave; +Cc: boqun.feng, linux-kernel, gerrit, kuba, dccp, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:55 +0000

> Sparse reports a warning at dccp_child_process()
> warning: context imbalance in dccp_child_process() - unexpected unlock
> The root cause is the missing annotation at dccp_child_process()
> Add the missing __releases(child) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 14/30] dccp: Add missing annotation for dccp_child_process()
@ 2020-02-24 21:29       ` David Miller
  0 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw)
  To: dccp

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:55 +0000

> Sparse reports a warning at dccp_child_process()
> warning: context imbalance in dccp_child_process() - unexpected unlock
> The root cause is the missing annotation at dccp_child_process()
> Add the missing __releases(child) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer()
  2020-02-23 23:16   ` [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() Jules Irenge
@ 2020-02-24 21:29     ` David Miller
  0 siblings, 0 replies; 125+ messages in thread
From: David Miller @ 2020-02-24 21:29 UTC (permalink / raw)
  To: jbi.octave
  Cc: boqun.feng, linux-kernel, kuba, allison, steffen.klassert, axboe,
	hare, ktkhai, edumazet, tglx, pankaj.laxminarayan.bharadiya,
	arnd, cai, netdev

From: Jules Irenge <jbi.octave@gmail.com>
Date: Sun, 23 Feb 2020 23:16:56 +0000

> Sparse reports a warning unix_wait_for_peer()
> 
> warning: context imbalance in unix_wait_for_peer() - unexpected unlock
> 
> The root cause is the missing annotation at unix_wait_for_peer()
> Add the missing annotation __releases(&unix_sk(other)->lock)
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Applied.

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 30/30] sgi-xp: Add missing annotation for ocfs2_inode_cache_lock() and ocfs2_inode_cache_unlock()
  2020-02-23 23:17     ` [Ocfs2-devel] " Jules Irenge
@ 2020-02-25  0:54       ` Joseph Qi
  -1 siblings, 0 replies; 125+ messages in thread
From: Joseph Qi @ 2020-02-25  0:54 UTC (permalink / raw)
  To: Jules Irenge, boqun.feng
  Cc: linux-kernel, Mark Fasheh, Joel Becker,
	moderated list:ORACLE CLUSTER FILESYSTEM 2 (OCFS2)



On 2020/2/24 07:17, Jules Irenge wrote:
> Sparse reports a warning at ocfs2_inode_cache_lock()
> and ocfs2_inode_cache_unlock()
> warning: context imbalance in ocfs2_inode_cache_lock()
> 	- wrong count at exit
> 
> warning: context imbalance in ocfs2_inode_cache_unlock()
> 	- unexpected unlock
> The root cause is a missing annotation at ocfs2_inode_cache_lock()
> and at ocfs2_inode_cache_unlock()
> 
> Add the missing __acquires(&oi->ip_lock) annotation
> Add the missing __releases(&oi->ip_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
>  fs/ocfs2/inode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
> index 7c9dfd50c1c1..0b87e0a63ab9 100644
> --- a/fs/ocfs2/inode.c
> +++ b/fs/ocfs2/inode.c
> @@ -1623,6 +1623,7 @@ static struct super_block *ocfs2_inode_cache_get_super(struct ocfs2_caching_info
>  }
>  
>  static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci)
> +	__acquires(&oi->ip_lock)
>  {
>  	struct ocfs2_inode_info *oi = cache_info_to_inode(ci);
>  
> @@ -1630,6 +1631,7 @@ static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci)
>  }
>  
>  static void ocfs2_inode_cache_unlock(struct ocfs2_caching_info *ci)
> +	__releases(&oi->ip_lock)
>  {
>  	struct ocfs2_inode_info *oi = cache_info_to_inode(ci);
>  
> 

^ permalink raw reply	[flat|nested] 125+ messages in thread

* [Ocfs2-devel] [PATCH 30/30] sgi-xp: Add missing annotation for ocfs2_inode_cache_lock() and ocfs2_inode_cache_unlock()
@ 2020-02-25  0:54       ` Joseph Qi
  0 siblings, 0 replies; 125+ messages in thread
From: Joseph Qi @ 2020-02-25  0:54 UTC (permalink / raw)
  To: Jules Irenge, boqun.feng
  Cc: linux-kernel, Mark Fasheh, Joel Becker,
	moderated list:ORACLE CLUSTER FILESYSTEM 2 (OCFS2)



On 2020/2/24 07:17, Jules Irenge wrote:
> Sparse reports a warning at ocfs2_inode_cache_lock()
> and ocfs2_inode_cache_unlock()
> warning: context imbalance in ocfs2_inode_cache_lock()
> 	- wrong count at exit
> 
> warning: context imbalance in ocfs2_inode_cache_unlock()
> 	- unexpected unlock
> The root cause is a missing annotation at ocfs2_inode_cache_lock()
> and at ocfs2_inode_cache_unlock()
> 
> Add the missing __acquires(&oi->ip_lock) annotation
> Add the missing __releases(&oi->ip_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
>  fs/ocfs2/inode.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c
> index 7c9dfd50c1c1..0b87e0a63ab9 100644
> --- a/fs/ocfs2/inode.c
> +++ b/fs/ocfs2/inode.c
> @@ -1623,6 +1623,7 @@ static struct super_block *ocfs2_inode_cache_get_super(struct ocfs2_caching_info
>  }
>  
>  static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci)
> +	__acquires(&oi->ip_lock)
>  {
>  	struct ocfs2_inode_info *oi = cache_info_to_inode(ci);
>  
> @@ -1630,6 +1631,7 @@ static void ocfs2_inode_cache_lock(struct ocfs2_caching_info *ci)
>  }
>  
>  static void ocfs2_inode_cache_unlock(struct ocfs2_caching_info *ci)
> +	__releases(&oi->ip_lock)
>  {
>  	struct ocfs2_inode_info *oi = cache_info_to_inode(ci);
>  
> 

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 27/30] habanalabs: Add missing annotation for goya_hw_queues_lock()
  2020-02-23 23:17   ` [PATCH 27/30] habanalabs: Add missing annotation for goya_hw_queues_lock() Jules Irenge
@ 2020-02-25 11:55     ` Oded Gabbay
  0 siblings, 0 replies; 125+ messages in thread
From: Oded Gabbay @ 2020-02-25 11:55 UTC (permalink / raw)
  To: Jules Irenge
  Cc: boqun.feng, Linux-Kernel@Vger. Kernel. Org, Arnd Bergmann,
	Greg Kroah-Hartman, Tomer Tayar, Omer Shpigelman, Dalit Ben Zoor

On Mon, Feb 24, 2020 at 1:18 AM Jules Irenge <jbi.octave@gmail.com> wrote:
>
> Sparse reports a warning at goya_hw_queues_lock()
> warning: context imbalance in goya_hw_queues_lock() - wrong count at exit
> The root cause is a missing annotation at goya_hw_queues_lock()
> Add the missing __acquires(&goya->hw_queues_lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/misc/habanalabs/goya/goya.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
> index 7344e8a222ae..8ca7ee57cbc1 100644
> --- a/drivers/misc/habanalabs/goya/goya.c
> +++ b/drivers/misc/habanalabs/goya/goya.c
> @@ -5073,6 +5073,7 @@ static bool goya_is_device_idle(struct hl_device *hdev, u32 *mask,
>  }
>
>  static void goya_hw_queues_lock(struct hl_device *hdev)
> +       __acquires(&goya->hw_queues_lock)
>  {
>         struct goya_device *goya = hdev->asic_specific;
>
> --
> 2.24.1
>
This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
Applied to -next
Thanks,
Oded

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 28/30] habanalabs: Add missing annotation for goya_hw_queues_unlock()
  2020-02-23 23:17   ` [PATCH 28/30] habanalabs: Add missing annotation for goya_hw_queues_unlock() Jules Irenge
@ 2020-02-25 11:56     ` Oded Gabbay
  0 siblings, 0 replies; 125+ messages in thread
From: Oded Gabbay @ 2020-02-25 11:56 UTC (permalink / raw)
  To: Jules Irenge
  Cc: boqun.feng, Linux-Kernel@Vger. Kernel. Org, Arnd Bergmann,
	Greg Kroah-Hartman, Tomer Tayar, Omer Shpigelman, Dalit Ben Zoor

On Mon, Feb 24, 2020 at 1:18 AM Jules Irenge <jbi.octave@gmail.com> wrote:
>
> Sparse reports a warning at goya_hw_queues_unlock()
> warning: context imbalance in goya_hw_queues_unlock() - unexpected unlock
> The root cause is a missing annotation at goya_hw_queues_unlock()
> Add the missing __releases(&goya->hw_queues_lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/misc/habanalabs/goya/goya.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/habanalabs/goya/goya.c b/drivers/misc/habanalabs/goya/goya.c
> index 8ca7ee57cbc1..6138b461d0f8 100644
> --- a/drivers/misc/habanalabs/goya/goya.c
> +++ b/drivers/misc/habanalabs/goya/goya.c
> @@ -5081,6 +5081,7 @@ static void goya_hw_queues_lock(struct hl_device *hdev)
>  }
>
>  static void goya_hw_queues_unlock(struct hl_device *hdev)
> +       __releases(&goya->hw_queues_lock)
>  {
>         struct goya_device *goya = hdev->asic_specific;
>
> --
> 2.24.1
>
This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
Applied to -next
Thanks,
Oded

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 03/30] xfs: Add missing annotation to xfs_ail_check()
  2020-02-23 23:16   ` [PATCH 03/30] xfs: Add missing annotation to xfs_ail_check() Jules Irenge
@ 2020-02-25 15:44     ` Darrick J. Wong
  0 siblings, 0 replies; 125+ messages in thread
From: Darrick J. Wong @ 2020-02-25 15:44 UTC (permalink / raw)
  To: Jules Irenge; +Cc: boqun.feng, linux-kernel, supporter:XFS FILESYSTEM

On Sun, Feb 23, 2020 at 11:16:44PM +0000, Jules Irenge wrote:
> Sparse reports a warning at xfs_ail_check()
> 
> warning: context imbalance in xfs_ail_check() - unexpected unlock
> 
> The root cause is the missing annotation at xfs_ail_check()
> 
> Add the missing __must_hold(&ailp->ail_lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Seems reasonable, though I'm wondering if this is a treewide change you
seek to apply yourself, or merely a large patch series to merge through
the individual subsystem maintainers?

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/xfs/xfs_trans_ail.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/xfs_trans_ail.c b/fs/xfs/xfs_trans_ail.c
> index 00cc5b8734be..58d4ef1b4c05 100644
> --- a/fs/xfs/xfs_trans_ail.c
> +++ b/fs/xfs/xfs_trans_ail.c
> @@ -32,6 +32,7 @@ STATIC void
>  xfs_ail_check(
>  	struct xfs_ail		*ailp,
>  	struct xfs_log_item	*lip)
> +	__must_hold(&ailp->ail_lock)
>  {
>  	struct xfs_log_item	*prev_lip;
>  	struct xfs_log_item	*next_lip;
> -- 
> 2.24.1
> 

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock()
  2020-02-14 20:47   ` [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock() Jules Irenge
@ 2020-02-27 21:52       ` Minchan Kim
  2020-02-27 21:52       ` Minchan Kim
  1 sibling, 0 replies; 125+ messages in thread
From: Minchan Kim @ 2020-02-27 21:52 UTC (permalink / raw)
  To: Jules Irenge
  Cc: linux-kernel, boqun.feng, Nitin Gupta, Sergey Senozhatsky,
	Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

On Fri, Feb 14, 2020 at 08:47:21PM +0000, Jules Irenge wrote:
> Sparse reports a warning at migrate_read_lock()()
> 
>  warning: context imbalance in migrate_read_lock() - wrong count at exit
> 
> The root cause is the missing annotation at migrate_read_lock()
> Add the missing __acquires(&zspage->lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock()
@ 2020-02-27 21:52       ` Minchan Kim
  0 siblings, 0 replies; 125+ messages in thread
From: Minchan Kim @ 2020-02-27 21:52 UTC (permalink / raw)
  To: Jules Irenge
  Cc: linux-kernel, boqun.feng, Nitin Gupta, Sergey Senozhatsky,
	Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

On Fri, Feb 14, 2020 at 08:47:21PM +0000, Jules Irenge wrote:
> Sparse reports a warning at migrate_read_lock()()
> 
>  warning: context imbalance in migrate_read_lock() - wrong count at exit
> 
> The root cause is the missing annotation at migrate_read_lock()
> Add the missing __acquires(&zspage->lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>


^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock()
  2020-02-14 20:47   ` [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock() Jules Irenge
@ 2020-02-27 21:52       ` Minchan Kim
  2020-02-27 21:52       ` Minchan Kim
  1 sibling, 0 replies; 125+ messages in thread
From: Minchan Kim @ 2020-02-27 21:52 UTC (permalink / raw)
  To: Jules Irenge
  Cc: linux-kernel, boqun.feng, Nitin Gupta, Sergey Senozhatsky,
	Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

On Fri, Feb 14, 2020 at 08:47:21PM +0000, Jules Irenge wrote:
> Sparse reports a warning at migrate_read_lock()()
> 
>  warning: context imbalance in migrate_read_lock() - wrong count at exit
> 
> The root cause is the missing annotation at migrate_read_lock()
> Add the missing __acquires(&zspage->lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock()
@ 2020-02-27 21:52       ` Minchan Kim
  0 siblings, 0 replies; 125+ messages in thread
From: Minchan Kim @ 2020-02-27 21:52 UTC (permalink / raw)
  To: Jules Irenge
  Cc: linux-kernel, boqun.feng, Nitin Gupta, Sergey Senozhatsky,
	Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

On Fri, Feb 14, 2020 at 08:47:21PM +0000, Jules Irenge wrote:
> Sparse reports a warning at migrate_read_lock()()
> 
>  warning: context imbalance in migrate_read_lock() - wrong count at exit
> 
> The root cause is the missing annotation at migrate_read_lock()
> Add the missing __acquires(&zspage->lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>


^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 12/30] mm/zsmalloc: Add missing annotation for pin_tag()
  2020-02-14 20:47   ` [PATCH 12/30] mm/zsmalloc: Add missing annotation for pin_tag() Jules Irenge
@ 2020-02-27 21:53       ` Minchan Kim
  0 siblings, 0 replies; 125+ messages in thread
From: Minchan Kim @ 2020-02-27 21:53 UTC (permalink / raw)
  To: Jules Irenge
  Cc: linux-kernel, boqun.feng, Nitin Gupta, Sergey Senozhatsky,
	Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

On Fri, Feb 14, 2020 at 08:47:23PM +0000, Jules Irenge wrote:
> Sparse reports a warning at pin_tag()()
> 
> warning: context imbalance in pin_tag() - wrong count at exit
> 
> The root cause is the missing annotation at pin_tag()
> Add the missing __acquires(bitlock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 12/30] mm/zsmalloc: Add missing annotation for pin_tag()
@ 2020-02-27 21:53       ` Minchan Kim
  0 siblings, 0 replies; 125+ messages in thread
From: Minchan Kim @ 2020-02-27 21:53 UTC (permalink / raw)
  To: Jules Irenge
  Cc: linux-kernel, boqun.feng, Nitin Gupta, Sergey Senozhatsky,
	Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

On Fri, Feb 14, 2020 at 08:47:23PM +0000, Jules Irenge wrote:
> Sparse reports a warning at pin_tag()()
> 
> warning: context imbalance in pin_tag() - wrong count at exit
> 
> The root cause is the missing annotation at pin_tag()
> Add the missing __acquires(bitlock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>


^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 13/30] mm/zsmalloc: Add missing annotation for unpin_tag()
  2020-02-14 20:47   ` [PATCH 13/30] mm/zsmalloc: Add missing annotation for unpin_tag() Jules Irenge
@ 2020-02-27 21:53       ` Minchan Kim
  0 siblings, 0 replies; 125+ messages in thread
From: Minchan Kim @ 2020-02-27 21:53 UTC (permalink / raw)
  To: Jules Irenge
  Cc: linux-kernel, boqun.feng, Nitin Gupta, Sergey Senozhatsky,
	Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

On Fri, Feb 14, 2020 at 08:47:24PM +0000, Jules Irenge wrote:
> Sparse reports a warning at unpin_tag()()
> 
> warning: context imbalance in unpin_tag() - unexpected unlock
> 
> The root cause is the missing annotation at unpin_tag()
> Add the missing __releases(bitlock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 13/30] mm/zsmalloc: Add missing annotation for unpin_tag()
@ 2020-02-27 21:53       ` Minchan Kim
  0 siblings, 0 replies; 125+ messages in thread
From: Minchan Kim @ 2020-02-27 21:53 UTC (permalink / raw)
  To: Jules Irenge
  Cc: linux-kernel, boqun.feng, Nitin Gupta, Sergey Senozhatsky,
	Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

On Fri, Feb 14, 2020 at 08:47:24PM +0000, Jules Irenge wrote:
> Sparse reports a warning at unpin_tag()()
> 
> warning: context imbalance in unpin_tag() - unexpected unlock
> 
> The root cause is the missing annotation at unpin_tag()
> Add the missing __releases(bitlock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>


^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 11/30] mm/zsmalloc: Add missing annotation for migrate_read_unlock()
  2020-02-14 20:47   ` [PATCH 11/30] mm/zsmalloc: Add missing annotation for migrate_read_unlock() Jules Irenge
@ 2020-02-27 21:54       ` Minchan Kim
  0 siblings, 0 replies; 125+ messages in thread
From: Minchan Kim @ 2020-02-27 21:54 UTC (permalink / raw)
  To: Jules Irenge
  Cc: linux-kernel, boqun.feng, Nitin Gupta, Sergey Senozhatsky,
	Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

On Fri, Feb 14, 2020 at 08:47:22PM +0000, Jules Irenge wrote:
> Sparse reports a warning at migrate_read_unlock()()
> 
>  warning: context imbalance in migrate_read_unlock() - unexpected unlock
> 
> The root cause is the missing annotation at migrate_read_unlock()
> Add the missing __releases(&zspage->lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 11/30] mm/zsmalloc: Add missing annotation for migrate_read_unlock()
@ 2020-02-27 21:54       ` Minchan Kim
  0 siblings, 0 replies; 125+ messages in thread
From: Minchan Kim @ 2020-02-27 21:54 UTC (permalink / raw)
  To: Jules Irenge
  Cc: linux-kernel, boqun.feng, Nitin Gupta, Sergey Senozhatsky,
	Andrew Morton,
	open list:ZSMALLOC COMPRESSED SLAB MEMORY ALLOCATOR

On Fri, Feb 14, 2020 at 08:47:22PM +0000, Jules Irenge wrote:
> Sparse reports a warning at migrate_read_unlock()()
> 
>  warning: context imbalance in migrate_read_unlock() - unexpected unlock
> 
> The root cause is the missing annotation at migrate_read_unlock()
> Add the missing __releases(&zspage->lock) annotation
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>


^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 29/30] sgi-xp: Add missing annotation for xpc_disconnect_channel()
  2020-02-23 23:17   ` [PATCH 29/30] sgi-xp: Add missing annotation for xpc_disconnect_channel() Jules Irenge
@ 2020-02-28 19:22     ` Robin Holt
  0 siblings, 0 replies; 125+ messages in thread
From: Robin Holt @ 2020-02-28 19:22 UTC (permalink / raw)
  To: Jules Irenge
  Cc: boqun.feng, LKML, Cliff Whickman, Arnd Bergmann, Greg Kroah-Hartman

On Sun, Feb 23, 2020 at 5:18 PM Jules Irenge <jbi.octave@gmail.com> wrote:
>
> Sparse reports a warning at xpc_disconnect_channel()
> warning: context imbalance in xpc_disconnect_channel() - unexpected unlock
> The root cause is a missing annotation at xpc_disconnect_channel()
> Add the missing __must_hold(&ch->lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Acked-by: Robin Holt <robinmholt@gmail.com>

^ permalink raw reply	[flat|nested] 125+ messages in thread

* Re: [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock()
  2020-02-23 23:17   ` [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock() Jules Irenge
@ 2020-03-04 11:00     ` Rafael J. Wysocki
  0 siblings, 0 replies; 125+ messages in thread
From: Rafael J. Wysocki @ 2020-03-04 11:00 UTC (permalink / raw)
  To: Jules Irenge; +Cc: boqun.feng, linux-kernel, Len Brown, open list:ACPI

On Monday, February 24, 2020 12:17:03 AM CET Jules Irenge wrote:
> Sparse reports a warning at acpi_os_acquire_lock()
> 
> warning: context imbalance in acpi_os_acquire_lock() - unexpected unlock
> 
> The root cause is the missing annotation at acpi_os_acquire_lock()
> Add the missing annotation __acquires(lockp)
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/acpi/osl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 41168c027a5a..7094abc5ffc6 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -1598,6 +1598,7 @@ void acpi_os_delete_lock(acpi_spinlock handle)
>   */
>  
>  acpi_cpu_flags acpi_os_acquire_lock(acpi_spinlock lockp)
> +	__acquires(lockp)
>  {
>  	acpi_cpu_flags flags;
>  	spin_lock_irqsave(lockp, flags);
> 

Merged with the [23/30] and applied with modified subject and changelog as
5.7 material.

Thanks!





^ permalink raw reply	[flat|nested] 125+ messages in thread

end of thread, other threads:[~2020-03-04 11:00 UTC | newest]

Thread overview: 125+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <0/30>
2020-02-14 20:47 ` [PATCH 00/30] Lock warning cleanup Jules Irenge
2020-02-14 20:47   ` [PATCH 01/30] x86/apic/vector: Add missing annotation to lock_vector_lock(void) Jules Irenge
2020-02-14 20:47   ` [PATCH 02/30] " Jules Irenge
2020-02-14 20:47   ` [PATCH 03/30] mm/memcontrol: Add missing annotation for unlock_page_lru() Jules Irenge
2020-02-14 20:47     ` Jules Irenge
2020-02-14 20:47   ` [PATCH 04/30] mm/memcontrol: Add missing annotation for lock_page_lru() Jules Irenge
2020-02-14 20:47     ` Jules Irenge
2020-02-14 20:47   ` [PATCH 05/30] mm/compaction: Add missing annotation for compact_lock_irqsave Jules Irenge
2020-02-14 20:47   ` [PATCH 06/30] mm/hugetlb: Add missing annotation for gather_surplus_pages() Jules Irenge
2020-02-14 23:40     ` Mike Kravetz
2020-02-14 20:47   ` [PATCH 07/30] mm/mempolicy: Add missing annotation for queue_pages_pmd() Jules Irenge
2020-02-14 20:47   ` [PATCH 08/30] mm/slub: Add missing annotation for get_map() Jules Irenge
2020-02-14 20:47   ` [PATCH 09/30] mm/slub: Add missing annotation for put_map() Jules Irenge
2020-02-14 20:47   ` [PATCH 10/30] mm/zsmalloc: Add missing annotation for migrate_read_lock() Jules Irenge
2020-02-27 21:52     ` Minchan Kim
2020-02-27 21:52       ` Minchan Kim
2020-02-27 21:52     ` Minchan Kim
2020-02-27 21:52       ` Minchan Kim
2020-02-14 20:47   ` [PATCH 11/30] mm/zsmalloc: Add missing annotation for migrate_read_unlock() Jules Irenge
2020-02-27 21:54     ` Minchan Kim
2020-02-27 21:54       ` Minchan Kim
2020-02-14 20:47   ` [PATCH 12/30] mm/zsmalloc: Add missing annotation for pin_tag() Jules Irenge
2020-02-27 21:53     ` Minchan Kim
2020-02-27 21:53       ` Minchan Kim
2020-02-14 20:47   ` [PATCH 13/30] mm/zsmalloc: Add missing annotation for unpin_tag() Jules Irenge
2020-02-27 21:53     ` Minchan Kim
2020-02-27 21:53       ` Minchan Kim
2020-02-14 20:47   ` [PATCH 14/30] x86/xen: Add missing annotation for xen_pte_lock() Jules Irenge
2020-02-14 20:47     ` [Xen-devel] " Jules Irenge
2020-02-14 22:40     ` Boris Ostrovsky
2020-02-14 22:40       ` Boris Ostrovsky
2020-02-15 21:13       ` Jules Irenge
2020-02-15 21:13         ` Jules Irenge
2020-02-14 20:47   ` [PATCH 15/30] x86/xen: Add missing annotation for xen_pte_unlock() Jules Irenge
2020-02-14 20:47     ` [Xen-devel] " Jules Irenge
2020-02-14 20:47   ` [PATCH 16/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_begin() Jules Irenge
2020-02-14 20:47     ` Jules Irenge
2020-02-14 20:47   ` [PATCH 17/30] drm/vkms: Add missing annotation for vkms_crtc_atomic_flush() Jules Irenge
2020-02-14 20:47     ` Jules Irenge
2020-02-14 20:47   ` [PATCH 18/30] driver core: Add missing annotation for device_links_write_lock() Jules Irenge
2020-02-14 20:47   ` [PATCH 19/30] driver core: Add missing annotation for device_links_read_lock() Jules Irenge
2020-02-14 20:47   ` [PATCH 20/30] pcnet32: Add missing annotation for pcnet32_suspend() Jules Irenge
2020-02-14 20:47   ` [PATCH 21/30] sfc: Add missing annotation for efx_ef10_try_update_nic_stats_vf() Jules Irenge
2020-02-17 18:00     ` Martin Habets
2020-02-14 20:47   ` [PATCH 22/30] xhci: Add missing annotation for xhci_set_port_power() Jules Irenge
2020-02-14 20:47   ` [PATCH 23/30] xhci: Add missing annotation for xhci_enter_test_mode Jules Irenge
2020-02-14 20:47   ` [PATCH 24/30] tipc: Add missing annotation for tipc_node_read_lock() Jules Irenge
2020-02-14 20:47   ` [PATCH 25/30] tipc: Add missing annotation for tipc_node_read_unlock() Jules Irenge
2020-02-14 20:47   ` [PATCH 26/30] tipc: Add missing annotation for tipc_node_write_lock() Jules Irenge
2020-02-14 20:47   ` [PATCH 27/30] tipc: Add missing annotation for tipc_node_write_unlock_fast() Jules Irenge
2020-02-14 20:47   ` [PATCH 28/30] tipc: Add missing annotation for tipc_node_write_unlock() Jules Irenge
2020-02-14 20:47   ` [PATCH 29/30] net: Add missing annotation for netlink_walk_start() Jules Irenge
2020-02-14 20:47   ` [PATCH 30/30] net: Add missing annotation for netlink_walk_stop() Jules Irenge
2020-02-23 23:16 ` [PATCH 00/30] Lock warning cleanups Jules Irenge
2020-02-23 23:16   ` [PATCH 01/30] btrfs: Add missing annotation for release_extent_buffer() Jules Irenge
2020-02-23 23:27     ` Nikolay Borisov
2020-02-24 15:19     ` David Sterba
2020-02-23 23:16   ` [PATCH 02/30] dax: Add missing annotations ofr dax_read_lock() and dax_read_unlock() Jules Irenge
2020-02-23 23:16     ` Jules Irenge
2020-02-24  1:23     ` Yi Zhang
2020-02-24  1:23       ` Yi Zhang
2020-02-23 23:16   ` [PATCH 03/30] xfs: Add missing annotation to xfs_ail_check() Jules Irenge
2020-02-25 15:44     ` Darrick J. Wong
2020-02-23 23:16   ` [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() Jules Irenge
2020-02-23 23:16     ` Jules Irenge
2020-02-24 21:28     ` David Miller
2020-02-24 21:28       ` David Miller
2020-02-23 23:16   ` [PATCH 05/30] sctp: Add missing annotation for sctp_transport_walk_start() Jules Irenge
2020-02-23 23:16     ` Jules Irenge
2020-02-24 21:28     ` David Miller
2020-02-24 21:28       ` David Miller
2020-02-23 23:16   ` [PATCH 06/30] sctp: Add missing annotation for sctp_transport_walk_stop() Jules Irenge
2020-02-23 23:16     ` Jules Irenge
2020-02-24 21:28     ` David Miller
2020-02-24 21:28       ` David Miller
2020-02-23 23:16   ` [PATCH 07/30] net: Add missing annotation for llc_seq_start() Jules Irenge
2020-02-24 21:28     ` David Miller
2020-02-23 23:16   ` [PATCH 08/30] netrom: Add missing annotation for nr_info_start() Jules Irenge
2020-02-23 23:16     ` Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 09/30] netrom: Add missing annotation for nr_info_stop() Jules Irenge
2020-02-23 23:16     ` Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 10/30] net: netrom: Add missing annotation for nr_node_start() Jules Irenge
2020-02-23 23:16     ` Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 11/30] net: netrom: Add missing annotation for nr_node_stop() Jules Irenge
2020-02-23 23:16     ` Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 12/30] net: netrom: Add missing annotation for nr_neigh_start() Jules Irenge
2020-02-23 23:16     ` Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 13/30] net: netrom: Add missing annotation for nr_neigh_stop() Jules Irenge
2020-02-23 23:16     ` Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 14/30] dccp: Add missing annotation for dccp_child_process() Jules Irenge
2020-02-23 23:16     ` Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-24 21:29       ` David Miller
2020-02-23 23:16   ` [PATCH 15/30] af_unix: Add missing annotation for unix_wait_for_peer() Jules Irenge
2020-02-24 21:29     ` David Miller
2020-02-23 23:16   ` [PATCH 16/30] proc: Add missing annotation for close_pdeo() Jules Irenge
2020-02-23 23:16   ` [PATCH 17/30] mm/zsmalloc: Add missing annotation for zs_map_object() Jules Irenge
2020-02-23 23:16   ` [PATCH 18/30] mm/zsmalloc: Add missing annotation for zs_unmap_object() Jules Irenge
2020-02-23 23:17   ` [PATCH 19/30] mm/zsmalloc: Add missing annotation for migrate_write_lock() Jules Irenge
2020-02-23 23:17   ` [PATCH 20/30] mm/zsmalloc: Add missing annotation for migrate_write_unlock() Jules Irenge
2020-02-23 23:17   ` [PATCH 21/30] scsi: csiostor: Add missing annotation for csio_scsi_cleanup_io_q() Jules Irenge
2020-02-23 23:17   ` [PATCH 22/30] ACPI: OSL: Add missing annotation for acpi_os_acquire_lock() Jules Irenge
2020-03-04 11:00     ` Rafael J. Wysocki
2020-02-23 23:17   ` [PATCH 23/30] ACPI: OSL: Add missing annotation for acpi_os_release_lock() Jules Irenge
2020-02-23 23:17   ` [PATCH 24/30] dmaengine: mic_x100_dma: Add missing annotation for mic_dma_tx_submit_unlock() Jules Irenge
2020-02-23 23:17   ` [PATCH 25/30] zram: Add missing annotatin for zram_slot_lock() Jules Irenge
2020-02-23 23:17   ` [PATCH 26/30] zram: Add missing annotatin for zram_slot_unlock() Jules Irenge
2020-02-23 23:17   ` [PATCH 27/30] habanalabs: Add missing annotation for goya_hw_queues_lock() Jules Irenge
2020-02-25 11:55     ` Oded Gabbay
2020-02-23 23:17   ` [PATCH 28/30] habanalabs: Add missing annotation for goya_hw_queues_unlock() Jules Irenge
2020-02-25 11:56     ` Oded Gabbay
2020-02-23 23:17   ` [PATCH 29/30] sgi-xp: Add missing annotation for xpc_disconnect_channel() Jules Irenge
2020-02-28 19:22     ` Robin Holt
2020-02-23 23:17   ` [PATCH 30/30] sgi-xp: Add missing annotation for ocfs2_inode_cache_lock() and ocfs2_inode_cache_unlock() Jules Irenge
2020-02-23 23:17     ` [Ocfs2-devel] " Jules Irenge
2020-02-24  1:52     ` Joseph Qi
2020-02-24  1:52       ` [Ocfs2-devel] " Joseph Qi
2020-02-25  0:54     ` Joseph Qi
2020-02-25  0:54       ` [Ocfs2-devel] " Joseph Qi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.