* [PATCH] net: 802: psnap.c: Use built-in RCU list checking
@ 2020-02-21 16:19 ` madhuparnabhowmik10
0 siblings, 0 replies; 4+ messages in thread
From: madhuparnabhowmik10 @ 2020-02-21 16:19 UTC (permalink / raw)
To: davem, gregkh, tglx, allison
Cc: netdev, linux-kernel, joel, frextrite, linux-kernel-mentees,
paulmck, Madhuparna Bhowmik
From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
list_for_each_entry_rcu() has built-in RCU and lock checking.
Pass cond argument to list_for_each_entry_rcu() to silence
false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
by default.
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
---
net/802/psnap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/802/psnap.c b/net/802/psnap.c
index 40ab2aea7b31..4492e8d7ad20 100644
--- a/net/802/psnap.c
+++ b/net/802/psnap.c
@@ -30,7 +30,7 @@ static struct datalink_proto *find_snap_client(const unsigned char *desc)
{
struct datalink_proto *proto = NULL, *p;
- list_for_each_entry_rcu(p, &snap_list, node) {
+ list_for_each_entry_rcu(p, &snap_list, node, lockdep_is_held(&snap_lock)) {
if (!memcmp(p->type, desc, 5)) {
proto = p;
break;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Linux-kernel-mentees] [PATCH] net: 802: psnap.c: Use built-in RCU list checking
@ 2020-02-21 16:19 ` madhuparnabhowmik10
0 siblings, 0 replies; 4+ messages in thread
From: madhuparnabhowmik10 @ 2020-02-21 16:19 UTC (permalink / raw)
To: davem, gregkh, tglx, allison
Cc: paulmck, netdev, linux-kernel, Madhuparna Bhowmik, joel,
linux-kernel-mentees
From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
list_for_each_entry_rcu() has built-in RCU and lock checking.
Pass cond argument to list_for_each_entry_rcu() to silence
false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
by default.
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
---
net/802/psnap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/802/psnap.c b/net/802/psnap.c
index 40ab2aea7b31..4492e8d7ad20 100644
--- a/net/802/psnap.c
+++ b/net/802/psnap.c
@@ -30,7 +30,7 @@ static struct datalink_proto *find_snap_client(const unsigned char *desc)
{
struct datalink_proto *proto = NULL, *p;
- list_for_each_entry_rcu(p, &snap_list, node) {
+ list_for_each_entry_rcu(p, &snap_list, node, lockdep_is_held(&snap_lock)) {
if (!memcmp(p->type, desc, 5)) {
proto = p;
break;
--
2.17.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: 802: psnap.c: Use built-in RCU list checking
2020-02-21 16:19 ` [Linux-kernel-mentees] " madhuparnabhowmik10
@ 2020-02-24 21:03 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-02-24 21:03 UTC (permalink / raw)
To: madhuparnabhowmik10
Cc: gregkh, tglx, allison, netdev, linux-kernel, joel, frextrite,
linux-kernel-mentees, paulmck
From: madhuparnabhowmik10@gmail.com
Date: Fri, 21 Feb 2020 21:49:47 +0530
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> list_for_each_entry_rcu() has built-in RCU and lock checking.
>
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
> by default.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] net: 802: psnap.c: Use built-in RCU list checking
@ 2020-02-24 21:03 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-02-24 21:03 UTC (permalink / raw)
To: madhuparnabhowmik10
Cc: paulmck, linux-kernel, netdev, joel, tglx, linux-kernel-mentees, allison
From: madhuparnabhowmik10@gmail.com
Date: Fri, 21 Feb 2020 21:49:47 +0530
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> list_for_each_entry_rcu() has built-in RCU and lock checking.
>
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
> by default.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Applied.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-24 21:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 16:19 [PATCH] net: 802: psnap.c: Use built-in RCU list checking madhuparnabhowmik10
2020-02-21 16:19 ` [Linux-kernel-mentees] " madhuparnabhowmik10
2020-02-24 21:03 ` David Miller
2020-02-24 21:03 ` [Linux-kernel-mentees] " David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.