From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA124C38BFA for ; Mon, 24 Feb 2020 21:28:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8A3D218AC for ; Mon, 24 Feb 2020 21:28:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727957AbgBXV2o (ORCPT ); Mon, 24 Feb 2020 16:28:44 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38600 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727851AbgBXV2n (ORCPT ); Mon, 24 Feb 2020 16:28:43 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CB1E8121A82E7; Mon, 24 Feb 2020 13:28:42 -0800 (PST) Date: Mon, 24 Feb 2020 13:28:42 -0800 (PST) Message-Id: <20200224.132842.2112142868734722035.davem@davemloft.net> To: jbi.octave@gmail.com Cc: boqun.feng@gmail.com, linux-kernel@vger.kernel.org, vyasevich@gmail.com, nhorman@tuxdriver.com, marcelo.leitner@gmail.com, kuba@kernel.org, linux-sctp@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() From: David Miller In-Reply-To: <20200223231711.157699-5-jbi.octave@gmail.com> References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> <20200223231711.157699-5-jbi.octave@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 24 Feb 2020 13:28:43 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jules Irenge Date: Sun, 23 Feb 2020 23:16:45 +0000 > Sparse reports a warning at sctp_err_finish() > warning: context imbalance in sctp_err_finish() - unexpected unlock > > The root cause is a missing annotation at sctp_err_finish() > Add the missing __releases(&((__sk)->sk_lock.slock)) annotation > > Signed-off-by: Jules Irenge Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Mon, 24 Feb 2020 21:28:42 +0000 Subject: Re: [PATCH 04/30] sctp: Add missing annotation for sctp_err_finish() Message-Id: <20200224.132842.2112142868734722035.davem@davemloft.net> List-Id: References: <0/30> <20200223231711.157699-1-jbi.octave@gmail.com> <20200223231711.157699-5-jbi.octave@gmail.com> In-Reply-To: <20200223231711.157699-5-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: jbi.octave@gmail.com Cc: boqun.feng@gmail.com, linux-kernel@vger.kernel.org, vyasevich@gmail.com, nhorman@tuxdriver.com, marcelo.leitner@gmail.com, kuba@kernel.org, linux-sctp@vger.kernel.org, netdev@vger.kernel.org From: Jules Irenge Date: Sun, 23 Feb 2020 23:16:45 +0000 > Sparse reports a warning at sctp_err_finish() > warning: context imbalance in sctp_err_finish() - unexpected unlock > > The root cause is a missing annotation at sctp_err_finish() > Add the missing __releases(&((__sk)->sk_lock.slock)) annotation > > Signed-off-by: Jules Irenge Applied.