From: Parth Shah <parth@linux.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
qais.yousef@arm.com, chris.hyser@oracle.com,
patrick.bellasi@matbug.net, valentin.schneider@arm.com,
David.Laight@ACULAB.COM, pjt@google.com, pavel@ucw.cz,
tj@kernel.org, dhaval.giani@oracle.com, qperret@google.com,
tim.c.chen@linux.intel.com
Subject: [PATCH v4 4/4] sched/core: Add permission checks for setting the latency_nice value
Date: Mon, 24 Feb 2020 14:29:18 +0530 [thread overview]
Message-ID: <20200224085918.16955-5-parth@linux.ibm.com> (raw)
In-Reply-To: <20200224085918.16955-1-parth@linux.ibm.com>
Since the latency_nice uses the similar infrastructure as NICE, use the
already existing CAP_SYS_NICE security checks for the latency_nice. This
should return -EPERM for the non-root user when trying to set the task
latency_nice value to any lower than the current value.
Signed-off-by: Parth Shah <parth@linux.ibm.com>
---
kernel/sched/core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index e1dc536d4ca3..f883e1d3cd10 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4887,6 +4887,10 @@ static int __sched_setscheduler(struct task_struct *p,
return -EINVAL;
if (attr->sched_latency_nice < MIN_LATENCY_NICE)
return -EINVAL;
+ /* Use the same security checks as NICE */
+ if (attr->sched_latency_nice < p->latency_nice &&
+ !can_nice(p, attr->sched_latency_nice))
+ return -EPERM;
}
if (pi)
--
2.17.2
next prev parent reply other threads:[~2020-02-24 8:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 8:59 [PATCH v4 0/4] Introduce per-task latency_nice for scheduler hints Parth Shah
2020-02-24 8:59 ` [PATCH v4 1/4] sched: Introduce latency-nice as a per-task attribute Parth Shah
2020-02-24 8:59 ` [PATCH v4 2/4] sched/core: Propagate parent task's latency requirements to the child task Parth Shah
2020-02-25 6:32 ` Pavan Kondeti
2020-02-25 8:16 ` Parth Shah
2020-02-24 8:59 ` [PATCH v4 3/4] sched: Allow sched_{get,set}attr to change latency_nice of the task Parth Shah
2020-02-25 6:54 ` Pavan Kondeti
2020-02-25 15:03 ` Parth Shah
2020-02-26 3:44 ` Pavan Kondeti
2020-02-24 8:59 ` Parth Shah [this message]
2020-02-24 13:29 ` [PATCH v4 4/4] sched/core: Add permission checks for setting the latency_nice value Qais Yousef
2020-02-25 6:47 ` Parth Shah
2020-02-27 11:44 ` Qais Yousef
2020-02-27 14:46 ` chris hyser
2020-02-24 23:08 ` chris hyser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224085918.16955-5-parth@linux.ibm.com \
--to=parth@linux.ibm.com \
--cc=David.Laight@ACULAB.COM \
--cc=chris.hyser@oracle.com \
--cc=dhaval.giani@oracle.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@matbug.net \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=qais.yousef@arm.com \
--cc=qperret@google.com \
--cc=tim.c.chen@linux.intel.com \
--cc=tj@kernel.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.