From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F12C35671 for ; Mon, 24 Feb 2020 13:59:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB35D20836 for ; Mon, 24 Feb 2020 13:59:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727607AbgBXN7N (ORCPT ); Mon, 24 Feb 2020 08:59:13 -0500 Received: from foss.arm.com ([217.140.110.172]:37450 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727348AbgBXN7N (ORCPT ); Mon, 24 Feb 2020 08:59:13 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0B4E630E; Mon, 24 Feb 2020 05:59:13 -0800 (PST) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E0DB23F534; Mon, 24 Feb 2020 05:59:12 -0800 (PST) Received: by e110455-lin.cambridge.arm.com (Postfix, from userid 1000) id A1951682F2C; Mon, 24 Feb 2020 13:59:11 +0000 (GMT) Date: Mon, 24 Feb 2020 13:59:11 +0000 From: Liviu Dudau To: Wambui Karuga Cc: brian.starkey@arm.com, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH] drm/arm: make hdlcd_debugfs_init return 0 Message-ID: <20200224135911.GJ364558@e110455-lin.cambridge.arm.com> References: <20200218172821.18378-1-wambui.karugax@gmail.com> <20200218172821.18378-2-wambui.karugax@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200218172821.18378-2-wambui.karugax@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Feb 18, 2020 at 08:28:13PM +0300, Wambui Karuga wrote: > As drm_debugfs_create_files should return void, remove its use as a > return value in hdlcd_debugfs_init and have the latter function return 0 > directly. > > Signed-off-by: Wambui Karuga > --- > drivers/gpu/drm/arm/hdlcd_drv.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c > index 2e053815b54a..bd0ad6f46a97 100644 > --- a/drivers/gpu/drm/arm/hdlcd_drv.c > +++ b/drivers/gpu/drm/arm/hdlcd_drv.c > @@ -226,8 +226,10 @@ static struct drm_info_list hdlcd_debugfs_list[] = { > > static int hdlcd_debugfs_init(struct drm_minor *minor) > { > - return drm_debugfs_create_files(hdlcd_debugfs_list, > - ARRAY_SIZE(hdlcd_debugfs_list), minor->debugfs_root, minor); > + drm_debugfs_create_files(hdlcd_debugfs_list, > + ARRAY_SIZE(hdlcd_debugfs_list), > + minor->debugfs_root, minor); > + return 0; > } > #endif > > -- > 2.25.0 > Thanks for your patch! I had to go into the ML and find out the series where this patch belongs to and seen that you have already received some feedback, but I think a summary is worth: - you should look if it is possible to make .debugfs_init hook return void, it would simplify the cleanup in the drivers by not having to return 0. - you should put in each driver patch a note that drm_debugfs_create_files() always returns 0 since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail) so that people don't have to hunt in the git history for clues. - Make all the changes into a series With that, you can have my Acked-by: Liviu Dudau Best regards, Liviu -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B70BC11D30 for ; Mon, 24 Feb 2020 13:59:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78EC720836 for ; Mon, 24 Feb 2020 13:59:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78EC720836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A4A26E4F4; Mon, 24 Feb 2020 13:59:15 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id E039E6E4F4 for ; Mon, 24 Feb 2020 13:59:13 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0B4E630E; Mon, 24 Feb 2020 05:59:13 -0800 (PST) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E0DB23F534; Mon, 24 Feb 2020 05:59:12 -0800 (PST) Received: by e110455-lin.cambridge.arm.com (Postfix, from userid 1000) id A1951682F2C; Mon, 24 Feb 2020 13:59:11 +0000 (GMT) Date: Mon, 24 Feb 2020 13:59:11 +0000 From: Liviu Dudau To: Wambui Karuga Subject: Re: [PATCH] drm/arm: make hdlcd_debugfs_init return 0 Message-ID: <20200224135911.GJ364558@e110455-lin.cambridge.arm.com> References: <20200218172821.18378-1-wambui.karugax@gmail.com> <20200218172821.18378-2-wambui.karugax@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200218172821.18378-2-wambui.karugax@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGksCgpPbiBUdWUsIEZlYiAxOCwgMjAyMCBhdCAwODoyODoxM1BNICswMzAwLCBXYW1idWkgS2Fy dWdhIHdyb3RlOgo+IEFzIGRybV9kZWJ1Z2ZzX2NyZWF0ZV9maWxlcyBzaG91bGQgcmV0dXJuIHZv aWQsIHJlbW92ZSBpdHMgdXNlIGFzIGEKPiByZXR1cm4gdmFsdWUgaW4gaGRsY2RfZGVidWdmc19p bml0IGFuZCBoYXZlIHRoZSBsYXR0ZXIgZnVuY3Rpb24gcmV0dXJuIDAKPiBkaXJlY3RseS4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBXYW1idWkgS2FydWdhIDx3YW1idWkua2FydWdheEBnbWFpbC5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hcm0vaGRsY2RfZHJ2LmMgfCA2ICsrKystLQo+ICAx IGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYXJtL2hkbGNkX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJt L2FybS9oZGxjZF9kcnYuYwo+IGluZGV4IDJlMDUzODE1YjU0YS4uYmQwYWQ2ZjQ2YTk3IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vaGRsY2RfZHJ2LmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYXJtL2hkbGNkX2Rydi5jCj4gQEAgLTIyNiw4ICsyMjYsMTAgQEAgc3RhdGljIHN0 cnVjdCBkcm1faW5mb19saXN0IGhkbGNkX2RlYnVnZnNfbGlzdFtdID0gewo+ICAKPiAgc3RhdGlj IGludCBoZGxjZF9kZWJ1Z2ZzX2luaXQoc3RydWN0IGRybV9taW5vciAqbWlub3IpCj4gIHsKPiAt CXJldHVybiBkcm1fZGVidWdmc19jcmVhdGVfZmlsZXMoaGRsY2RfZGVidWdmc19saXN0LAo+IC0J CUFSUkFZX1NJWkUoaGRsY2RfZGVidWdmc19saXN0KSwJbWlub3ItPmRlYnVnZnNfcm9vdCwgbWlu b3IpOwo+ICsJZHJtX2RlYnVnZnNfY3JlYXRlX2ZpbGVzKGhkbGNkX2RlYnVnZnNfbGlzdCwKPiAr CQkJCSBBUlJBWV9TSVpFKGhkbGNkX2RlYnVnZnNfbGlzdCksCj4gKwkJCQkgbWlub3ItPmRlYnVn ZnNfcm9vdCwgbWlub3IpOwo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgI2VuZGlmCj4KPiAtLSAKPiAy LjI1LjAKPgoKVGhhbmtzIGZvciB5b3VyIHBhdGNoISBJIGhhZCB0byBnbyBpbnRvIHRoZSBNTCBh bmQgZmluZCBvdXQgdGhlIHNlcmllcyB3aGVyZSB0aGlzCnBhdGNoIGJlbG9uZ3MgdG8gYW5kIHNl ZW4gdGhhdCB5b3UgaGF2ZSBhbHJlYWR5IHJlY2VpdmVkIHNvbWUgZmVlZGJhY2ssIGJ1dCBJIHRo aW5rCmEgc3VtbWFyeSBpcyB3b3J0aDoKCi0geW91IHNob3VsZCBsb29rIGlmIGl0IGlzIHBvc3Np YmxlIHRvIG1ha2UgLmRlYnVnZnNfaW5pdCBob29rIHJldHVybiB2b2lkLCBpdCB3b3VsZAogIHNp bXBsaWZ5IHRoZSBjbGVhbnVwIGluIHRoZSBkcml2ZXJzIGJ5IG5vdCBoYXZpbmcgdG8gcmV0dXJu IDAuCi0geW91IHNob3VsZCBwdXQgaW4gZWFjaCBkcml2ZXIgcGF0Y2ggYSBub3RlIHRoYXQgZHJt X2RlYnVnZnNfY3JlYXRlX2ZpbGVzKCkgYWx3YXlzCiAgcmV0dXJucyAwIHNpbmNlIDk4N2Q2NWQw MTM1NiAoZHJtOiBkZWJ1Z2ZzOiBtYWtlIGRybV9kZWJ1Z2ZzX2NyZWF0ZV9maWxlcygpIG5ldmVy IGZhaWwpCiAgc28gdGhhdCBwZW9wbGUgZG9uJ3QgaGF2ZSB0byBodW50IGluIHRoZSBnaXQgaGlz dG9yeSBmb3IgY2x1ZXMuCi0gTWFrZSBhbGwgdGhlIGNoYW5nZXMgaW50byBhIHNlcmllcwoKV2l0 aCB0aGF0LCB5b3UgY2FuIGhhdmUgbXkgQWNrZWQtYnk6IExpdml1IER1ZGF1IDxsaXZpdS5kdWRh dUBhcm0uY29tPgoKQmVzdCByZWdhcmRzLApMaXZpdQoKLS0gCj09PT09PT09PT09PT09PT09PT09 CnwgSSB3b3VsZCBsaWtlIHRvIHwKfCBmaXggdGhlIHdvcmxkLCAgfAp8IGJ1dCB0aGV5J3JlIG5v dCB8CnwgZ2l2aW5nIG1lIHRoZSAgIHwKIFwgc291cmNlIGNvZGUhICAvCiAgLS0tLS0tLS0tLS0t LS0tCiAgICDCr1xfKOODhClfL8KvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=