From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9086AC11D32 for ; Mon, 24 Feb 2020 16:28:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 682E520836 for ; Mon, 24 Feb 2020 16:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582561690; bh=6SBywWytE60ZAELPFUndIoheBRs0SIEAwmcaQ/Ves78=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bBluy/95+9XXpqWIV61n3Vl8hAlNCxS0QdAbQOTPrh7J6Q0/Mq42oDJTK1wsYFo+E xWJREm/UvgabtWunUNqx9EaSK/HX5n0Pahlhwc9ZzzD8qLhfuy0wa8TSLz7fkZRobb 0urtQ2n8fboGGUq6y0WNJZniK2Y4KizxgfqvpTqo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727901AbgBXQ2J (ORCPT ); Mon, 24 Feb 2020 11:28:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:37946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727177AbgBXQ2I (ORCPT ); Mon, 24 Feb 2020 11:28:08 -0500 Received: from localhost (unknown [213.57.247.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98AE42080D; Mon, 24 Feb 2020 16:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582561688; bh=6SBywWytE60ZAELPFUndIoheBRs0SIEAwmcaQ/Ves78=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a/V0EDlpq0YTVwHVkthZGj4bvoDTDsHugS03iiJXHMHDijhRfVxmJmK7bKKvqcigJ b37YMnWgLqWJzLnpjuNEcPCwOyPzv9Tk61h0K4OqR0Dhk8mL/jU+CJuCFIc8hUraf3 q0bD/PQbYpwQjGvuJcGIFz/Jdeake2AvQcp10LR8= Date: Mon, 24 Feb 2020 18:28:04 +0200 From: Leon Romanovsky To: Nicolas Saenz Julienne Cc: Doug Berger , Florian Fainelli , "David S. Miller" , Stefan Wahren , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: bcmgenet: Clear ID_MODE_DIS in EXT_RGMII_OOB_CTRL when not needed Message-ID: <20200224162804.GB4526@unreal> References: <20200224153609.24948-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200224153609.24948-1-nsaenzjulienne@suse.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 24, 2020 at 04:36:09PM +0100, Nicolas Saenz Julienne wrote: > Outdated Raspberry Pi 4 firmware might configure the external PHY as > rgmii although the kernel currently sets it as rgmii-rxid. This makes > connections unreliable as ID_MODE_DIS is left enabled. To avoid this, > explicitly clear that bit whenever we don't need it. > > Signed-off-by: Nicolas Saenz Julienne > Fixes: da38802211cc ("net: bcmgenet: Add RGMII_RXID support") The expectation is that Fixes line comes before SOB line. Thanks