Re: [PATCH 70/89] drm/vc4: hdmi: Remove vc4_dev hdmi pointer

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 7573 bytes --]

Hi Maxime,

I love your patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on robh/for-next v5.6-rc3 next-20200224]
[cannot apply to anholt/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Maxime-Ripard/drm-vc4-Support-BCM2711-Display-Pipeline/20200224-172730
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: nds32-allyesconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/vc4/vc4_hdmi.c: In function 'vc4_cec_read_msg':
>> drivers/gpu/drm/vc4/vc4_hdmi.c:1053:28: error: 'struct vc4_dev' has no member named 'hdmi'
    1053 |  struct cec_msg *msg = &vc4->hdmi->cec_rx_msg;
         |                            ^~
   In file included from include/linux/byteorder/little_endian.h:5,
                    from arch/nds32/include/uapi/asm/byteorder.h:10,
                    from include/asm-generic/bitops/le.h:6,
                    from include/asm-generic/bitops.h:35,
                    from ./arch/nds32/include/generated/asm/bitops.h:1,
                    from include/linux/bitops.h:29,
                    from include/linux/of.h:15,
                    from include/linux/irqdomain.h:35,
                    from include/linux/acpi.h:13,
                    from include/linux/i2c.h:13,
                    from include/drm/drm_crtc.h:28,
                    from include/drm/drm_atomic_helper.h:31,
                    from drivers/gpu/drm/vc4/vc4_hdmi.c:34:
   drivers/gpu/drm/vc4/vc4_hdmi.h:97:33: error: 'vc4_hdmi' undeclared (first use in this function)
      97 | #define HDMI_READ(offset) readl(vc4_hdmi->hdmicore_regs + offset)
         |                                 ^~~~~~~~
   include/uapi/linux/byteorder/little_endian.h:34:51: note: in definition of macro '__le32_to_cpu'
      34 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
         |                                                   ^
   arch/nds32/include/asm/io.h:76:31: note: in expansion of macro 'readl_relaxed'
      76 | #define readl(c) ({ u32 __v = readl_relaxed(c); __iormb(); __v; })
         |                               ^~~~~~~~~~~~~
   drivers/gpu/drm/vc4/vc4_hdmi.h:97:27: note: in expansion of macro 'readl'
      97 | #define HDMI_READ(offset) readl(vc4_hdmi->hdmicore_regs + offset)
         |                           ^~~~~
   drivers/gpu/drm/vc4/vc4_hdmi.c:1059:13: note: in expansion of macro 'HDMI_READ'
    1059 |   u32 val = HDMI_READ(VC4_HDMI_CEC_RX_DATA_1 + i);
         |             ^~~~~~~~~
   drivers/gpu/drm/vc4/vc4_hdmi.h:97:33: note: each undeclared identifier is reported only once for each function it appears in
      97 | #define HDMI_READ(offset) readl(vc4_hdmi->hdmicore_regs + offset)
         |                                 ^~~~~~~~
   include/uapi/linux/byteorder/little_endian.h:34:51: note: in definition of macro '__le32_to_cpu'
      34 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
         |                                                   ^
   arch/nds32/include/asm/io.h:76:31: note: in expansion of macro 'readl_relaxed'
      76 | #define readl(c) ({ u32 __v = readl_relaxed(c); __iormb(); __v; })
         |                               ^~~~~~~~~~~~~
   drivers/gpu/drm/vc4/vc4_hdmi.h:97:27: note: in expansion of macro 'readl'
      97 | #define HDMI_READ(offset) readl(vc4_hdmi->hdmicore_regs + offset)
         |                           ^~~~~
   drivers/gpu/drm/vc4/vc4_hdmi.c:1059:13: note: in expansion of macro 'HDMI_READ'
    1059 |   u32 val = HDMI_READ(VC4_HDMI_CEC_RX_DATA_1 + i);
         |             ^~~~~~~~~
   drivers/gpu/drm/vc4/vc4_hdmi.c: In function 'vc4_cec_irq_handler':
   drivers/gpu/drm/vc4/vc4_hdmi.c:1081:20: error: 'vc4' undeclared (first use in this function)
    1081 |   vc4_cec_read_msg(vc4, cntrl1);
         |                    ^~~
   drivers/gpu/drm/vc4/vc4_hdmi.c: In function 'vc4_hdmi_bind':
   drivers/gpu/drm/vc4/vc4_hdmi.c:1294:12: error: 'vc4' undeclared (first use in this function)
    1294 |            vc4, "vc4",
         |            ^~~
   drivers/gpu/drm/vc4/vc4_hdmi.c:1301:42: error: 'hdmi' undeclared (first use in this function)
    1301 |  cec_fill_conn_info_from_drm(&conn_info, hdmi->connector);
         |                                          ^~~~
   drivers/gpu/drm/vc4/vc4_hdmi.c:1321:49: error: passing argument 2 of 'cec_register_adapter' from incompatible pointer type [-Werror=incompatible-pointer-types]
    1321 |  ret = cec_register_adapter(vc4_hdmi->cec_adap, vc4_hdmi);
         |                                                 ^~~~~~~~
         |                                                 |
         |                                                 struct vc4_hdmi *
   In file included from drivers/gpu/drm/vc4/vc4_hdmi.c:49:
   include/media/cec.h:242:67: note: expected 'struct device *' but argument is of type 'struct vc4_hdmi *'
     242 | int cec_register_adapter(struct cec_adapter *adap, struct device *parent);
         |                                                    ~~~~~~~~~~~~~~~^~~~~~
   cc1: some warnings being treated as errors

vim +1053 drivers/gpu/drm/vc4/vc4_hdmi.c

15b4511a4af633 Hans Verkuil 2017-07-16  1050  
15b4511a4af633 Hans Verkuil 2017-07-16  1051  static void vc4_cec_read_msg(struct vc4_dev *vc4, u32 cntrl1)
15b4511a4af633 Hans Verkuil 2017-07-16  1052  {
15b4511a4af633 Hans Verkuil 2017-07-16 @1053  	struct cec_msg *msg = &vc4->hdmi->cec_rx_msg;
15b4511a4af633 Hans Verkuil 2017-07-16  1054  	unsigned int i;
15b4511a4af633 Hans Verkuil 2017-07-16  1055  
15b4511a4af633 Hans Verkuil 2017-07-16  1056  	msg->len = 1 + ((cntrl1 & VC4_HDMI_CEC_REC_WRD_CNT_MASK) >>
15b4511a4af633 Hans Verkuil 2017-07-16  1057  					VC4_HDMI_CEC_REC_WRD_CNT_SHIFT);
15b4511a4af633 Hans Verkuil 2017-07-16  1058  	for (i = 0; i < msg->len; i += 4) {
15b4511a4af633 Hans Verkuil 2017-07-16  1059  		u32 val = HDMI_READ(VC4_HDMI_CEC_RX_DATA_1 + i);
15b4511a4af633 Hans Verkuil 2017-07-16  1060  
15b4511a4af633 Hans Verkuil 2017-07-16  1061  		msg->msg[i] = val & 0xff;
15b4511a4af633 Hans Verkuil 2017-07-16  1062  		msg->msg[i + 1] = (val >> 8) & 0xff;
15b4511a4af633 Hans Verkuil 2017-07-16  1063  		msg->msg[i + 2] = (val >> 16) & 0xff;
15b4511a4af633 Hans Verkuil 2017-07-16  1064  		msg->msg[i + 3] = (val >> 24) & 0xff;
15b4511a4af633 Hans Verkuil 2017-07-16  1065  	}
15b4511a4af633 Hans Verkuil 2017-07-16  1066  }
15b4511a4af633 Hans Verkuil 2017-07-16  1067  

:::::: The code at line 1053 was first introduced by commit
:::::: 15b4511a4af633dca0762ae5646fdf05f1dea99a drm/vc4: add HDMI CEC support

:::::: TO: Hans Verkuil <hans.verkuil@cisco.com>
:::::: CC: Eric Anholt <eric@anholt.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 55035 bytes --]