From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_RHS_DOB,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D9E7C38BFA for ; Mon, 24 Feb 2020 23:02:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 155752084E for ; Mon, 24 Feb 2020 23:02:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="g8TjKjLK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728252AbgBXXCn (ORCPT ); Mon, 24 Feb 2020 18:02:43 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:33964 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727520AbgBXXCn (ORCPT ); Mon, 24 Feb 2020 18:02:43 -0500 Received: by mail-pf1-f193.google.com with SMTP id i6so6128619pfc.1 for ; Mon, 24 Feb 2020 15:02:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ldA4LWx49G9fDrD0CkVc1pzxiI4d+Sy4jLQFiaVM9xU=; b=g8TjKjLKNIBO2D8CGQcYULm47D6iMk0FIVAKiVf84LK8Q6xQY8PDl7MVYsAPvX7KEY AzpCL3HKDCrJFzusM4SALGWGqHr0UzdcYjOpJyv8TLlDY/JtUAwL5Dj7Sb+MO74ifL05 mLLSpzj+3ImqGLUYpVZPX+hzzcVqWCBLcFr0M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ldA4LWx49G9fDrD0CkVc1pzxiI4d+Sy4jLQFiaVM9xU=; b=gj+HZ7NtRFCiLXFeyG/Hjmhytuo9pwgscxzIkGgq5RGeGdlxYIgA74+Q1/DLyul1x/ tvBove8K14wcwut7x3vk+WR+OqCqNnXy//VdMVgISRH8EqEOMLqJoKuk35DmrPuKNvA2 kb/W/yQQ75AFlHSBEN6z0vGFZFyvTuI8NL3+Il08OH2UIkw4C8XU7GVlSaOqkaXCGFCQ y5oqY/kz+N1e3iZN+kFcVH3kPElDS888JRHh9yl3pjCyffOMGrHavaRgf89Zl+5t0bOn Slr1HZ7dSUqAh15vnivJ7XREw/zGEbDuWbzQBNFi4bBo3gODj5/vYdQdfak0cxnNP0mk XFlA== X-Gm-Message-State: APjAAAX22eYI/e6R92A29JWyu3bxgh4NNP9srabUFPP4NMQYmZPpiDOs X5KJeBL94/utWArXeQHfRUH2jg== X-Google-Smtp-Source: APXvYqzcx9K3pY/r6VjSAJPclXgYJvtvca4YnsuafbQoX3P7F/kO3KX+wZH5N5OVmthENB1g8vpPWg== X-Received: by 2002:a65:420b:: with SMTP id c11mr53216300pgq.297.1582585362661; Mon, 24 Feb 2020 15:02:42 -0800 (PST) Received: from google.com ([2620:15c:202:201:476b:691:abc3:38db]) by smtp.gmail.com with ESMTPSA id 13sm13990169pfi.78.2020.02.24.15.02.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2020 15:02:42 -0800 (PST) Date: Mon, 24 Feb 2020 15:02:40 -0800 From: Prashant Malani To: You-Sheng Yang Cc: "David S . Miller" , Hayes Wang , Jakub Kicinski , Kai-Heng Feng , Grant Grundler , You-Sheng Yang , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: r8151: check disconnect status after long sleep Message-ID: <20200224230240.GA9642@google.com> References: <20200224071541.117363-1-vicamo.yang@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200224071541.117363-1-vicamo.yang@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org nit: The commit message title tag should be "r8152", instead of "r8151". On Mon, Feb 24, 2020 at 03:15:41PM +0800, You-Sheng Yang wrote: > Dell USB Type C docking WD19/WD19DC attaches additional peripherals as: > > /: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/6p, 5000M > |__ Port 1: Dev 11, If 0, Class=Hub, Driver=hub/4p, 5000M > |__ Port 3: Dev 12, If 0, Class=Hub, Driver=hub/4p, 5000M > |__ Port 4: Dev 13, If 0, Class=Vendor Specific Class, > Driver=r8152, 5000M > > where usb 2-1-3 is a hub connecting all USB Type-A/C ports on the dock. > > When hotplugging such dock with additional usb devices already attached on > it, the probing process may reset usb 2.1 port, therefore r8152 ethernet > device is also reset. However, during r8152 device init there are several > for-loops that, when it's unable to retrieve hardware registers due to > being discconected from USB, may take up to 14 seconds each in practice, > and that has to be completed before USB may re-enumerate devices on the > bus. As a result, devices attached to the dock will only be available > after nearly 1 minute after the dock was plugged in: > > [ 216.388290] [250] r8152 2-1.4:1.0: usb_probe_interface > [ 216.388292] [250] r8152 2-1.4:1.0: usb_probe_interface - got id > [ 258.830410] r8152 2-1.4:1.0 (unnamed net_device) (uninitialized): PHY not ready > [ 258.830460] r8152 2-1.4:1.0 (unnamed net_device) (uninitialized): Invalid header when reading pass-thru MAC addr > [ 258.830464] r8152 2-1.4:1.0 (unnamed net_device) (uninitialized): Get ether addr fail > > This can be reproduced on all kernel versions up to latest v5.6-rc2, but > after v5.5-rc7 the reproduce rate is dramatically lower to 1/30 or so > while it was around 1/2. > > The time consuming for-loops are at: > https://elixir.bootlin.com/linux/v5.5/source/drivers/net/usb/r8152.c#L3206 > https://elixir.bootlin.com/linux/v5.5/source/drivers/net/usb/r8152.c#L5400 > https://elixir.bootlin.com/linux/v5.5/source/drivers/net/usb/r8152.c#L5537 > > Signed-off-by: You-Sheng Yang > --- > drivers/net/usb/r8152.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index 78ddbaf6401b..95b19ce96513 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -3221,6 +3221,8 @@ static u16 r8153_phy_status(struct r8152 *tp, u16 desired) > } > > msleep(20); > + if (test_bit(RTL8152_UNPLUG, &tp->flags)) > + break; > } > > return data; > @@ -5402,7 +5404,10 @@ static void r8153_init(struct r8152 *tp) > if (ocp_read_word(tp, MCU_TYPE_PLA, PLA_BOOT_CTRL) & > AUTOLOAD_DONE) > break; > + > msleep(20); > + if (test_bit(RTL8152_UNPLUG, &tp->flags)) > + break; > } > > data = r8153_phy_status(tp, 0); > @@ -5539,7 +5544,10 @@ static void r8153b_init(struct r8152 *tp) > if (ocp_read_word(tp, MCU_TYPE_PLA, PLA_BOOT_CTRL) & > AUTOLOAD_DONE) > break; > + > msleep(20); > + if (test_bit(RTL8152_UNPLUG, &tp->flags)) > + break; > } > > data = r8153_phy_status(tp, 0); > -- > 2.25.0 >