Re: [RFC] Buildfailure due to mising "select REGMAP_I2C"

[Sakari Ailus <sakari.ailus@linux.intel.com>]

On Tue, Feb 25, 2020 at 08:56:34AM +0100, Ian Kumlien wrote:
> On Tue, Feb 25, 2020 at 8:51 AM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> >
> > Hi Ian,
> >
> > Thank you for the patch.
> >
> > On Mon, Feb 24, 2020 at 11:35:54PM +0100, Ian Kumlien wrote:
> > > Hi,
> > >
> > > I got surprised by:
> > > ld: drivers/media/i2c/tvp5150.o: in function `tvp5150_probe':
> > > tvp5150.c:(.text+0x11ac): undefined reference to `__devm_regmap_init_i2c'
> > > make: *** [Makefile:1078: vmlinux] Error 1
> > >
> > > When going from 5.5.2 -> 5.5.6
> > >
> > > A quick git grep shows that something like this might be needed, but
> > > it should be verified.
> > > I'm really uncertain about the ones that say REGMAP_SCCB...
> >
> > Those don't need REGMAP_I2C for they use SCCB.
> 
> I would have to read up, =)
> 
> > Please also do not send attachments; your mail is likely consumed by some
> > list servers that way.
> 
> Ok
> 
> [..8<..]
> > >           This is a Video4Linux2 sensor driver for the Sony
> > > @@ -774,6 +778,7 @@ config VIDEO_OV7251
> > >  config VIDEO_OV772X
> > >         tristate "OmniVision OV772x sensor support"
> > >         depends on I2C && VIDEO_V4L2
> > > +       select REGMAP_I2C
> >
> > So this isn't needed.
> 
> Ok
> 
> > >         select REGMAP_SCCB
> > >         help
> > >           This is a Video4Linux2 sensor driver for the OmniVision
> > > @@ -804,6 +809,7 @@ config VIDEO_OV7670
> > >  config VIDEO_OV7740
> > >         tristate "OmniVision OV7740 sensor support"
> > >         depends on I2C && VIDEO_V4L2
> > > +       select REGMAP_I2C
> > >         help
> > >           This is a Video4Linux2 sensor driver for the OmniVision
> > >           OV7740 VGA camera sensor.
> > > @@ -829,6 +835,7 @@ config VIDEO_OV9640
> > >  config VIDEO_OV9650
> > >         tristate "OmniVision OV9650/OV9652 sensor support"
> > >         depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> > > +       select REGMAP_I2C
> >
> > Nor this one.
> 
> Ok
> 
> > >         select REGMAP_SCCB
> > >         help
> > >           This is a V4L2 sensor driver for the Omnivision
> >
> > Could you send v2, please, removing those two?
> 
> Yep, like this one:

Yes, like that one.

> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index c68e002d26ea..1d1170de8c98 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -238,6 +238,7 @@ config VIDEO_ADV7604
>         tristate "Analog Devices ADV7604 decoder"
>         depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
>         depends on GPIOLIB || COMPILE_TEST
> +       select REGMAP_I2C
>         select HDMI
>         select V4L2_FWNODE
>         help
> @@ -379,6 +380,7 @@ config VIDEO_TVP5150
>         tristate "Texas Instruments TVP5150 video decoder"
>         depends on VIDEO_V4L2 && I2C
>         select V4L2_FWNODE
> +       select REGMAP_I2C
>         help
>           Support for the Texas Instruments TVP5150 video decoder.
> 
> @@ -584,6 +586,7 @@ config VIDEO_IMX214
>         tristate "Sony IMX214 sensor support"
>         depends on GPIOLIB && I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
>         depends on V4L2_FWNODE
> +       select REGMAP_I2C
>         help
>           This is a Video4Linux2 sensor driver for the Sony
>           IMX214 camera.
> @@ -612,6 +615,7 @@ config VIDEO_IMX274
>  config VIDEO_IMX290
>         tristate "Sony IMX290 sensor support"
>         depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> +       select REGMAP_I2C
>         select V4L2_FWNODE
>         help
>           This is a Video4Linux2 sensor driver for the Sony
> @@ -804,6 +808,7 @@ config VIDEO_OV7670
>  config VIDEO_OV7740
>         tristate "OmniVision OV7740 sensor support"
>         depends on I2C && VIDEO_V4L2
> +       select REGMAP_I2C
>         help
>           This is a Video4Linux2 sensor driver for the OmniVision
>           OV7740 VGA camera sensor.

-- 
Sakari Ailus