From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60CD3C35DF5 for ; Tue, 25 Feb 2020 12:56:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E05021556 for ; Tue, 25 Feb 2020 12:56:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729602AbgBYM4d (ORCPT ); Tue, 25 Feb 2020 07:56:33 -0500 Received: from mga11.intel.com ([192.55.52.93]:35478 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbgBYM4c (ORCPT ); Tue, 25 Feb 2020 07:56:32 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Feb 2020 04:56:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,484,1574150400"; d="scan'208";a="350143671" Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.163]) by fmsmga001.fm.intel.com with SMTP; 25 Feb 2020 04:56:30 -0800 Received: by lahna (sSMTP sendmail emulation); Tue, 25 Feb 2020 14:56:29 +0200 Date: Tue, 25 Feb 2020 14:56:29 +0200 From: Mika Westerberg To: Nicholas Johnson Cc: "linux-kernel@vger.kernel.org" , Srinivas Kandagatla Subject: Re: [PATCH v1 2/3] Revert "thunderbolt: Prevent crash if non-active NVMem file is read" Message-ID: <20200225125629.GB2667@lahna.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 24, 2020 at 05:43:05PM +0000, Nicholas Johnson wrote: > This reverts commit 03cd45d2e219301880cabc357e3cf478a500080f. > > Since commit cd76ed9e5913 ("nvmem: add support for write-only > instances"), this work around is no longer required, so drop it. I don't think you can refer commits that only exists in your local tree. I would just say that "since NVMem subsystem gained support for write-only instances this workaround is not needed anymore" or somesuch. Otherwise this looks good to me, no objections and thanks for doing this :)