All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"John Snow" <jsnow@redhat.com>
Subject: [PATCH v3 01/12] qapi/qapi-schema.json: Put headers in their own doc-comment blocks
Date: Tue, 25 Feb 2020 14:04:26 +0000	[thread overview]
Message-ID: <20200225140437.20609-2-peter.maydell@linaro.org> (raw)
In-Reply-To: <20200225140437.20609-1-peter.maydell@linaro.org>

Our current QAPI doc-comment markup allows section headers
(introduced with a leading '=' or '==') anywhere in any documentation
comment.  This works for texinfo because the texi generator simply
prints a texinfo heading directive at that point in the output
stream.  For rST generation, since we're assembling a tree of
docutils nodes, this is awkward because a new section implies
starting a new section node at the top level of the tree and
generating text into there.

New section headings in the middle of the documentation of a command
or event would be pretty nonsensical, and in fact we only ever output
new headings using 'freeform' doc comment blocks whose only content
is the single line of the heading, with two exceptions, which are in
the introductory freeform-doc-block at the top of
qapi/qapi-schema.json.

Split that doc-comment up so that the heading lines are in their own
doc-comment.  This will allow us to tighten the specification to
insist that heading lines are always standalone, rather than
requiring the rST document generator to look at every line in a doc
comment block and handle headings in odd places.

This change makes no difference to the generated texi.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 qapi/qapi-schema.json | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/qapi/qapi-schema.json b/qapi/qapi-schema.json
index fe980ce4370..ff5aea59451 100644
--- a/qapi/qapi-schema.json
+++ b/qapi/qapi-schema.json
@@ -1,7 +1,9 @@
 # -*- Mode: Python -*-
 ##
 # = Introduction
-#
+##
+
+##
 # This document describes all commands currently supported by QMP.
 #
 # Most of the time their usage is exactly the same as in the user Monitor, this
@@ -25,9 +27,13 @@
 #
 # Please, refer to the QMP specification (docs/interop/qmp-spec.txt) for
 # detailed information on the Server command and response formats.
-#
+##
+
+##
 # = Stability Considerations
-#
+##
+
+##
 # The current QMP command set (described in this file) may be useful for a
 # number of use cases, however it's limited and several commands have bad
 # defined semantics, specially with regard to command completion.
-- 
2.20.1



  reply	other threads:[~2020-02-25 14:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25 14:04 [PATCH v3 00/12] Convert QAPI doc comments to generate rST instead of texinfo Peter Maydell
2020-02-25 14:04 ` Peter Maydell [this message]
2020-02-27 13:53   ` [PATCH v3 01/12] qapi/qapi-schema.json: Put headers in their own doc-comment blocks Richard Henderson
2020-02-25 14:04 ` [PATCH v3 02/12] qapi/machine.json: Escape a literal '*' in doc comment Peter Maydell
2020-02-27 13:56   ` Richard Henderson
2020-02-25 14:04 ` [PATCH v3 03/12] tests/qapi/doc-good.json: Clean up markup Peter Maydell
2020-02-27 13:58   ` Richard Henderson
2020-02-25 14:04 ` [PATCH v3 04/12] scripts/qapi: Move doc-comment whitespace stripping to doc.py Peter Maydell
2020-02-27 13:59   ` Richard Henderson
2020-02-25 14:04 ` [PATCH v3 05/12] scripts/qapi/parser.py: improve doc comment indent handling Peter Maydell
2020-02-27 14:13   ` Richard Henderson
2020-02-25 14:04 ` [PATCH v3 06/12] docs/sphinx: Add new qapi-doc Sphinx extension Peter Maydell
2020-02-25 14:04 ` [PATCH v3 07/12] docs/interop: Convert qemu-ga-ref to rST Peter Maydell
2020-02-25 14:04 ` [PATCH v3 08/12] docs/interop: Convert qemu-qmp-ref " Peter Maydell
2020-02-25 14:04 ` [PATCH v3 09/12] qapi: Use rST markup for literal blocks Peter Maydell
2020-02-25 14:04 ` [PATCH v3 10/12] qga/qapi-schema.json: Add some headings Peter Maydell
2020-02-25 14:04 ` [PATCH v3 11/12] scripts/qapi: Remove texinfo generation support Peter Maydell
2020-02-25 14:04 ` [PATCH v3 12/12] docs/devel/qapi-code-gen.txt: Update to new rST backend conventions Peter Maydell
2020-02-26 11:45 ` [PATCH v3 00/12] Convert QAPI doc comments to generate rST instead of texinfo Markus Armbruster
2020-03-06 17:30 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200225140437.20609-2-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.