From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 776096E22D for ; Tue, 25 Feb 2020 16:56:37 +0000 (UTC) From: Arkadiusz Hiler Date: Tue, 25 Feb 2020 18:56:16 +0200 Message-ID: <20200225165616.214073-1-arkadiusz.hiler@intel.com> In-Reply-To: <20200225165246.213606-1-arkadiusz.hiler@intel.com> References: <20200225165246.213606-1-arkadiusz.hiler@intel.com> MIME-Version: 1.0 Subject: [igt-dev] [PATCH i-g-t 6/9] lib/chamelium: Clear error after checking if chamelium is reachable List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org Cc: Petri Latvala List-ID: Otherwise this may get us stuck in perpetual failure mode. Signed-off-by: Arkadiusz Hiler Reviewed-by: Petri Latvala --- lib/igt_chamelium.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c index aaf17d51..b347682d 100644 --- a/lib/igt_chamelium.c +++ b/lib/igt_chamelium.c @@ -361,11 +361,17 @@ static bool __chamelium_is_reachable(struct chamelium *chamelium) if (res != NULL) xmlrpc_DECREF(res); - if (chamelium->env.fault_occurred) + if (chamelium->env.fault_occurred) { igt_debug("Chamelium RPC call failed: %s\n", chamelium->env.fault_string); - return !chamelium->env.fault_occurred; + xmlrpc_env_clean(&chamelium->env); + xmlrpc_env_init(&chamelium->env); + + return false; + } + + return true; } void chamelium_wait_reachable(struct chamelium *chamelium, int timeout) -- 2.24.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev