From: Christoph Hellwig <hch@infradead.org>
To: "Daniel Glöckner" <dg@emlix.com>
Cc: Mike Snitzer <snitzer@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [dm-devel] [PATCH] dm integrity: reinitialize __bi_remaining when reusing bio
Date: Tue, 25 Feb 2020 11:12:22 -0800 [thread overview]
Message-ID: <20200225191222.GA3908@infradead.org> (raw)
In-Reply-To: <20200225170744.10485-1-dg@emlix.com>
On Tue, Feb 25, 2020 at 06:07:44PM +0100, Daniel Glöckner wrote:
> In cases where dec_in_flight has to requeue the integrity_bio_wait work
> to transfer the rest of the data, the __bi_remaining field of the bio
> might already have been decremented to zero. Reusing the bio without
> reinitializing that counter to 1 can then result in integrity_end_io
> being called too early when the BIO_CHAIN flag is set, f.ex. due to
> blk_queue_split. In our case this triggered the BUG() in
> blk_mq_end_request when the hardware signalled completion of the bio
> after integrity_end_io had modified it.
>
> Signed-off-by: Daniel Glöckner <dg@emlix.com>
Drivers have no business poking into these internals. If a bio is
reused the caller needs to use bio_reset instead.
next prev parent reply other threads:[~2020-02-25 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 17:07 [PATCH] dm integrity: reinitialize __bi_remaining when reusing bio Daniel Glöckner
2020-02-25 17:07 ` Daniel Glöckner
2020-02-25 19:12 ` Christoph Hellwig [this message]
2020-02-25 19:54 ` [dm-devel] " Daniel Glöckner
2020-02-25 22:02 ` Christoph Hellwig
2020-02-26 1:22 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225191222.GA3908@infradead.org \
--to=hch@infradead.org \
--cc=dg@emlix.com \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.