From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E302FC4BA04 for ; Tue, 25 Feb 2020 23:02:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0BF821927 for ; Tue, 25 Feb 2020 23:02:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582671762; bh=Iv76P/KnGuVmrizES/J6M1T/2JeyyQFG+D1jNICgXPk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CpGEkgd5wneRF6OTDXn8KvyjPaYHsYePcZKMqDdSbeswcyilNzaqJPqBMwwwmbUOs khfXmYd3eYl9ukYcVODPwfhK5GrpQXgxsxGOq7fkdUHFwFhChgpGvKJyXBGNoLC3Tu LcqzD07IuaKbUTTOe9AcyLFegAzZI8mYz61HaHbw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728806AbgBYXCm (ORCPT ); Tue, 25 Feb 2020 18:02:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:43354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726827AbgBYXCl (ORCPT ); Tue, 25 Feb 2020 18:02:41 -0500 Received: from earth.universe (unknown [185.62.205.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA92A20838; Tue, 25 Feb 2020 23:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582671761; bh=Iv76P/KnGuVmrizES/J6M1T/2JeyyQFG+D1jNICgXPk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NP0hcXZLzk3oyikYtLt4H3rxtr3sutW+Q2P/X3Gg9tg95oTR/TPHRPoTGCJr8uIwv wDQfkRJo5XYx9izFyE6ls45CWOm4s4qq+HHrhTw0++j9kH90PBhkx4D3xFF3C/nqJU 7zYMbIo7oLEK/zd9Ww47dITrP/NwDF2X3NT7lmpQ= Received: by earth.universe (Postfix, from userid 1000) id 8D6A63C0C83; Wed, 26 Feb 2020 00:01:24 +0100 (CET) Date: Wed, 26 Feb 2020 00:01:24 +0100 From: Sebastian Reichel To: Tony Lindgren Cc: Laurent Pinchart , Tomi Valkeinen , Merlijn Wajer , "H. Nikolaus Schaller" , Rob Herring , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@collabora.com Subject: Re: [PATCHv2 00/56] drm/omap: Convert DSI code to use drm_mipi_dsi and drm_panel Message-ID: <20200225230124.fkt35ihyjnokb2ng@earth.universe> References: <20200224232126.3385250-1-sebastian.reichel@collabora.com> <20200225001011.GF37466@atomide.com> <20200225022822.wh7omykthv7skojy@earth.universe> <20200225154237.GH37466@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ig3uwjrwvdoaax6g" Content-Disposition: inline In-Reply-To: <20200225154237.GH37466@atomide.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org --ig3uwjrwvdoaax6g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Feb 25, 2020 at 07:42:37AM -0800, Tony Lindgren wrote: > * Sebastian Reichel [200225 02:29]: > > On Mon, Feb 24, 2020 at 04:10:11PM -0800, Tony Lindgren wrote: > > > BTW, I think there's also some refcount issue in general where > > > the omapdrm related modules cannot be unloaded any longer? > >=20 > > I wouldn't be too surprised. The dependencies are quite interesting > > at the moment with omapdss registering omapdrm and then omapdrm > > registers the drm_device, which references the encoders from > > omapdss. I think this is something to look at once Laurent's and > > my branch have been merged to avoid increasing the complexity. > > Technically it should be possible to link everything into one > > module. >=20 > Well the DSS is really DOSSI for Display Output SubSystem > Interconnect :) The devices on the interconnect are mostly > independent and ideally the toplevel dss driver would just > provide Linux generic resources to dispc and various output > drivers. So probably not a good idea to try to build it all > into a single module. All the output drivers and dispc are already in a single module: omapdss.ko. There is omapdss-base.ko, omapdss.ko and omapdrm.ko module. omapdss-base.ko contains a few helpers, omapdss.ko contains dispc and all output encoders, omapdrm has the tiler code and wraps some of the custom DSS APIs to DRM APIs. I think the best way forward is to eliminate the custom API and use common DRM APIs directly. Then merge all 3 modules into one module. In theory one could add modules for each encoder, but practically this only increases complexity. DRM cannnot hotplug encoders, so removing any module results in complete loss of DRM. Also during probe we need to load all modules, since something might be connected. So having extra modules is not really useful? -- Sebastian --ig3uwjrwvdoaax6g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl5Vpz4ACgkQ2O7X88g7 +pqyWw/8CpE5swdKf450a1xBFcxYUp8leUTzSt9xXyXUNtOT1YB2H52G7oClWxxS MWEHa4Da2MBTzjio+58NB3zP6i4tgrhOTp//ys/fDXYygHOQammR8yQS7hJ6KdYv eWQYLN6iERjJAqG+n3wI9JItbmMaMNO4IL2r6DtnDX1GSTShiTNJRfKfz6Y/hjyz pdGwtVzLEf7Cu7dibMD3SUkUnD58nfjOo2wRspJCWWHM2ZhuJgIufLA3FofZp6MD m1Xl4ZSD4Yyc7HnCv5YPuWPV1aZ+LQwPmKcZf9BJLdxXxLvTmxtknQlYNwIy92mr uvnGN2iGyJ/U35fwPxS9zWtmf+reZBDcXy5Mx4tmvtcL2rdcpZ4/QYAefp2nstqI uzN42hTXmC86+9S51+2TKUsA75U/HkwjK+6toPY842TE4qJQso5ulQjh5pXziYE9 E3CzyBnBe028FQ/er1O0okKjcku4ctTl3G1tp06nBe2oEJ18ksWBzcmpB+Ye69q8 eg1SNU3aezTqa1va5VGiEbHLhf/dlw9+wli55rx55/EguSTjxozyknxQjjK2rQcy L+HX1XGvTAvtd0qW3odn8x54ZREHhysINsbPcMuOUcadPj7fh6szfUMP7aqQkGDh ixQ22wsIg6bLbWxwdImvrnFNuh9Mg5PJZY4B6W/fZYnhlH3aL0Y= =xIxH -----END PGP SIGNATURE----- --ig3uwjrwvdoaax6g-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 622D2C4BA04 for ; Tue, 25 Feb 2020 23:02:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3688B21927 for ; Tue, 25 Feb 2020 23:02:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="NP0hcXZL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3688B21927 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A7906E03B; Tue, 25 Feb 2020 23:02:42 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 448606E03B for ; Tue, 25 Feb 2020 23:02:41 +0000 (UTC) Received: from earth.universe (unknown [185.62.205.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA92A20838; Tue, 25 Feb 2020 23:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582671761; bh=Iv76P/KnGuVmrizES/J6M1T/2JeyyQFG+D1jNICgXPk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NP0hcXZLzk3oyikYtLt4H3rxtr3sutW+Q2P/X3Gg9tg95oTR/TPHRPoTGCJr8uIwv wDQfkRJo5XYx9izFyE6ls45CWOm4s4qq+HHrhTw0++j9kH90PBhkx4D3xFF3C/nqJU 7zYMbIo7oLEK/zd9Ww47dITrP/NwDF2X3NT7lmpQ= Received: by earth.universe (Postfix, from userid 1000) id 8D6A63C0C83; Wed, 26 Feb 2020 00:01:24 +0100 (CET) Date: Wed, 26 Feb 2020 00:01:24 +0100 From: Sebastian Reichel To: Tony Lindgren Subject: Re: [PATCHv2 00/56] drm/omap: Convert DSI code to use drm_mipi_dsi and drm_panel Message-ID: <20200225230124.fkt35ihyjnokb2ng@earth.universe> References: <20200224232126.3385250-1-sebastian.reichel@collabora.com> <20200225001011.GF37466@atomide.com> <20200225022822.wh7omykthv7skojy@earth.universe> <20200225154237.GH37466@atomide.com> MIME-Version: 1.0 In-Reply-To: <20200225154237.GH37466@atomide.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@collabora.com, "H. Nikolaus Schaller" , Merlijn Wajer , dri-devel@lists.freedesktop.org, Tomi Valkeinen , Laurent Pinchart , linux-omap@vger.kernel.org Content-Type: multipart/mixed; boundary="===============0938665393==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0938665393== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ig3uwjrwvdoaax6g" Content-Disposition: inline --ig3uwjrwvdoaax6g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Feb 25, 2020 at 07:42:37AM -0800, Tony Lindgren wrote: > * Sebastian Reichel [200225 02:29]: > > On Mon, Feb 24, 2020 at 04:10:11PM -0800, Tony Lindgren wrote: > > > BTW, I think there's also some refcount issue in general where > > > the omapdrm related modules cannot be unloaded any longer? > >=20 > > I wouldn't be too surprised. The dependencies are quite interesting > > at the moment with omapdss registering omapdrm and then omapdrm > > registers the drm_device, which references the encoders from > > omapdss. I think this is something to look at once Laurent's and > > my branch have been merged to avoid increasing the complexity. > > Technically it should be possible to link everything into one > > module. >=20 > Well the DSS is really DOSSI for Display Output SubSystem > Interconnect :) The devices on the interconnect are mostly > independent and ideally the toplevel dss driver would just > provide Linux generic resources to dispc and various output > drivers. So probably not a good idea to try to build it all > into a single module. All the output drivers and dispc are already in a single module: omapdss.ko. There is omapdss-base.ko, omapdss.ko and omapdrm.ko module. omapdss-base.ko contains a few helpers, omapdss.ko contains dispc and all output encoders, omapdrm has the tiler code and wraps some of the custom DSS APIs to DRM APIs. I think the best way forward is to eliminate the custom API and use common DRM APIs directly. Then merge all 3 modules into one module. In theory one could add modules for each encoder, but practically this only increases complexity. DRM cannnot hotplug encoders, so removing any module results in complete loss of DRM. Also during probe we need to load all modules, since something might be connected. So having extra modules is not really useful? -- Sebastian --ig3uwjrwvdoaax6g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl5Vpz4ACgkQ2O7X88g7 +pqyWw/8CpE5swdKf450a1xBFcxYUp8leUTzSt9xXyXUNtOT1YB2H52G7oClWxxS MWEHa4Da2MBTzjio+58NB3zP6i4tgrhOTp//ys/fDXYygHOQammR8yQS7hJ6KdYv eWQYLN6iERjJAqG+n3wI9JItbmMaMNO4IL2r6DtnDX1GSTShiTNJRfKfz6Y/hjyz pdGwtVzLEf7Cu7dibMD3SUkUnD58nfjOo2wRspJCWWHM2ZhuJgIufLA3FofZp6MD m1Xl4ZSD4Yyc7HnCv5YPuWPV1aZ+LQwPmKcZf9BJLdxXxLvTmxtknQlYNwIy92mr uvnGN2iGyJ/U35fwPxS9zWtmf+reZBDcXy5Mx4tmvtcL2rdcpZ4/QYAefp2nstqI uzN42hTXmC86+9S51+2TKUsA75U/HkwjK+6toPY842TE4qJQso5ulQjh5pXziYE9 E3CzyBnBe028FQ/er1O0okKjcku4ctTl3G1tp06nBe2oEJ18ksWBzcmpB+Ye69q8 eg1SNU3aezTqa1va5VGiEbHLhf/dlw9+wli55rx55/EguSTjxozyknxQjjK2rQcy L+HX1XGvTAvtd0qW3odn8x54ZREHhysINsbPcMuOUcadPj7fh6szfUMP7aqQkGDh ixQ22wsIg6bLbWxwdImvrnFNuh9Mg5PJZY4B6W/fZYnhlH3aL0Y= =xIxH -----END PGP SIGNATURE----- --ig3uwjrwvdoaax6g-- --===============0938665393== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0938665393==--