From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH/RFC 3/3] drm: rcar_du: Constify drm_driver
Date: Wed, 26 Feb 2020 03:54:13 +0200 [thread overview]
Message-ID: <20200226015413.GZ4764@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CACvgo53G9-WJyqdBVFFDCwVGkgZmx-WJU1kOuKvLiihWpgFVbg@mail.gmail.com>
Hi Emil,
On Mon, Feb 24, 2020 at 03:26:05PM +0000, Emil Velikov wrote:
> Thanks Laurent for sorting this out.
You're welcome. It's been bothering me for some time :-)
> On Sat, 22 Feb 2020 at 17:59, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Sat, Feb 22, 2020 at 05:24:30PM +0200, Laurent Pinchart wrote:
> > > The drm_driver structure is never modified, make it const. The improves
> > > security by avoiding writable function pointers.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> >
> > I wonder whether there's some magic somewhere we could do to enlist the
> > cocci army to create the constify patches for us ...
> >
> IIRC some drivers still manually thinker with their struct drm_driver ;-)
>
> That said, the series looks good:
> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Does this apply to the whole series, or to this patch only ?
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2020-02-26 1:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-22 15:24 [PATCH/RFC 0/3] Constify drm_driver Laurent Pinchart
2020-02-22 15:24 ` [PATCH/RFC 1/3] drm: Move legacy device list out of drm_driver Laurent Pinchart
2020-02-22 17:58 ` Daniel Vetter
2020-02-22 15:24 ` [PATCH/RFC 2/3] drm: Use a const drm_driver through the DRM core Laurent Pinchart
2020-02-22 17:59 ` Daniel Vetter
2020-02-22 15:24 ` [PATCH/RFC 3/3] drm: rcar_du: Constify drm_driver Laurent Pinchart
2020-02-22 17:59 ` Daniel Vetter
2020-02-24 15:26 ` Emil Velikov
2020-02-26 1:54 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226015413.GZ4764@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.