All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: fstests@vger.kernel.org
Subject: Re: [PATCH V2 3/3] xfs/300: modify test to work on any fs block size
Date: Wed, 26 Feb 2020 15:42:46 +0800	[thread overview]
Message-ID: <20200226074245.GS14282@dhcp-12-102.nay.redhat.com> (raw)
In-Reply-To: <x49ftf0p073.fsf@segfault.boston.devel.redhat.com>

On Mon, Feb 24, 2020 at 08:46:40AM -0500, Jeff Moyer wrote:
> Zorro Lang <zlang@redhat.com> writes:
> 
> > On Thu, Feb 20, 2020 at 03:06:32PM -0500, Jeff Moyer wrote:
> >> The test currently assumes a file system block size of 4k.  It will
> >> work just fine on any user-specified block size, though.
> >> 
> >> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
> >> ---
> >>  tests/xfs/300 | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/tests/xfs/300 b/tests/xfs/300
> >> index 28608b81..4f1c927a 100755
> >> --- a/tests/xfs/300
> >> +++ b/tests/xfs/300
> >> @@ -50,8 +50,9 @@ $XFS_IO_PROG -f -c "pwrite -S 0x63 0 4096" $SCRATCH_MNT/attrvals >> $seqres.full
> >>  cat $SCRATCH_MNT/attrvals | attr -s name $SCRATCH_MNT/$seq.test >> $seqres.full 2>&1
> >>  
> >>  # Fragment the file by writing backwards
> >> +bs=$(_get_file_block_size $SCRATCH_MNT)
> >>  for I in `seq 6 -1 0`; do
> >> -	dd if=/dev/zero of=$SCRATCH_MNT/$seq.test seek=$I bs=4k \
> >> +	dd if=/dev/zero of=$SCRATCH_MNT/$seq.test seek=$I bs=${bs} \
> >
> > Although the original case won't fail on 64k test. But this change makes
> > more sense.
> 
> It will fail for the case mentioned in the cover letter.  That is:
> 
> MKFS_OPTIONS="-m reflink=0 -b size=65536" MOUNT_OPTIONS="-o dax"
> 
> on a system with >4k page size (xfs, in this case).

Thanks, good to know that :)

> 
> Thanks,
> Jeff
> 


  reply	other threads:[~2020-02-26  7:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20 20:06 [PATCH V2 0/3] fstests: fixes for 64k pages and dax Jeff Moyer
2020-02-20 20:06 ` [PATCH V2 1/3] dax/dm: disable testing on devices that don't support dax Jeff Moyer
2020-02-21  9:48   ` Zorro Lang
2020-02-23 15:07     ` Eryu Guan
2020-02-24  6:15       ` Zorro Lang
2020-02-20 20:06 ` [PATCH V2 2/3] t_mmap_collision: fix hard-coded page size Jeff Moyer
2020-02-21 13:53   ` Zorro Lang
2020-02-20 20:06 ` [PATCH V2 3/3] xfs/300: modify test to work on any fs block size Jeff Moyer
2020-02-22  5:31   ` Zorro Lang
2020-02-24 13:46     ` Jeff Moyer
2020-02-26  7:42       ` Zorro Lang [this message]
2020-02-20 21:21 ` [PATCH V2 0/3] fstests: fixes for 64k pages and dax Darrick J. Wong
2020-02-21 20:11   ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200226074245.GS14282@dhcp-12-102.nay.redhat.com \
    --to=zlang@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.