From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Wed, 26 Feb 2020 10:18:24 +0100 Subject: [LTP] [PATCH 1/1] request_key04: Use TFAIL instead of TBROK In-Reply-To: References: <20200226084249.29561-1-pvorel@suse.cz> Message-ID: <20200226091824.GA2215@dell5510> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi Li, ... > > obvious fix which I'd normally merge without sending to ML. > > But there are 19 tests which use tst_res(TBROK, and at least some of > > them are affected by this (i.e. don't unconditionally report any result > > before tst_res(TBROK), so we might want to fix it different way. > +1 for this fix. Thanks for your review. > By the way, do you think it makes sense to add build check parameters for > tst_res() too? Just like what we do for tst_brk() in commit 0738e3753c51. IMHO if we agree that tst_res(TBROK) is harmful and should be avoided entirely, I'd be for adding this check. > Any thoughts? Kind regards, Petr