All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Chris Jerdonek <chris.jerdonek@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Subject: Re: create reflog for reflog-less ref
Date: Wed, 26 Feb 2020 04:47:16 -0500	[thread overview]
Message-ID: <20200226094716.GA14546@coredump.intra.peff.net> (raw)
In-Reply-To: <CAOTb1wfWtFsy415k+goRiuLUiVBqtizmmoyxqFdy7xsRhjnBww@mail.gmail.com>

On Tue, Feb 25, 2020 at 11:18:39PM -0800, Chris Jerdonek wrote:

> Thanks for the suggestions both of you. I didn't know about "always."
> It looks like it was added in 2.12.0:
> https://github.com/git/git/blob/master/Documentation/RelNotes/2.12.0.txt#L129
> 
> After experimenting a bit more, I seem to be finding that--
> 
> * The "one-shot" `-c core.logAllRefUpdates=always` approach only seems
> to work with git-update-ref if you're *changing* the SHA with
> update-ref, and
> * Passing `--create-reflog` also seems to work like the one-shot
> config approach (again, as long as you're changing the SHA).
> 
> I feel like these options are still wanting.. If you want to add a
> missing reflog without changing the ref, these approaches still seem
> to require you to temporarily change it to something different (as did
> the delete-create approach I stated in my first email). It would be
> nice to be able to create (or append to) the reflog without having to
> change where the ref is pointing. Or maybe I'm missing a variation
> that will do this..

No, I don't think there is a variation that will do that. You'd have to
wait for the next update.

The "touch" trick I showed would work for that, but it's not going to be
portable going forward. I don't think it would be a bad idea to have
some way of triggering a "noop" reflog update via update-ref, where we
either create the reflog as empty, or insert a pointless entry going
from the current sha1 to itself. But AFAIK that doesn't exist right now.

-Peff

  reply	other threads:[~2020-02-26  9:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  1:07 create reflog for reflog-less ref Chris Jerdonek
2020-02-26  2:39 ` brian m. carlson
2020-02-26  3:47   ` Jeff King
2020-02-26  7:18     ` Chris Jerdonek
2020-02-26  9:47       ` Jeff King [this message]
2020-02-26 10:21         ` Chris Jerdonek
2020-02-26 18:40           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200226094716.GA14546@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=chris.jerdonek@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.