From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4AB6C4BA0E for ; Wed, 26 Feb 2020 09:52:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94B022084E for ; Wed, 26 Feb 2020 09:52:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HDWSb4n3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94B022084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6tMF-00077H-P4 for qemu-devel@archiver.kernel.org; Wed, 26 Feb 2020 04:51:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59969) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6tLa-0006ZC-CU for qemu-devel@nongnu.org; Wed, 26 Feb 2020 04:51:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6tLW-00031J-Q5 for qemu-devel@nongnu.org; Wed, 26 Feb 2020 04:51:18 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:43144 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6tLW-00030c-MX for qemu-devel@nongnu.org; Wed, 26 Feb 2020 04:51:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582710671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iE6mLSQBGZOcVUs0eycAMzi27bNQgTlJa0yUROcuXvM=; b=HDWSb4n3cwZiFrme3wEtD+cOzFGOzdNWFRS8F0k2DpNmWxzuIZzcn1/r7/oPf7uD2jAI6p fNi64eiVFWI9sho2MVv5RLZ1UxzhEv+eZXKDyEabJyMR2uMgX7Avd+4i6TdupIVTzZpUJ/ k/SdxmMqfKAmx0Wmnwl7kjuYYv1gIU0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-na-B67iCPtGXhQd8SDbFqA-1; Wed, 26 Feb 2020 04:51:08 -0500 X-MC-Unique: na-B67iCPtGXhQd8SDbFqA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E17A08017CC; Wed, 26 Feb 2020 09:51:05 +0000 (UTC) Received: from linux.fritz.box (ovpn-117-170.ams2.redhat.com [10.36.117.170]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 22273385; Wed, 26 Feb 2020 09:51:03 +0000 (UTC) Date: Wed, 26 Feb 2020 10:51:02 +0100 From: Kevin Wolf To: kuhn.chenqun@huawei.com Subject: Re: [PATCH v2 01/13] block/stream: Remove redundant statement in stream_run() Message-ID: <20200226095102.GA6096@linux.fritz.box> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> <20200226084647.20636-2-kuhn.chenqun@huawei.com> MIME-Version: 1.0 In-Reply-To: <20200226084647.20636-2-kuhn.chenqun@huawei.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Max Reitz , Euler Robot , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 26.02.2020 um 09:46 hat kuhn.chenqun@huawei.com geschrieben: > From: Chen Qun >=20 > Clang static code analyzer show warning: > block/stream.c:186:9: warning: Value stored to 'ret' is never read > ret =3D 0; > ^ ~ > Reported-by: Euler Robot > Signed-off-by: Chen Qun > Reviewed-by: John Snow Let's mention that this is unnecessary since commit 1d809098aa9. Since the same commit, the initialisation 'int ret =3D 0;' is unnecessary because we never read ret before overwriting the initial value. We could clean this up in the same patch. With or without the changes: Reviewed-by: Kevin Wolf