All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pratyush Yadav <p.yadav@ti.com>
To: u-boot@lists.denx.de
Subject: [PATCH 03/15] spi: spi-mem: allow specifying whether an op is DTR or not
Date: Wed, 26 Feb 2020 18:25:53 +0530	[thread overview]
Message-ID: <20200226125606.22684-4-p.yadav@ti.com> (raw)
In-Reply-To: <20200226125606.22684-1-p.yadav@ti.com>

Each phase is given a separate 'is_dtr' field so mixed protocols like
4S-4D-4D can be supported.

Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
---
 drivers/spi/spi-mem.c | 24 ++++++++++++++++++++++++
 include/spi-mem.h     |  8 ++++++++
 2 files changed, 32 insertions(+)

diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
index e900c997bd..218496d8d2 100644
--- a/drivers/spi/spi-mem.c
+++ b/drivers/spi/spi-mem.c
@@ -104,6 +104,16 @@ void spi_controller_dma_unmap_mem_op_data(struct spi_controller *ctlr,
 EXPORT_SYMBOL_GPL(spi_controller_dma_unmap_mem_op_data);
 #endif /* __UBOOT__ */
 
+static int spi_check_dtr_req(struct spi_slave *slave, bool tx)
+{
+	u32 mode = slave->mode;
+
+	if ((tx && (mode & SPI_TX_DTR)) || (!tx && (mode & SPI_RX_DTR)))
+		return 0;
+
+	return -ENOTSUPP;
+}
+
 static int spi_check_buswidth_req(struct spi_slave *slave, u8 buswidth, bool tx)
 {
 	u32 mode = slave->mode;
@@ -158,6 +168,20 @@ bool spi_mem_default_supports_op(struct spi_slave *slave,
 				   op->data.dir == SPI_MEM_DATA_OUT))
 		return false;
 
+	if (op->cmd.is_dtr && spi_check_dtr_req(slave, true))
+		return false;
+
+	if (op->addr.is_dtr && spi_check_dtr_req(slave, true))
+		return false;
+
+	if (op->dummy.is_dtr &&
+	    spi_check_dtr_req(slave, true))
+		return false;
+
+	if (op->data.is_dtr &&
+	    spi_check_dtr_req(slave, op->data.dir == SPI_MEM_DATA_OUT))
+		return false;
+
 	return true;
 }
 EXPORT_SYMBOL_GPL(spi_mem_default_supports_op);
diff --git a/include/spi-mem.h b/include/spi-mem.h
index 36814efa86..1ae5f2b302 100644
--- a/include/spi-mem.h
+++ b/include/spi-mem.h
@@ -72,6 +72,7 @@ enum spi_mem_data_dir {
  * struct spi_mem_op - describes a SPI memory operation
  * @cmd.buswidth: number of IO lines used to transmit the command
  * @cmd.opcode: operation opcode
+ * @cmd.is_dtr: whether the command opcode should be sent in DTR mode or not
  * @addr.nbytes: number of address bytes to send. Can be zero if the operation
  *		 does not need to send an address
  * @addr.buswidth: number of IO lines used to transmit the address cycles
@@ -79,11 +80,14 @@ enum spi_mem_data_dir {
  *	      Note that only @addr.nbytes are taken into account in this
  *	      address value, so users should make sure the value fits in the
  *	      assigned number of bytes.
+ * @addr.is_dtr: whether the address should be sent in DTR mode or not
  * @dummy.nbytes: number of dummy bytes to send after an opcode or address. Can
  *		  be zero if the operation does not require dummy bytes
  * @dummy.buswidth: number of IO lanes used to transmit the dummy bytes
+ * @dummy.is_dtr: whether the dummy bytes should be sent in DTR mode or not
  * @data.buswidth: number of IO lanes used to send/receive the data
  * @data.dir: direction of the transfer
+ * @data.is_dtr: whether the data should be sent in DTR mode or not
  * @data.buf.in: input buffer
  * @data.buf.out: output buffer
  */
@@ -91,23 +95,27 @@ struct spi_mem_op {
 	struct {
 		u8 buswidth;
 		u8 opcode;
+		bool is_dtr;
 	} cmd;
 
 	struct {
 		u8 nbytes;
 		u8 buswidth;
 		u64 val;
+		bool is_dtr;
 	} addr;
 
 	struct {
 		u8 nbytes;
 		u8 buswidth;
+		bool is_dtr;
 	} dummy;
 
 	struct {
 		u8 buswidth;
 		enum spi_mem_data_dir dir;
 		unsigned int nbytes;
+		bool is_dtr;
 		/* buf.{in,out} must be DMA-able. */
 		union {
 			void *in;
-- 
2.25.0

  parent reply	other threads:[~2020-02-26 12:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 12:55 [PATCH 00/15] mtd: spi-nor-core: add xSPI Octal DTR support Pratyush Yadav
2020-02-26 12:55 ` [PATCH 01/15] dt-bindings: spi: allow expressing DTR capability Pratyush Yadav
2020-02-26 12:55 ` [PATCH 02/15] spi: set mode bits for "spi-rx-dtr" and "spi-tx-dtr" Pratyush Yadav
2020-02-26 12:55 ` Pratyush Yadav [this message]
2020-02-26 12:55 ` [PATCH 04/15] spi: spi-mem: allow specifying a command's extension Pratyush Yadav
2020-02-26 12:55 ` [PATCH 05/15] spi: cadence-qspi: Do not calibrate when device tree sets read delay Pratyush Yadav
2020-02-26 12:55 ` [PATCH 06/15] spi: cadence-qspi: Add support for octal DTR flashes Pratyush Yadav
2020-02-26 12:55 ` [PATCH 07/15] mtd: spi-nor-core: Add a ->setup() hook Pratyush Yadav
2020-02-26 12:55 ` [PATCH 08/15] mtd: spi-nor-core: Move SFDP related declarations to top Pratyush Yadav
2020-02-26 12:55 ` [PATCH 09/15] mtd: spi-nor-core: Introduce flash-specific fixup hooks Pratyush Yadav
2020-03-12  6:34   ` Vignesh Raghavendra
2020-03-12  7:29     ` Pratyush Yadav
2020-02-26 12:56 ` [PATCH 10/15] mtd: spi-nor-core: Add support for DTR protocol Pratyush Yadav
2020-02-26 12:56 ` [PATCH 11/15] mtd: spi-nor-core: Get command opcode extension type from BFPT Pratyush Yadav
2020-02-26 12:56 ` [PATCH 12/15] mtd: spi-nor-core: Parse xSPI Profile 1.0 table Pratyush Yadav
2020-02-26 12:56 ` [PATCH 13/15] mtd: spi-nor-core: Use Read SR dummy cycle and address width from SFDP Pratyush Yadav
2020-02-26 12:56 ` [PATCH 14/15] mtd: spi-nor-core: Enable octal DTR mode when possible Pratyush Yadav
2020-02-26 12:56 ` [PATCH 15/15] mtd: spi-nor-core: Add support for Cypress Semper flash Pratyush Yadav
2020-02-26 12:56 ` [NOT FOR MERGE PATCH 16/15] arm: dts: k3-j721e: Update OSPI settings for octal DTR mode Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200226125606.22684-4-p.yadav@ti.com \
    --to=p.yadav@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.