* [PATCH -next] leds: leds-bd2802: remove set but not used variable 'pdata'
@ 2020-01-08 1:53 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2020-01-08 1:53 UTC (permalink / raw)
To: Jacek Anaszewski, Pavel Machek, Linus Walleij, Dan Murphy
Cc: YueHaibing, linux-leds, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/leds/leds-bd2802.c: In function 'bd2802_probe':
drivers/leds/leds-bd2802.c:663:35: warning:
variable 'pdata' set but not used [-Wunused-but-set-variable]
commit 4c3718f9d6a6 ("leds: bd2802: Convert to use GPIO descriptors")
left behind this unused variable.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/leds/leds-bd2802.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/leds/leds-bd2802.c b/drivers/leds/leds-bd2802.c
index bd61a823d0ca..8bbaef5a2986 100644
--- a/drivers/leds/leds-bd2802.c
+++ b/drivers/leds/leds-bd2802.c
@@ -660,7 +660,6 @@ static int bd2802_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct bd2802_led *led;
- struct bd2802_led_platform_data *pdata;
int ret, i;
led = devm_kzalloc(&client->dev, sizeof(struct bd2802_led), GFP_KERNEL);
@@ -668,7 +667,6 @@ static int bd2802_probe(struct i2c_client *client,
return -ENOMEM;
led->client = client;
- pdata = led->pdata = dev_get_platdata(&client->dev);
i2c_set_clientdata(client, led);
/*
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next] leds: leds-bd2802: remove set but not used variable 'pdata'
@ 2020-01-08 1:53 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2020-01-08 1:53 UTC (permalink / raw)
To: Jacek Anaszewski, Pavel Machek, Linus Walleij, Dan Murphy
Cc: YueHaibing, linux-leds, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/leds/leds-bd2802.c: In function 'bd2802_probe':
drivers/leds/leds-bd2802.c:663:35: warning:
variable 'pdata' set but not used [-Wunused-but-set-variable]
commit 4c3718f9d6a6 ("leds: bd2802: Convert to use GPIO descriptors")
left behind this unused variable.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/leds/leds-bd2802.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/leds/leds-bd2802.c b/drivers/leds/leds-bd2802.c
index bd61a823d0ca..8bbaef5a2986 100644
--- a/drivers/leds/leds-bd2802.c
+++ b/drivers/leds/leds-bd2802.c
@@ -660,7 +660,6 @@ static int bd2802_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct bd2802_led *led;
- struct bd2802_led_platform_data *pdata;
int ret, i;
led = devm_kzalloc(&client->dev, sizeof(struct bd2802_led), GFP_KERNEL);
@@ -668,7 +667,6 @@ static int bd2802_probe(struct i2c_client *client,
return -ENOMEM;
led->client = client;
- pdata = led->pdata = dev_get_platdata(&client->dev);
i2c_set_clientdata(client, led);
/*
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] leds: leds-bd2802: remove set but not used variable 'pdata'
2020-01-08 1:53 ` YueHaibing
@ 2020-01-08 17:06 ` Linus Walleij
-1 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2020-01-08 17:06 UTC (permalink / raw)
To: YueHaibing
Cc: Jacek Anaszewski, Pavel Machek, Dan Murphy, Linux LED Subsystem,
linux-kernel, kernel-janitors
On Wed, Jan 8, 2020 at 2:57 AM YueHaibing <yuehaibing@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/leds/leds-bd2802.c: In function 'bd2802_probe':
> drivers/leds/leds-bd2802.c:663:35: warning:
> variable 'pdata' set but not used [-Wunused-but-set-variable]
>
> commit 4c3718f9d6a6 ("leds: bd2802: Convert to use GPIO descriptors")
> left behind this unused variable.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] leds: leds-bd2802: remove set but not used variable 'pdata'
@ 2020-01-08 17:06 ` Linus Walleij
0 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2020-01-08 17:06 UTC (permalink / raw)
To: YueHaibing
Cc: Jacek Anaszewski, Pavel Machek, Dan Murphy, Linux LED Subsystem,
linux-kernel, kernel-janitors
On Wed, Jan 8, 2020 at 2:57 AM YueHaibing <yuehaibing@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/leds/leds-bd2802.c: In function 'bd2802_probe':
> drivers/leds/leds-bd2802.c:663:35: warning:
> variable 'pdata' set but not used [-Wunused-but-set-variable]
>
> commit 4c3718f9d6a6 ("leds: bd2802: Convert to use GPIO descriptors")
> left behind this unused variable.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] leds: leds-bd2802: remove set but not used variable 'pdata'
2020-01-08 1:53 ` YueHaibing
@ 2020-02-26 13:35 ` Pavel Machek
-1 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2020-02-26 13:35 UTC (permalink / raw)
To: YueHaibing
Cc: Jacek Anaszewski, Linus Walleij, Dan Murphy, linux-leds,
linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On Wed 2020-01-08 01:53:22, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/leds/leds-bd2802.c: In function 'bd2802_probe':
> drivers/leds/leds-bd2802.c:663:35: warning:
> variable 'pdata' set but not used [-Wunused-but-set-variable]
>
> commit 4c3718f9d6a6 ("leds: bd2802: Convert to use GPIO descriptors")
> left behind this unused variable.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks, applied.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] leds: leds-bd2802: remove set but not used variable 'pdata'
@ 2020-02-26 13:35 ` Pavel Machek
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2020-02-26 13:35 UTC (permalink / raw)
To: YueHaibing
Cc: Jacek Anaszewski, Linus Walleij, Dan Murphy, linux-leds,
linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On Wed 2020-01-08 01:53:22, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/leds/leds-bd2802.c: In function 'bd2802_probe':
> drivers/leds/leds-bd2802.c:663:35: warning:
> variable 'pdata' set but not used [-Wunused-but-set-variable]
>
> commit 4c3718f9d6a6 ("leds: bd2802: Convert to use GPIO descriptors")
> left behind this unused variable.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks, applied.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-26 13:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08 1:53 [PATCH -next] leds: leds-bd2802: remove set but not used variable 'pdata' YueHaibing
2020-01-08 1:53 ` YueHaibing
2020-01-08 17:06 ` Linus Walleij
2020-01-08 17:06 ` Linus Walleij
2020-02-26 13:35 ` Pavel Machek
2020-02-26 13:35 ` Pavel Machek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.