From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C851C4BA15 for ; Wed, 26 Feb 2020 16:31:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30CD6206E6 for ; Wed, 26 Feb 2020 16:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727909AbgBZQbq (ORCPT ); Wed, 26 Feb 2020 11:31:46 -0500 Received: from muru.com ([72.249.23.125]:57758 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726905AbgBZQbp (ORCPT ); Wed, 26 Feb 2020 11:31:45 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 9BCE38022; Wed, 26 Feb 2020 16:32:28 +0000 (UTC) Date: Wed, 26 Feb 2020 08:31:40 -0800 From: Tony Lindgren To: afzal mohammed Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Krzysztof Halasa , Russell King , Hartley Sweeten , Alexander Sverdlin , Lubomir Rintel , Kevin Hilman , Aaro Koskinen , Viresh Kumar , Shiraz Hashim , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Allison Randal , Greg Kroah-Hartman , Thomas Gleixner , Arnd Bergmann , Enrico Weigelt Subject: Re: [PATCH v2 02/18] ARM: replace setup_irq() by request_irq() Message-ID: <20200226163140.GP37466@atomide.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * afzal mohammed [200224 00:49]: > request_irq() is preferred over setup_irq(). The early boot setup_irq() > invocations happen either via 'init_IRQ()' or 'time_init()', while > memory allocators are ready by 'mm_init()'. > > Per tglx[1], setup_irq() existed in olden days when allocators were not > ready by the time early interrupts were initialized. > > Hence replace setup_irq() by request_irq(). > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > Signed-off-by: afzal mohammed > Acked-by: Viresh Kumar > Acked-by: Alexander Sverdlin # EP93xx > Tested-by: Alexander Sverdlin # EP93xx Works for me: Tested-by: Tony Lindgren # omap1 osk From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1FCEC4BA18 for ; Wed, 26 Feb 2020 16:31:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A103206E6 for ; Wed, 26 Feb 2020 16:31:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lTTYjxSr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A103206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iemlFvRsItp0uWWdY0uxo38YmgiyteuJ8C5n1th2SLA=; b=lTTYjxSrKDOBSt P1XoCejLYTPCTdw4Kcp/3WH2WLn9j5/dL0BCuE5fdOmxb7/ydZvTKGNERqTywjENiztf8pNWclU43 efVy8PQ2fA0TAvOJlU1Ja8n+jTqiu40vycM2+CMFLqKotflAwJSl6m9xGEFCNfSoR9jzMMdP169SF kWFoVGo0YFblYGiRoPM2Y0wLfIATcUD/QhyXm4NBYCeiN+K2DMEIQPSicLfGDz36qwm9FWM6IdI7O WTOzl1nyQZEBtEXvVSfw1YQ38RJQquiDgynmrdI50lmfN0Vq7KiWfBQXLOJsI0eghwKx1WgNzUI+3 yen0nc+WpRLFjWTbx2Vw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6zbA-0001G7-1P; Wed, 26 Feb 2020 16:31:48 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6zb7-0001Fg-PP for linux-arm-kernel@lists.infradead.org; Wed, 26 Feb 2020 16:31:47 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 9BCE38022; Wed, 26 Feb 2020 16:32:28 +0000 (UTC) Date: Wed, 26 Feb 2020 08:31:40 -0800 From: Tony Lindgren To: afzal mohammed Subject: Re: [PATCH v2 02/18] ARM: replace setup_irq() by request_irq() Message-ID: <20200226163140.GP37466@atomide.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200226_083145_863833_E8FD416B X-CRM114-Status: UNSURE ( 7.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Jason Cooper , Arnd Bergmann , Lubomir Rintel , Enrico Weigelt , Viresh Kumar , Gregory Clement , Kevin Hilman , linux-kernel@vger.kernel.org, Russell King , Hartley Sweeten , Krzysztof Halasa , Allison Randal , Greg Kroah-Hartman , Aaro Koskinen , Thomas Gleixner , linux-omap@vger.kernel.org, Alexander Sverdlin , Shiraz Hashim , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * afzal mohammed [200224 00:49]: > request_irq() is preferred over setup_irq(). The early boot setup_irq() > invocations happen either via 'init_IRQ()' or 'time_init()', while > memory allocators are ready by 'mm_init()'. > > Per tglx[1], setup_irq() existed in olden days when allocators were not > ready by the time early interrupts were initialized. > > Hence replace setup_irq() by request_irq(). > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > Signed-off-by: afzal mohammed > Acked-by: Viresh Kumar > Acked-by: Alexander Sverdlin # EP93xx > Tested-by: Alexander Sverdlin # EP93xx Works for me: Tested-by: Tony Lindgren # omap1 osk _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel