From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: digetx@gmail.com, alsa-devel@alsa-project.org,
ranjani.sridharan@linux.intel.com,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
pierre-louis.bossart@linux.intel.com
Subject: Re: [PATCH] ASoC: soc-pcm: Revert "call snd_soc_component_open/close() once"
Date: Wed, 26 Feb 2020 17:36:11 +0000 [thread overview]
Message-ID: <20200226173611.GI4136@sirena.org.uk> (raw)
In-Reply-To: <87ftey88wk.wl-kuninori.morimoto.gx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
On Wed, Feb 26, 2020 at 09:55:47AM +0900, Kuninori Morimoto wrote:
> If each component / rtd / dai have "done" flag or count,
> soc_pcm_open() can call soc_pcm_close() directly
> without thinking about "until", because each flag can handle/indicate it.
> The good point is we can reduce duplicate implementation.
> And it can avoid future bug. Because today, we need to care both
> soc_pcm_close() and error handling in soc_pcm_open(), it is not good for me.
That goal definitely makes sense, if we can avoid problems like the ones
here it seems like a useful change.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-26 17:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 18:26 [PATCH] ASoC: soc-pcm: Revert "call snd_soc_component_open/close() once" Kai Vehmanen
2020-02-19 18:53 ` Kai Vehmanen
2020-02-19 19:27 ` Pierre-Louis Bossart
2020-02-19 19:37 ` Dmitry Osipenko
2020-02-20 0:42 ` Kuninori Morimoto
2020-02-20 0:59 ` [PATCH][RFC] ASoC: soc-component: count snd_soc_component_open/close() Kuninori Morimoto
2020-02-20 1:25 ` Sridharan, Ranjani
2020-02-20 1:41 ` Kuninori Morimoto
2020-02-20 1:57 ` Sridharan, Ranjani
2020-02-20 3:01 ` Kuninori Morimoto
2020-02-20 9:33 ` [PATCH] ASoC: soc-pcm: Revert "call snd_soc_component_open/close() once" Kai Vehmanen
2020-02-21 1:13 ` Kuninori Morimoto
2020-02-21 11:09 ` Kai Vehmanen
2020-02-25 0:41 ` Kuninori Morimoto
2020-02-26 0:55 ` Kuninori Morimoto
2020-02-26 17:36 ` Mark Brown [this message]
2020-02-27 0:11 ` Kuninori Morimoto
2020-02-27 9:41 ` Kai Vehmanen
2020-02-28 0:46 ` Kuninori Morimoto
2020-02-28 6:27 ` Kuninori Morimoto
2020-02-28 7:57 ` Kuninori Morimoto
2020-02-28 12:23 ` Kai Vehmanen
2020-03-02 0:29 ` Kuninori Morimoto
2020-03-02 18:22 ` Kai Vehmanen
2020-03-03 0:43 ` Kuninori Morimoto
2020-03-03 19:48 ` Kai Vehmanen
2020-03-04 0:11 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226173611.GI4136@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=digetx@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.