All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Niek Linnenbank" <nieklinnenbank@gmail.com>,
	qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v1 2/4] accel/tcg: remove link between guest ram and TCG cache size
Date: Wed, 26 Feb 2020 18:10:18 +0000	[thread overview]
Message-ID: <20200226181020.19592-3-alex.bennee@linaro.org> (raw)
In-Reply-To: <20200226181020.19592-1-alex.bennee@linaro.org>

Basing the TB cache size on the ram_size was always a little heuristic
and was broken by a1b18df9a4 which caused ram_size not to be fully
realised at the time we initialise the TCG translation cache.

The current DEFAULT_CODE_GEN_BUFFER_SIZE may still be a little small
but follow-up patches will address that.

Fixes: a1b18df9a4
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Niek Linnenbank <nieklinnenbank@gmail.com>
Cc: Igor Mammedov <imammedo@redhat.com>
---
 accel/tcg/translate-all.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 238b0e575bf..5b66af783b5 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -938,15 +938,7 @@ static inline size_t size_code_gen_buffer(size_t tb_size)
 {
     /* Size the buffer.  */
     if (tb_size == 0) {
-#ifdef USE_STATIC_CODE_GEN_BUFFER
         tb_size = DEFAULT_CODE_GEN_BUFFER_SIZE;
-#else
-        /* ??? Needs adjustments.  */
-        /* ??? If we relax the requirement that CONFIG_USER_ONLY use the
-           static buffer, we could size this on RESERVED_VA, on the text
-           segment size of the executable, or continue to use the default.  */
-        tb_size = (unsigned long)(ram_size / 4);
-#endif
     }
     if (tb_size < MIN_CODE_GEN_BUFFER_SIZE) {
         tb_size = MIN_CODE_GEN_BUFFER_SIZE;
-- 
2.20.1



  parent reply	other threads:[~2020-02-26 18:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 18:10 [PATCH v1 0/4] Fix codegen translation cache size Alex Bennée
2020-02-26 18:10 ` [PATCH v1 1/4] accel/tcg: use units.h for defining code gen buffer sizes Alex Bennée
2020-02-26 22:00   ` Niek Linnenbank
2020-02-26 22:49   ` Richard Henderson
2020-02-27 10:54   ` Philippe Mathieu-Daudé
2020-02-26 18:10 ` Alex Bennée [this message]
2020-02-26 22:26   ` [PATCH v1 2/4] accel/tcg: remove link between guest ram and TCG cache size Niek Linnenbank
2020-02-26 22:50     ` Richard Henderson
2020-02-26 22:49   ` Richard Henderson
2020-02-27 10:58   ` Philippe Mathieu-Daudé
2020-02-26 18:10 ` [PATCH v1 3/4] accel/tcg: only USE_STATIC_CODE_GEN_BUFFER on 32 bit hosts Alex Bennée
2020-02-26 22:50   ` Richard Henderson
2020-02-27 10:55   ` Philippe Mathieu-Daudé
2020-02-27 19:20   ` Niek Linnenbank
2020-02-26 18:10 ` [PATCH v1 4/4] accel/tcg: increase default code gen buffer size for 64 bit Alex Bennée
2020-02-26 22:45   ` Niek Linnenbank
2020-02-27 12:19     ` Alex Bennée
2020-02-27 19:01       ` Niek Linnenbank
2020-02-26 22:55   ` Richard Henderson
2020-02-27 12:31     ` Alex Bennée
2020-02-27 12:56       ` Richard Henderson
2020-02-27 14:13         ` Igor Mammedov
2020-02-27 19:07         ` Niek Linnenbank
2020-02-28  7:47           ` Igor Mammedov
2020-02-28 19:20             ` Alex Bennée
2020-02-28  7:54         ` [PATCH] " Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200226181020.19592-3-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=imammedo@redhat.com \
    --cc=nieklinnenbank@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.