From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, kuba@kernel.org, ayal@mellanox.com,
saeedm@mellanox.com, ranro@mellanox.com, moshe@mellanox.com
Subject: Re: [patch net v2] mlx5: register lag notifier for init network namespace only
Date: Thu, 27 Feb 2020 11:16:46 -0800 (PST) [thread overview]
Message-ID: <20200227.111646.1790531386593657307.davem@davemloft.net> (raw)
In-Reply-To: <20200227072210.1270-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 27 Feb 2020 08:22:10 +0100
> From: Jiri Pirko <jiri@mellanox.com>
>
> The current code causes problems when the unregistering netdevice could
> be different then the registering one.
>
> Since the check in mlx5_lag_netdev_event() does not allow any other
> network namespace anyway, fix this by registerting the lag notifier
> per init network namespace only.
>
> Fixes: d48834f9d4b4 ("mlx5: Use dev_net netdevice notifier registrations")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> Tested-by: Aya Levin <ayal@mellanox.com>
> Acked-by: Saeed Mahameed <saeedm@mellanox.com>
> ---
> v1->v2:
> - removed unused variable
Applied, thanks for the quick follow-up Jiri.
prev parent reply other threads:[~2020-02-27 19:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 7:22 [patch net v2] mlx5: register lag notifier for init network namespace only Jiri Pirko
2020-02-27 19:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227.111646.1790531386593657307.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ayal@mellanox.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ranro@mellanox.com \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.