All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Bulekov <alxndr@bu.edu>
To: Eric Blake <eblake@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, Bandan Das <bsd@redhat.com>,
	stefanha@redhat.com, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/2] fuzz: fix typos in linker-script comments
Date: Wed, 26 Feb 2020 22:09:39 -0500	[thread overview]
Message-ID: <20200227030939.lk2ponyffzvstxhq@mozz.bu.edu> (raw)
In-Reply-To: <3476395c-3aba-6246-d11c-f108e33edfcd@redhat.com>

On 200226 2055, Eric Blake wrote:
> On 2/26/20 8:48 PM, Alexander Bulekov wrote:
> > Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> > ---
> >   tests/qtest/fuzz/fork_fuzz.ld | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/qtest/fuzz/fork_fuzz.ld b/tests/qtest/fuzz/fork_fuzz.ld
> > index b23a59f194..b5aad06f20 100644
> > --- a/tests/qtest/fuzz/fork_fuzz.ld
> > +++ b/tests/qtest/fuzz/fork_fuzz.ld
> > @@ -1,5 +1,5 @@
> >   /* We adjust linker script modification to place all of the stuff that needs to
> > - * persist across fuzzing runs into a contiguous seciton of memory. Then, it is
> > + * persist across fuzzing runs into a contiguous section of memory. Then, it is
> >    * easy to re-map the counter-related memory as shared.
> >   */
> > @@ -32,6 +32,6 @@ SECTIONS
> >         __FUZZ_COUNTERS_END = .;
> >     }
> >   }
> > -/* Dont overwrite the SECTIONS in the default linker script. Instead insert the
> > +/* Don't overwrite the SECTIONS in the default linker script. Instead insert the
> >    * above into the default script */
> 
> As long as you're touching these two comments, checkpatch is going to
> complain that they don't follow the usual style of:
> 
> /*
>  * Text starts here...
>  * through here.
>  */
> 
> If you fix that as well for these two comments,
> Reviewed-by: Eric Blake <eblake@redhat.com> 

Must have missed it since the file has a .ld extension.
Thanks!
-Alex

> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
> 


  reply	other threads:[~2020-02-27  3:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27  2:48 [PATCH 0/2] Fix spelling/formatting in fuzzing patches Alexander Bulekov
2020-02-27  2:48 ` [PATCH 1/2] fuzz: fix typos in linker-script comments Alexander Bulekov
2020-02-27  2:55   ` Eric Blake
2020-02-27  3:09     ` Alexander Bulekov [this message]
2020-02-27  2:48 ` [PATCH 2/2] qtest: fix fuzzer-related 80-char limit violations Alexander Bulekov
2020-02-27  2:56   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200227030939.lk2ponyffzvstxhq@mozz.bu.edu \
    --to=alxndr@bu.edu \
    --cc=bsd@redhat.com \
    --cc=eblake@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.