From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC6CC11D3D for ; Thu, 27 Feb 2020 16:17:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5FAC92469F for ; Thu, 27 Feb 2020 16:17:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YDIG629t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728059AbgB0QRo (ORCPT ); Thu, 27 Feb 2020 11:17:44 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:34566 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729689AbgB0QRo (ORCPT ); Thu, 27 Feb 2020 11:17:44 -0500 Received: by mail-pg1-f195.google.com with SMTP id t3so1718270pgn.1 for ; Thu, 27 Feb 2020 08:17:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vtq0s3tQnCqURKTOAldGkoKbYrI0rQodXXv9xIVTT3Y=; b=YDIG629tX7x9Pmb6sOmczh6ju+bZ3q+dGbK7sBRcVdlqc0F739Ir2LJfcrSO7KrD8p calXeJ+GMbO9XewuL7HizNgGs/JA+ljTxX/tVQ9yMZ5GWuvmuwGMBVduj+CIScUSXBtj UyGuooe9zEJNdNmNz1GrIjjcFKI0T/Zrkmnkk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vtq0s3tQnCqURKTOAldGkoKbYrI0rQodXXv9xIVTT3Y=; b=LCN+cNroDPZLULBGsLOSSX3s1z5GrVdcdreISMz4/5lNRculhgZ0HGLfV9Is8K7RvS fdFqEMODNoY0TIw70SG9UVf0guFmIX/dtsM2pE4u7FDUK4JcsAbIGwqsTlOLd21VRJ/c 00pNFTJdNn8mY9/my6mod1I2wrnjB5IbMetDoBX0zH+NP3RMf4apKBOKnwsdBWDoqeb+ 23X5lR71prmbC09KPnN9loZeT6t9LSmhTm+Oio3IXhbDmmBmGnZznHzt8V8u6pncOQb8 uOQY16wIPi/EJr3zFluHtyO7P8W8FhWE/9lbQC51qucVJUTjLCeCfqGBt59tQAATZV/V 7S7g== X-Gm-Message-State: APjAAAWFoYLJibjaJ5aOaSGzBQjMnJn1zqiW5+ft6o8y+6Ra4sYoxnBG tRk/H5cF573AQlxPDcKl2ifoGg== X-Google-Smtp-Source: APXvYqwJAwotmy024gEz2pgQK+lDCNvJc7X5WXUKZHZ3LEAhFZZwS2O/ca0qkaW45CWAD2FYKcCGrw== X-Received: by 2002:aa7:9f90:: with SMTP id z16mr4879847pfr.161.1582820262963; Thu, 27 Feb 2020 08:17:42 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z30sm7726657pff.131.2020.02.27.08.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 08:17:42 -0800 (PST) Date: Thu, 27 Feb 2020 08:17:41 -0800 From: Kees Cook To: Christophe Leroy Cc: Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] selftest/lkdtm: Use local .gitignore Message-ID: <202002270817.1C32C98@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 27, 2020 at 02:07:10PM +0000, Christophe Leroy wrote: > Commit 68ca0fd272da ("selftest/lkdtm: Don't pollute 'git status'") > introduced patterns for git to ignore files generated in > tools/testing/selftests/lkdtm/ > > Use local .gitignore file instead of using the root one. > > Fixes: 68ca0fd272da ("selftest/lkdtm: Don't pollute 'git status'") > Signed-off-by: Christophe Leroy Yeah, that's better. Thanks! Acked-by: Kees Cook -Kees > --- > .gitignore | 4 ---- > tools/testing/selftests/lkdtm/.gitignore | 2 ++ > 2 files changed, 2 insertions(+), 4 deletions(-) > create mode 100644 tools/testing/selftests/lkdtm/.gitignore > > diff --git a/.gitignore b/.gitignore > index bb05dce58f8e..b849a72d69d5 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -100,10 +100,6 @@ modules.order > /include/ksym/ > /arch/*/include/generated/ > > -# Generated lkdtm tests > -/tools/testing/selftests/lkdtm/*.sh > -!/tools/testing/selftests/lkdtm/run.sh > - > # stgit generated dirs > patches-* > > diff --git a/tools/testing/selftests/lkdtm/.gitignore b/tools/testing/selftests/lkdtm/.gitignore > new file mode 100644 > index 000000000000..f26212605b6b > --- /dev/null > +++ b/tools/testing/selftests/lkdtm/.gitignore > @@ -0,0 +1,2 @@ > +*.sh > +!run.sh > -- > 2.25.0 > -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5258C3567B for ; Thu, 27 Feb 2020 16:23:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22436246B1 for ; Thu, 27 Feb 2020 16:23:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YDIG629t" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22436246B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48Syf52760zDqFh for ; Fri, 28 Feb 2020 03:23:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=chromium.org (client-ip=2607:f8b0:4864:20::541; helo=mail-pg1-x541.google.com; envelope-from=keescook@chromium.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=YDIG629t; dkim-atps=neutral Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48SyWG65t1zDr1Z for ; Fri, 28 Feb 2020 03:17:46 +1100 (AEDT) Received: by mail-pg1-x541.google.com with SMTP id h8so1700801pgs.9 for ; Thu, 27 Feb 2020 08:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vtq0s3tQnCqURKTOAldGkoKbYrI0rQodXXv9xIVTT3Y=; b=YDIG629tX7x9Pmb6sOmczh6ju+bZ3q+dGbK7sBRcVdlqc0F739Ir2LJfcrSO7KrD8p calXeJ+GMbO9XewuL7HizNgGs/JA+ljTxX/tVQ9yMZ5GWuvmuwGMBVduj+CIScUSXBtj UyGuooe9zEJNdNmNz1GrIjjcFKI0T/Zrkmnkk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vtq0s3tQnCqURKTOAldGkoKbYrI0rQodXXv9xIVTT3Y=; b=FMKBxqg19MDkkKphoWOaHwykCAcfqGPEXWhVEgxftwx/GD0nEh8GK6VlkBDi+8x39C nbnw/SgXC4AvV5N3E3+JW138sjk4N/gNWc6nvBeJ4A2UHOPQG+T5Ki7y0HDm26qer7f4 ZBBypJIrF3V93EiYj0FVnUePTX+ud+NAK1mbtrRCfR3z0fh941Bj0gR1J7z6KkNEviaZ sh9ASfzRlJBA906IcnxsfNqlnzVg1V8UMIFIK5SXiOIa9GbV8LJyLJ4ZXma+lDRtOLGI unfFFG11gLfNx9k7b/1C7Du8RKtjooJiW9OFLcrmWPlnI1k+DK7jQwcz0JUSuTFlrzgM pisg== X-Gm-Message-State: APjAAAVc56BB9alP1mBW/MZuBAXmw7baVfA09QIEmpBlfMIgx38teku7 /1GwNFkXQ8Se48aKOg4zS7ZRdA== X-Google-Smtp-Source: APXvYqwJAwotmy024gEz2pgQK+lDCNvJc7X5WXUKZHZ3LEAhFZZwS2O/ca0qkaW45CWAD2FYKcCGrw== X-Received: by 2002:aa7:9f90:: with SMTP id z16mr4879847pfr.161.1582820262963; Thu, 27 Feb 2020 08:17:42 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z30sm7726657pff.131.2020.02.27.08.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 08:17:42 -0800 (PST) Date: Thu, 27 Feb 2020 08:17:41 -0800 From: Kees Cook To: Christophe Leroy Subject: Re: [PATCH] selftest/lkdtm: Use local .gitignore Message-ID: <202002270817.1C32C98@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Feb 27, 2020 at 02:07:10PM +0000, Christophe Leroy wrote: > Commit 68ca0fd272da ("selftest/lkdtm: Don't pollute 'git status'") > introduced patterns for git to ignore files generated in > tools/testing/selftests/lkdtm/ > > Use local .gitignore file instead of using the root one. > > Fixes: 68ca0fd272da ("selftest/lkdtm: Don't pollute 'git status'") > Signed-off-by: Christophe Leroy Yeah, that's better. Thanks! Acked-by: Kees Cook -Kees > --- > .gitignore | 4 ---- > tools/testing/selftests/lkdtm/.gitignore | 2 ++ > 2 files changed, 2 insertions(+), 4 deletions(-) > create mode 100644 tools/testing/selftests/lkdtm/.gitignore > > diff --git a/.gitignore b/.gitignore > index bb05dce58f8e..b849a72d69d5 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -100,10 +100,6 @@ modules.order > /include/ksym/ > /arch/*/include/generated/ > > -# Generated lkdtm tests > -/tools/testing/selftests/lkdtm/*.sh > -!/tools/testing/selftests/lkdtm/run.sh > - > # stgit generated dirs > patches-* > > diff --git a/tools/testing/selftests/lkdtm/.gitignore b/tools/testing/selftests/lkdtm/.gitignore > new file mode 100644 > index 000000000000..f26212605b6b > --- /dev/null > +++ b/tools/testing/selftests/lkdtm/.gitignore > @@ -0,0 +1,2 @@ > +*.sh > +!run.sh > -- > 2.25.0 > -- Kees Cook