From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE64C11D3D for ; Thu, 27 Feb 2020 15:05:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 27D4E24697 for ; Thu, 27 Feb 2020 15:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730937AbgB0PFm (ORCPT ); Thu, 27 Feb 2020 10:05:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:60336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729235AbgB0PFl (ORCPT ); Thu, 27 Feb 2020 10:05:41 -0500 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8078724691; Thu, 27 Feb 2020 15:05:40 +0000 (UTC) Date: Thu, 27 Feb 2020 10:05:38 -0500 From: Steven Rostedt To: Geert Uytterhoeven Cc: Masami Hiramatsu , Borislav Petkov , LKML , Ingo Molnar , Andrew Morton , Peter Zijlstra Subject: Re: [PATCH v2 1/8] bootconfig: Set CONFIG_BOOT_CONFIG=n by default Message-ID: <20200227100538.58127eeb@gandalf.local.home> In-Reply-To: References: <158220110257.26565.4812934676257459744.stgit@devnote2> <158220111291.26565.9036889083940367969.stgit@devnote2> <20200227092732.6a22a71a@gandalf.local.home> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Feb 2020 15:47:45 +0100 Geert Uytterhoeven wrote: > Hi Steven, > > On Thu, Feb 27, 2020 at 3:27 PM Steven Rostedt wrote: > > On Thu, 27 Feb 2020 10:22:00 +0100 > > Geert Uytterhoeven wrote: > > > > +static int __init warn_bootconfig(char *str) > > > > +{ > > > > + pr_warn("WARNING: 'bootconfig' found on the kernel command line but CONFIG_BOOTCONFIG is not set.\n"); > > > > + return 0; > > > > +} > > > > +early_param("bootconfig", warn_bootconfig); > > > > > > Yeah, let's increases kernel size for the people who don't want to jump > > > on the bootconfig wagon :-( > > > > > > Is this really needed? > > > > Yes, because if someone adds bootconfig to the command line they would be > > expecting their bootconfig to be read. If not, we should not fail silently. > > If someone adds "ip=on" to the command line, they expect DHCP to work. > Woops, you need CONFIG_IP_PNP for that. > If someone adds "nfsroot=..." to the command line, they expect the NFS > root fielsystem to be mounted. > Guess how many options need to be enabled for that? This isn't the same. It's more like having "ip=on" and ip configured, but nothing happening because the command line isn't being read. > > Perhaps we need CONFIG_COMMAND_NOT_FOUND? > > Kernel panic - not syncing: option "inspecial" not found. > Did you mean: > > option "imspecial" from section "mine" > option "urspecial" from section "yours" > > Try enabling it with "make xconfig". > > > Are you really concerned about a tiny __init function that gets freed after > > boot up? > > It's still part of the initial kernel image, and thus subject to boot loader and > platform limitations. And still in the noise of other aspects of the kernel. For little instances like this, there should be a CONFIG_TINY (I thought we had that?), otherwise it's going to be annoying. (Remember, I was fighting for not having a config option at all to disable CONFIG_BOOTCONFIG). -- Steve