From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1653C4BA24 for ; Thu, 27 Feb 2020 10:37:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AE7324680 for ; Thu, 27 Feb 2020 10:37:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aa4vgDIl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AE7324680 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7GXm-00038q-Ne for qemu-devel@archiver.kernel.org; Thu, 27 Feb 2020 05:37:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48082) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7GWh-0002DI-9O for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:36:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7GWg-0005YO-EH for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:36:19 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:22554 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7GWg-0005Wh-AD for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:36:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582799776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JILzDXFzULTdhG901zVUqSOj7HSBQlTVMMYzuuuzfG4=; b=aa4vgDIl0FDTrEKwKlCe3U6ncdWGMomM+T0hQV1TI0TzTUWwpfAqLRY4zI/RYecnOlTsAS 3TQmaZ8E0bd0cRj5VlihWzkitGnVA/XPrsjQXuP4Zf6+wIwN7A1nOec/rWP4xtZG/WcPuw gwU8CBFhPW+YX5AxL0a8rcV/r1F8oWY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-292-vtGcmaXQPYSYT-ZoCzlJJA-1; Thu, 27 Feb 2020 05:36:15 -0500 X-MC-Unique: vtGcmaXQPYSYT-ZoCzlJJA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 07E378017CC; Thu, 27 Feb 2020 10:36:14 +0000 (UTC) Received: from gondolin (ovpn-117-2.ams2.redhat.com [10.36.117.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4EA7B1001B09; Thu, 27 Feb 2020 10:36:10 +0000 (UTC) Date: Thu, 27 Feb 2020 11:36:08 +0100 From: Cornelia Huck To: Janosch Frank Subject: Re: [PATCH v6] s390x: Rename and use constants for short PSW address and mask Message-ID: <20200227113608.0c6dae95.cohuck@redhat.com> In-Reply-To: <20200227092341.38558-1-frankja@linux.ibm.com> References: <20200227100632.5292d773.cohuck@redhat.com> <20200227092341.38558-1-frankja@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: borntraeger@de.ibm.com, qemu-s390x@nongnu.org, qemu-devel@nongnu.org, david@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 27 Feb 2020 04:23:41 -0500 Janosch Frank wrote: > Let's rename PSW_MASK_ESA_ADDR to PSW_MASK_SHORT_ADDR because we're > not working with a ESA PSW which would not support the extended > addressing bit. Also let's actually use it. > > Additionally we introduce PSW_MASK_SHORT_CTRL and use it throughout > the codebase. > > Signed-off-by: Janosch Frank > Reviewed-by: Christian Borntraeger > --- > hw/s390x/ipl.c | 2 +- > target/s390x/cpu.c | 4 ++-- > target/s390x/cpu.h | 3 ++- > 3 files changed, 5 insertions(+), 4 deletions(-) Thanks, applied.