From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F678C4BA2D for ; Thu, 27 Feb 2020 12:38:48 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03A8F24698 for ; Thu, 27 Feb 2020 12:38:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="pPSuuNFr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03A8F24698 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6CB491655; Thu, 27 Feb 2020 13:37:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6CB491655 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582807126; bh=z+/TFPWWZ/v/DAeVF8jj8cL3hIQOlnu6Hah1TliDYLI=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pPSuuNFrmwmTguOOCE5rvmiAx66KGX1iOp5fhRCTisj+V7/emk41RalS0kDIC8xVC y/PnsZicjC8Wf2hf2G631oG5/SQ7VRKqOdxpsOHfUKw7+EoXbkBMgTEU9vX1B+RoaT QXLqUCKex4aSsUhkbRzDGKPv0jtRm8jkAyOuhbHA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C973FF800E8; Thu, 27 Feb 2020 13:37:55 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8D9BDF80142; Thu, 27 Feb 2020 13:37:53 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by alsa1.perex.cz (Postfix) with ESMTP id A216FF80089 for ; Thu, 27 Feb 2020 13:37:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A216FF80089 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C57B1FB; Thu, 27 Feb 2020 04:37:48 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 86F173F73B; Thu, 27 Feb 2020 04:37:47 -0800 (PST) Date: Thu, 27 Feb 2020 12:37:45 +0000 From: Mark Brown To: Kuninori Morimoto Subject: Re: [PATCH v2 6/8] ASoC: soc-pcm: check DAI's activity more simply Message-ID: <20200227123745.GA4062@sirena.org.uk> References: <87o8tk7q34.wl-kuninori.morimoto.gx@renesas.com> <87ftew7q12.wl-kuninori.morimoto.gx@renesas.com> <878sko7o0e.wl-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Content-Disposition: inline In-Reply-To: <878sko7o0e.wl-kuninori.morimoto.gx@renesas.com> X-Cookie: Edwin Meese made me wear CORDOVANS!! User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Linux-ALSA X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 27, 2020 at 11:38:41AM +0900, Kuninori Morimoto wrote: > > @@ -1225,15 +1224,10 @@ static int soc_pcm_hw_free(struct snd_pcm_substream *substream) > > + for_each_rtd_codec_dai(rtd, i, codec_dai) > > + if (codec_dai->active) > > snd_soc_dai_digital_mute(codec_dai, 1, > > substream->stream); > I noticed that it calls snd_soc_dai_digital_mute(xxx, substream->stream). > This means, it want to call mute for each Playback/Capture "last user". > This patch was total wrong. > Mark, [6/8] is wrong. maybe I need to reconsider [7/8]. > Can you please ignore these ? > Please let me know if you need v3 I can drop those two, it's fine. --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5XuBYACgkQJNaLcl1U h9A/hQf/bwKlG2jjXr5hw10+tGAE9lB3IrFpDmk6Yk9c6gD0vXkgUL+YK9m2AJGE 7vdoC9klinx4CZxCWNi9UNMs+ejOl9bQLgu+Obucts4y7KN3yRVP2ZTPm5cSQZe7 xSPy4PMmy1/PnfScYFiJIuadiP6It9FvGBFaAk9g9vVdCvCFPGgbQAzqfy1iN/Ld 1Gstbk1tQHj+GOnooKN9/LX9cfx2xtGYauLDdpciPyG0luWBkbcx8nIf/sV9dJq5 mAUVpvNAt0RSmpUbU2ZInL5FyhGec8Z9PnD6qzzVXtwA3T/Ry/HVzZY3+txj2V7J n3Zf5QsJc2VgVH7YFrsy3klJpM1gyQ== =ny3D -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu--